You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/10/10 16:14:29 UTC
[GitHub] [hudi] pratyakshsharma opened a new pull request #3776: [WIP]: added guides section
pratyakshsharma opened a new pull request #3776:
URL: https://github.com/apache/hudi/pull/3776
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] pratyakshsharma commented on pull request #3776: [HUDI-2543]: Added guides section
Posted by GitBox <gi...@apache.org>.
pratyakshsharma commented on pull request #3776:
URL: https://github.com/apache/hudi/pull/3776#issuecomment-939794284
Thank you @vingov , that helped fix the issue! :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on pull request #3776: [HUDI-2543]: Added guides section
Posted by GitBox <gi...@apache.org>.
yihua commented on pull request #3776:
URL: https://github.com/apache/hudi/pull/3776#issuecomment-992122994
@pratyakshsharma any update on the nit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vingov edited a comment on pull request #3776: [WIP]: added guides section
Posted by GitBox <gi...@apache.org>.
vingov edited a comment on pull request #3776:
URL: https://github.com/apache/hudi/pull/3776#issuecomment-939722960
@pratyakshsharma - there are few changes required to fix the build, please apply this attached patch to make it work.
[build-fix-patch.txt](https://github.com/apache/hudi/files/7319995/build-fix-patch.txt)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on pull request #3776: [HUDI-2543]: Added guides section
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #3776:
URL: https://github.com/apache/hudi/pull/3776#issuecomment-994228135
We have a "Guides" side nav now. We can move this there. cc @kywe665 as FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #3776: [HUDI-2543]: Added guides section
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #3776:
URL: https://github.com/apache/hudi/pull/3776#issuecomment-943312764
One nit. When I mouse over "Guides", I see Tuning as first entry and Trouble shooting as 2nd entry. while on the left pane order is different. Can we fix that.
<img width="695" alt="Screen Shot 2021-10-14 at 5 31 21 AM" src="https://user-images.githubusercontent.com/513218/137317986-5061c313-8b5a-47b4-837b-16d7b6f45956.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] pratyakshsharma commented on pull request #3776: [HUDI-2543]: Added guides section
Posted by GitBox <gi...@apache.org>.
pratyakshsharma commented on pull request #3776:
URL: https://github.com/apache/hudi/pull/3776#issuecomment-994803802
will sync up with @vingov on this and close this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vingov commented on pull request #3776: [WIP]: added guides section
Posted by GitBox <gi...@apache.org>.
vingov commented on pull request #3776:
URL: https://github.com/apache/hudi/pull/3776#issuecomment-939722960
@pratyakshsharma - there are few changes required to fix the build, please apply this patch to make it work.
```
diff --git a/website/docusaurus.config.js b/website/docusaurus.config.js
index b5b0af7e6..3496aa32b 100644
--- a/website/docusaurus.config.js
+++ b/website/docusaurus.config.js
@@ -65,6 +65,16 @@ module.exports = {
showLastUpdateTime: false,
},
],
+ [
+ '@docusaurus/plugin-content-docs',
+ {
+ id: 'guides',
+ path: 'guides',
+ routeBasePath: 'guides',
+ showLastUpdateAuthor: false,
+ showLastUpdateTime: false,
+ },
+ ],
[
'@docusaurus/plugin-client-redirects',
{
diff --git a/website/guides/troubleshooting-guide.md b/website/guides/troubleshooting-guide.md
index 26dcd1913..d6fde30f9 100644
--- a/website/guides/troubleshooting-guide.md
+++ b/website/guides/troubleshooting-guide.md
@@ -1,5 +1,5 @@
---
-title: "Troubleshooting Guide"
+title: Troubleshooting Guide
keywords: [hudi, tuning, performance]
last_modified_at: 2021-09-29T15:59:57-04:00
---
@@ -24,7 +24,7 @@ For such errors, please try to ensure only valid data type conversions are happe
Sample stacktrace when trying to evolve a field from Long type to Integer type with Hudi : https://gist.github.com/nsivabalan/0d81cd60a3e7a0501e6a0cb50bfaacea
-### org.apache.hudi.exception.SchemaCompatabilityException: Unable to validate the rewritten record <record> against schema <schema> at org.apache.hudi.common.util.HoodieAvroUtils.rewrite(HoodieAvroUtils.java:215)
+### org.apache.hudi.exception.SchemaCompatabilityException: Unable to validate the rewritten record <record> against schema <schema> at org.apache.hudi.common.util.HoodieAvroUtils.rewrite(HoodieAvroUtils.java:215)
This can possibly occur if your schema has some non-nullable field whose value is not present or is null. It is recommended to evolve schema in backwards compatible ways. In essence, this means either have every newly added field as nullable or define default values for every new field. In case if you are relying on default value for your field, as of Hudi version 0.5.1, this is not handled.
@@ -78,7 +78,7 @@ This will usually happen when you are trying to add a new column to existing hiv
set hive.metastore.disallow.incompatible.col.type.changes=false;
```
-### com.uber.hoodie.hive.HoodieHiveSyncException: Could not convert field Type from <type1> to <type2> for field col1
+### com.uber.hoodie.hive.HoodieHiveSyncException: Could not convert field Type from <type1> to <type2> for field col1
This occurs because HiveSyncTool currently supports only few compatible data type conversions. Doing any other incompatible change will throw this exception. Please check the data type evolution for the concerned field and verify if it indeed can be considered as a valid data type conversion as per Hudi code base.
diff --git a/website/guides/tuning-guide.md b/website/guides/tuning-guide.md
index e0dabd091..581778aa9 100644
--- a/website/guides/tuning-guide.md
+++ b/website/guides/tuning-guide.md
@@ -1,5 +1,5 @@
---
-title: "Tuning Guide"
+title: Tuning Guide
keywords: [hudi, tuning, performance]
last_modified_at: 2021-09-29T15:59:57-04:00
---
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] pratyakshsharma commented on pull request #3776: [HUDI-2543]: Added guides section
Posted by GitBox <gi...@apache.org>.
pratyakshsharma commented on pull request #3776:
URL: https://github.com/apache/hudi/pull/3776#issuecomment-940247146
@vinothchandar please take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] pratyakshsharma commented on pull request #3776: [HUDI-2543]: Added guides section
Posted by GitBox <gi...@apache.org>.
pratyakshsharma commented on pull request #3776:
URL: https://github.com/apache/hudi/pull/3776#issuecomment-994907300
@nsivabalan Please take a pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] pratyakshsharma commented on pull request #3776: [WIP]: added guides section
Posted by GitBox <gi...@apache.org>.
pratyakshsharma commented on pull request #3776:
URL: https://github.com/apache/hudi/pull/3776#issuecomment-939518351
@vingov Can you check the failure once?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] pratyakshsharma commented on pull request #3776: [HUDI-2543]: Added guides section
Posted by GitBox <gi...@apache.org>.
pratyakshsharma commented on pull request #3776:
URL: https://github.com/apache/hudi/pull/3776#issuecomment-995512290
looks like there was some issue with the build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] pratyakshsharma commented on pull request #3776: [HUDI-2543]: Added guides section
Posted by GitBox <gi...@apache.org>.
pratyakshsharma commented on pull request #3776:
URL: https://github.com/apache/hudi/pull/3776#issuecomment-1010244213
@nsivabalan @vinothchandar I see these changes are not reflecting on the website. Is it related to this build failure?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] pratyakshsharma commented on pull request #3776: [HUDI-2543]: Added guides section
Posted by GitBox <gi...@apache.org>.
pratyakshsharma commented on pull request #3776:
URL: https://github.com/apache/hudi/pull/3776#issuecomment-951158019
@nsivabalan I had noticed this already. Actually this problem exists with other sub pages as well. Let me take a look and check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan merged pull request #3776: [HUDI-2543]: Added guides section
Posted by GitBox <gi...@apache.org>.
nsivabalan merged pull request #3776:
URL: https://github.com/apache/hudi/pull/3776
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org