You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "turboFei (via GitHub)" <gi...@apache.org> on 2023/06/11 14:49:59 UTC
[GitHub] [kyuubi] turboFei opened a new pull request, #4949: For operation getNextRowSet method, with operation lock required
turboFei opened a new pull request, #4949:
URL: https://github.com/apache/kyuubi/pull/4949
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
2. If the PR is related to an issue in https://github.com/apache/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on pull request #4949: For operation getNextRowSet method, with operation lock required
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #4949:
URL: https://github.com/apache/kyuubi/pull/4949#issuecomment-1586459572
> ... it might throw exception(if the jdbc client to kyuubi server connection socket timeout).
The change makes sense to me, but I don't get your point. JDBC is the single thread model, why connection socket timeout could cause NPE?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] turboFei commented on pull request #4949: For operation getNextRowSet method, with operation lock required
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on PR #4949:
URL: https://github.com/apache/kyuubi/pull/4949#issuecomment-1586614174
thanks, merged to 1.7.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] turboFei closed pull request #4949: For operation getNextRowSet method, with operation lock required
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei closed pull request #4949: For operation getNextRowSet method, with operation lock required
URL: https://github.com/apache/kyuubi/pull/4949
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] codecov-commenter commented on pull request #4949: For operation getNextRowSet method, with operation lock required
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4949:
URL: https://github.com/apache/kyuubi/pull/4949#issuecomment-1586226623
## [Codecov](https://app.codecov.io/gh/apache/kyuubi/pull/4949?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#4949](https://app.codecov.io/gh/apache/kyuubi/pull/4949?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (8f18f32) into [master](https://app.codecov.io/gh/apache/kyuubi/commit/f040d7ca25e87d1ae67d4ef38f24199a95da7f6e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f040d7c) will **not change** coverage.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #4949 +/- ##
=======================================
Coverage 0.00% 0.00%
=======================================
Files 557 563 +6
Lines 30718 30933 +215
Branches 4005 4032 +27
=======================================
- Misses 30718 30933 +215
```
| [Impacted Files](https://app.codecov.io/gh/apache/kyuubi/pull/4949?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...kyuubi/engine/spark/operation/SparkOperation.scala](https://app.codecov.io/gh/apache/kyuubi/pull/4949?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9vcGVyYXRpb24vU3BhcmtPcGVyYXRpb24uc2NhbGE=) | `0.00% <ø> (ø)` | |
| [...rg/apache/kyuubi/operation/AbstractOperation.scala](https://app.codecov.io/gh/apache/kyuubi/pull/4949?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vQWJzdHJhY3RPcGVyYXRpb24uc2NhbGE=) | `0.00% <0.00%> (ø)` | |
| [.../apache/kyuubi/operation/ExecutedCommandExec.scala](https://app.codecov.io/gh/apache/kyuubi/pull/4949?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vRXhlY3V0ZWRDb21tYW5kRXhlYy5zY2FsYQ==) | `0.00% <ø> (ø)` | |
| [.../kyuubi/operation/KyuubiApplicationOperation.scala](https://app.codecov.io/gh/apache/kyuubi/pull/4949?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpQXBwbGljYXRpb25PcGVyYXRpb24uc2NhbGE=) | `0.00% <ø> (ø)` | |
| [.../org/apache/kyuubi/operation/KyuubiOperation.scala](https://app.codecov.io/gh/apache/kyuubi/pull/4949?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uLnNjYWxh) | `0.00% <ø> (ø)` | |
... and [32 files with indirect coverage changes](https://app.codecov.io/gh/apache/kyuubi/pull/4949/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] turboFei commented on pull request #4949: For operation getNextRowSet method, with operation lock required
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on PR #4949:
URL: https://github.com/apache/kyuubi/pull/4949#issuecomment-1586467895
> why connection socket timeout could cause NPE?
For incremental collect mode, the fetchResult might trigger a spark task to collect the incremental result.
The jdbc client to kyuubi gateway timeout, but the fetchResult request has been sent to engine.
Then the jdbc client re-send the fetchResult request.
And the getNextResultSet in spark engine side concurrent execute.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org