You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Michal Capo (JIRA)" <ji...@apache.org> on 2007/10/27 00:11:50 UTC

[jira] Created: (WICKET-1105) Missing javascript header referencies in Wicket portlet

Missing javascript header referencies in Wicket portlet
-------------------------------------------------------

                 Key: WICKET-1105
                 URL: https://issues.apache.org/jira/browse/WICKET-1105
             Project: Wicket
          Issue Type: Bug
          Components: wicket-portlet
         Environment: wicket trunk revision 588784
JDK 1.5.0_13-b05
Maven version: 2.0.7
            Reporter: Michal Capo


I have two wicket portlets using RatingPanel they are almost same. There is one difference in the markup.

First:
<head>
	<link rel="stylesheet" type="text/css" href="style.css"/>
</head>
<html>
	<span wicket:id="rating"></span>
</html>

Second:
<html>
	<span wicket:id="rating"></span>
</html>

In first one is request executed via ajax. In second one not. In first one rendered page contains reference to 'wicket-ajax.js' file but in the second not.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (WICKET-1105) Missing javascript header referencies in Wicket portlet

Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Johan Compagner reassigned WICKET-1105:
---------------------------------------

    Assignee: Juergen Donnerstag  (was: Johan Compagner)

juergen, this is more your area i think, but can you look at this one or give me a pointer where to look?
We make with the HtmlHeaderSectionHandler that does the parsign and inserts a special tag if it find the body..
So this is sometimes not possible because there is no body. Then we need to throw an exception if somehow we 
want to contribute to that. But on which place exactly is an header container created (where we test on the special tag that got inserted)
i see the HtmlHeaderResolver but thats just testing specific tags so we can't do it there either.

So what could be the place to test if there is a HtmlHeaderContainer added to a page? it can't be onBeforeRender of the page becaus then the html header is not resolved yet right? So is it only possible after the render? test did we make a HtmlHeaderContainer yes or no? But then we don't know if we really needed it... But i guess thats not a problem. 

Normally all pages should have a html header container right (after render)

> Missing javascript header referencies in Wicket portlet
> -------------------------------------------------------
>
>                 Key: WICKET-1105
>                 URL: https://issues.apache.org/jira/browse/WICKET-1105
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-portlet
>         Environment: wicket trunk revision 588784
> JDK 1.5.0_13-b05
> Maven version: 2.0.7
>            Reporter: Michal Capo
>            Assignee: Juergen Donnerstag
>         Attachments: wicket-portlets-test.zip
>
>
> I have two wicket portlets using RatingPanel they are almost same. There is one difference in the markup.
> First:
> <head>
> 	<link rel="stylesheet" type="text/css" href="style.css"/>
> </head>
> <html>
> 	<span wicket:id="rating"></span>
> </html>
> Second:
> <html>
> 	<span wicket:id="rating"></span>
> </html>
> In first one is request executed via ajax. In second one not. In first one rendered page contains reference to 'wicket-ajax.js' file but in the second not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (WICKET-1105) Missing javascript header referencies in Wicket portlet

Posted by "Michal Capo (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538120 ] 

capo edited comment on WICKET-1105 at 10/26/07 3:19 PM:
---------------------------------------------------------------

Test portlets for bug reproduction.

Steps:
1. unzip file
2. 'mvn eclipse:eclipse' (for eclipse of course)
3. run 'TestPortal' bean like java application (in src/test/java folder)
4. type in your browser 'http://localhost:8083/portlet1' for good behavior (request via ajax)
5. type in your browser 'http://localhost:8083/portlet2' for bad behavior (normal request)


      was (Author: capo):
    Test portlets for bug reproduction.

Steps:
1. unzip file
2. 'mvn eclipse:eclipse' (for eclipse of course)
3. run 'TestPortal' bean like java application (in src/test/java folder)
4. type in your browser 'http://localhost:8083/portlet1' for good behavior
5. type in your browser 'http://localhost:8083/portlet2' for bad behavior

  
> Missing javascript header referencies in Wicket portlet
> -------------------------------------------------------
>
>                 Key: WICKET-1105
>                 URL: https://issues.apache.org/jira/browse/WICKET-1105
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-portlet
>         Environment: wicket trunk revision 588784
> JDK 1.5.0_13-b05
> Maven version: 2.0.7
>            Reporter: Michal Capo
>         Attachments: wicket-portlets-test.zip
>
>
> I have two wicket portlets using RatingPanel they are almost same. There is one difference in the markup.
> First:
> <head>
> 	<link rel="stylesheet" type="text/css" href="style.css"/>
> </head>
> <html>
> 	<span wicket:id="rating"></span>
> </html>
> Second:
> <html>
> 	<span wicket:id="rating"></span>
> </html>
> In first one is request executed via ajax. In second one not. In first one rendered page contains reference to 'wicket-ajax.js' file but in the second not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-1105) Missing javascript header referencies in Wicket portlet

Posted by "Matej Knopp (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538123 ] 

Matej Knopp commented on WICKET-1105:
-------------------------------------

The second markup file was missing both the <head> and <body> tags. Wicket needs at least <body> tag in markup file so that it knows where to put the <head> tags (in case those are not provided). Maybe we could log an error at least in this case?

> Missing javascript header referencies in Wicket portlet
> -------------------------------------------------------
>
>                 Key: WICKET-1105
>                 URL: https://issues.apache.org/jira/browse/WICKET-1105
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-portlet
>         Environment: wicket trunk revision 588784
> JDK 1.5.0_13-b05
> Maven version: 2.0.7
>            Reporter: Michal Capo
>            Assignee: Matej Knopp
>         Attachments: wicket-portlets-test.zip
>
>
> I have two wicket portlets using RatingPanel they are almost same. There is one difference in the markup.
> First:
> <head>
> 	<link rel="stylesheet" type="text/css" href="style.css"/>
> </head>
> <html>
> 	<span wicket:id="rating"></span>
> </html>
> Second:
> <html>
> 	<span wicket:id="rating"></span>
> </html>
> In first one is request executed via ajax. In second one not. In first one rendered page contains reference to 'wicket-ajax.js' file but in the second not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-1105) Missing javascript header referencies in Wicket portlet

Posted by "Michal Capo (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538127 ] 

Michal Capo commented on WICKET-1105:
-------------------------------------

Huh what a quick support. Thanx.

> Missing javascript header referencies in Wicket portlet
> -------------------------------------------------------
>
>                 Key: WICKET-1105
>                 URL: https://issues.apache.org/jira/browse/WICKET-1105
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-portlet
>         Environment: wicket trunk revision 588784
> JDK 1.5.0_13-b05
> Maven version: 2.0.7
>            Reporter: Michal Capo
>            Assignee: Matej Knopp
>         Attachments: wicket-portlets-test.zip
>
>
> I have two wicket portlets using RatingPanel they are almost same. There is one difference in the markup.
> First:
> <head>
> 	<link rel="stylesheet" type="text/css" href="style.css"/>
> </head>
> <html>
> 	<span wicket:id="rating"></span>
> </html>
> Second:
> <html>
> 	<span wicket:id="rating"></span>
> </html>
> In first one is request executed via ajax. In second one not. In first one rendered page contains reference to 'wicket-ajax.js' file but in the second not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-1105) Missing javascript header referencies when there are no body or head tags.

Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12581379#action_12581379 ] 

Johan Compagner commented on WICKET-1105:
-----------------------------------------

that check is pretty much already in but disabled..
And i dont know exactly why it is disabled, but that could be because the bug maurice did find a few days back.
I have first to check that one out then i can see if this check can be enabled again.

> Missing javascript header referencies when there are no body or head tags.
> --------------------------------------------------------------------------
>
>                 Key: WICKET-1105
>                 URL: https://issues.apache.org/jira/browse/WICKET-1105
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>         Environment: wicket trunk revision 588784
> JDK 1.5.0_13-b05
> Maven version: 2.0.7
>            Reporter: Michal Capo
>            Assignee: Johan Compagner
>             Fix For: 1.3.3
>
>         Attachments: wicket-portlets-test.zip
>
>
> I have two wicket portlets using RatingPanel they are almost same. There is one difference in the markup.
> First:
> <head>
> 	<link rel="stylesheet" type="text/css" href="style.css"/>
> </head>
> <html>
> 	<span wicket:id="rating"></span>
> </html>
> Second:
> <html>
> 	<span wicket:id="rating"></span>
> </html>
> In first one is request executed via ajax. In second one not. In first one rendered page contains reference to 'wicket-ajax.js' file but in the second not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (WICKET-1105) Missing javascript header referencies in Wicket portlet

Posted by "Matej Knopp (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matej Knopp reassigned WICKET-1105:
-----------------------------------

    Assignee: Johan Compagner  (was: Matej Knopp)

We should throw an exception if there is no <body> tag in markup file. Right now we just silently fail to respond header contribuion which is not good.

> Missing javascript header referencies in Wicket portlet
> -------------------------------------------------------
>
>                 Key: WICKET-1105
>                 URL: https://issues.apache.org/jira/browse/WICKET-1105
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-portlet
>         Environment: wicket trunk revision 588784
> JDK 1.5.0_13-b05
> Maven version: 2.0.7
>            Reporter: Michal Capo
>            Assignee: Johan Compagner
>         Attachments: wicket-portlets-test.zip
>
>
> I have two wicket portlets using RatingPanel they are almost same. There is one difference in the markup.
> First:
> <head>
> 	<link rel="stylesheet" type="text/css" href="style.css"/>
> </head>
> <html>
> 	<span wicket:id="rating"></span>
> </html>
> Second:
> <html>
> 	<span wicket:id="rating"></span>
> </html>
> In first one is request executed via ajax. In second one not. In first one rendered page contains reference to 'wicket-ajax.js' file but in the second not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (WICKET-1105) Missing javascript header referencies in Wicket portlet

Posted by "Michal Capo (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538120 ] 

capo edited comment on WICKET-1105 at 10/26/07 3:19 PM:
---------------------------------------------------------------

Test portlets for bug reproduction.

Steps:
1. unzip file
2. 'mvn eclipse:eclipse' (for eclipse of course)
3. run 'TestPortal' bean like java application (in src/test/java folder)
4. type in your browser 'http://localhost:8083/portlet1' for good behavior
5. type in your browser 'http://localhost:8083/portlet2' for bad behavior


      was (Author: capo):
    Test portlets for bug reproduction.

Steps:
1. unzip file
2. 'mvn eclipse:eclipse' (for eclipse of course)
3. run 'TestPortal' bean like java application (in src/test/java folder)
4. type in your browser 'http://localhost:8083/portlet1' for bad behavior
5. type in your browser 'http://localhost:8083/portlet2' for bad behavior

  
> Missing javascript header referencies in Wicket portlet
> -------------------------------------------------------
>
>                 Key: WICKET-1105
>                 URL: https://issues.apache.org/jira/browse/WICKET-1105
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-portlet
>         Environment: wicket trunk revision 588784
> JDK 1.5.0_13-b05
> Maven version: 2.0.7
>            Reporter: Michal Capo
>         Attachments: wicket-portlets-test.zip
>
>
> I have two wicket portlets using RatingPanel they are almost same. There is one difference in the markup.
> First:
> <head>
> 	<link rel="stylesheet" type="text/css" href="style.css"/>
> </head>
> <html>
> 	<span wicket:id="rating"></span>
> </html>
> Second:
> <html>
> 	<span wicket:id="rating"></span>
> </html>
> In first one is request executed via ajax. In second one not. In first one rendered page contains reference to 'wicket-ajax.js' file but in the second not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1105) Missing javascript header referencies when there are no body or head tags.

Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Frank Bille Jensen updated WICKET-1105:
---------------------------------------

    Fix Version/s:     (was: 1.3.0-rc2)
                   1.3.0-rc3

> Missing javascript header referencies when there are no body or head tags.
> --------------------------------------------------------------------------
>
>                 Key: WICKET-1105
>                 URL: https://issues.apache.org/jira/browse/WICKET-1105
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>         Environment: wicket trunk revision 588784
> JDK 1.5.0_13-b05
> Maven version: 2.0.7
>            Reporter: Michal Capo
>            Assignee: Juergen Donnerstag
>             Fix For: 1.3.0-rc3
>
>         Attachments: wicket-portlets-test.zip
>
>
> I have two wicket portlets using RatingPanel they are almost same. There is one difference in the markup.
> First:
> <head>
> 	<link rel="stylesheet" type="text/css" href="style.css"/>
> </head>
> <html>
> 	<span wicket:id="rating"></span>
> </html>
> Second:
> <html>
> 	<span wicket:id="rating"></span>
> </html>
> In first one is request executed via ajax. In second one not. In first one rendered page contains reference to 'wicket-ajax.js' file but in the second not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-1105) Missing javascript header referencies when there are no body or head tags.

Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12547398 ] 

Juergen Donnerstag commented on WICKET-1105:
--------------------------------------------

in WebPage.afterRender() we remove HeaderContainers from the component hierarchy. I extended that code in a way that if no HeaderContainer was found and we are in development mode than a HeaderContainer is created, added to the page and executed. The result is what would have been rendered and if that is more than nothing than we log and error. For know is just a log and no exception.

I keep this issue open for a few more days to watch it

> Missing javascript header referencies when there are no body or head tags.
> --------------------------------------------------------------------------
>
>                 Key: WICKET-1105
>                 URL: https://issues.apache.org/jira/browse/WICKET-1105
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>         Environment: wicket trunk revision 588784
> JDK 1.5.0_13-b05
> Maven version: 2.0.7
>            Reporter: Michal Capo
>            Assignee: Juergen Donnerstag
>             Fix For: 1.3.0-rc2
>
>         Attachments: wicket-portlets-test.zip
>
>
> I have two wicket portlets using RatingPanel they are almost same. There is one difference in the markup.
> First:
> <head>
> 	<link rel="stylesheet" type="text/css" href="style.css"/>
> </head>
> <html>
> 	<span wicket:id="rating"></span>
> </html>
> Second:
> <html>
> 	<span wicket:id="rating"></span>
> </html>
> In first one is request executed via ajax. In second one not. In first one rendered page contains reference to 'wicket-ajax.js' file but in the second not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (WICKET-1105) Missing javascript header referencies when there are no body or head tags.

Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Johan Compagner closed WICKET-1105.
-----------------------------------

    Resolution: Fixed

the test should now work correctly and not result in an error

> Missing javascript header referencies when there are no body or head tags.
> --------------------------------------------------------------------------
>
>                 Key: WICKET-1105
>                 URL: https://issues.apache.org/jira/browse/WICKET-1105
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>         Environment: wicket trunk revision 588784
> JDK 1.5.0_13-b05
> Maven version: 2.0.7
>            Reporter: Michal Capo
>            Assignee: Johan Compagner
>             Fix For: 1.3.3
>
>         Attachments: wicket-portlets-test.zip
>
>
> I have two wicket portlets using RatingPanel they are almost same. There is one difference in the markup.
> First:
> <head>
> 	<link rel="stylesheet" type="text/css" href="style.css"/>
> </head>
> <html>
> 	<span wicket:id="rating"></span>
> </html>
> Second:
> <html>
> 	<span wicket:id="rating"></span>
> </html>
> In first one is request executed via ajax. In second one not. In first one rendered page contains reference to 'wicket-ajax.js' file but in the second not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (WICKET-1105) Missing javascript header referencies in Wicket portlet

Posted by "Matej Knopp (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matej Knopp reassigned WICKET-1105:
-----------------------------------

    Assignee: Matej Knopp

> Missing javascript header referencies in Wicket portlet
> -------------------------------------------------------
>
>                 Key: WICKET-1105
>                 URL: https://issues.apache.org/jira/browse/WICKET-1105
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-portlet
>         Environment: wicket trunk revision 588784
> JDK 1.5.0_13-b05
> Maven version: 2.0.7
>            Reporter: Michal Capo
>            Assignee: Matej Knopp
>         Attachments: wicket-portlets-test.zip
>
>
> I have two wicket portlets using RatingPanel they are almost same. There is one difference in the markup.
> First:
> <head>
> 	<link rel="stylesheet" type="text/css" href="style.css"/>
> </head>
> <html>
> 	<span wicket:id="rating"></span>
> </html>
> Second:
> <html>
> 	<span wicket:id="rating"></span>
> </html>
> In first one is request executed via ajax. In second one not. In first one rendered page contains reference to 'wicket-ajax.js' file but in the second not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1105) Missing javascript header referencies when there are no body or head tags.

Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Frank Bille Jensen updated WICKET-1105:
---------------------------------------

    Fix Version/s:     (was: 1.3.0-rc3)
                   1.3.1

> Missing javascript header referencies when there are no body or head tags.
> --------------------------------------------------------------------------
>
>                 Key: WICKET-1105
>                 URL: https://issues.apache.org/jira/browse/WICKET-1105
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>         Environment: wicket trunk revision 588784
> JDK 1.5.0_13-b05
> Maven version: 2.0.7
>            Reporter: Michal Capo
>            Assignee: Juergen Donnerstag
>             Fix For: 1.3.1
>
>         Attachments: wicket-portlets-test.zip
>
>
> I have two wicket portlets using RatingPanel they are almost same. There is one difference in the markup.
> First:
> <head>
> 	<link rel="stylesheet" type="text/css" href="style.css"/>
> </head>
> <html>
> 	<span wicket:id="rating"></span>
> </html>
> Second:
> <html>
> 	<span wicket:id="rating"></span>
> </html>
> In first one is request executed via ajax. In second one not. In first one rendered page contains reference to 'wicket-ajax.js' file but in the second not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-1105) Missing javascript header referencies when there are no body or head tags.

Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12547402 ] 

Juergen Donnerstag commented on WICKET-1105:
--------------------------------------------

a few more comments:

- it is onDetach() not afterRender().
- since onDetach() catches all exceptions but doesn't forward them, which means no error page, logging is probably the best we can do.
- there are 2 test cases in our test base which now print such a error message but since log.error is disabled you won't see them
- this is not a comprehensive test. If you replace or remove components which want to contribute to the header than they are not detected. And we are not testing everything, just webpages (no ajax calls)
- one of the problems is that basically all beahvors (AbstractBehavior) implement IHeaderContributor and thus you can test for components and behavior which implement that interface. You must actually test whether they write something to the header response.


> Missing javascript header referencies when there are no body or head tags.
> --------------------------------------------------------------------------
>
>                 Key: WICKET-1105
>                 URL: https://issues.apache.org/jira/browse/WICKET-1105
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>         Environment: wicket trunk revision 588784
> JDK 1.5.0_13-b05
> Maven version: 2.0.7
>            Reporter: Michal Capo
>            Assignee: Juergen Donnerstag
>             Fix For: 1.3.0-rc2
>
>         Attachments: wicket-portlets-test.zip
>
>
> I have two wicket portlets using RatingPanel they are almost same. There is one difference in the markup.
> First:
> <head>
> 	<link rel="stylesheet" type="text/css" href="style.css"/>
> </head>
> <html>
> 	<span wicket:id="rating"></span>
> </html>
> Second:
> <html>
> 	<span wicket:id="rating"></span>
> </html>
> In first one is request executed via ajax. In second one not. In first one rendered page contains reference to 'wicket-ajax.js' file but in the second not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1105) Missing javascript header referencies when there are no body or head tags.

Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Frank Bille Jensen updated WICKET-1105:
---------------------------------------

    Fix Version/s:     (was: 1.3.2)
                   1.3.3

> Missing javascript header referencies when there are no body or head tags.
> --------------------------------------------------------------------------
>
>                 Key: WICKET-1105
>                 URL: https://issues.apache.org/jira/browse/WICKET-1105
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>         Environment: wicket trunk revision 588784
> JDK 1.5.0_13-b05
> Maven version: 2.0.7
>            Reporter: Michal Capo
>            Assignee: Juergen Donnerstag
>             Fix For: 1.3.3
>
>         Attachments: wicket-portlets-test.zip
>
>
> I have two wicket portlets using RatingPanel they are almost same. There is one difference in the markup.
> First:
> <head>
> 	<link rel="stylesheet" type="text/css" href="style.css"/>
> </head>
> <html>
> 	<span wicket:id="rating"></span>
> </html>
> Second:
> <html>
> 	<span wicket:id="rating"></span>
> </html>
> In first one is request executed via ajax. In second one not. In first one rendered page contains reference to 'wicket-ajax.js' file but in the second not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (WICKET-1105) Missing javascript header referencies when there are no body or head tags.

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg reassigned WICKET-1105:
-------------------------------------

    Assignee: Johan Compagner  (was: Juergen Donnerstag)

are we going to add that error check johan?

> Missing javascript header referencies when there are no body or head tags.
> --------------------------------------------------------------------------
>
>                 Key: WICKET-1105
>                 URL: https://issues.apache.org/jira/browse/WICKET-1105
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>         Environment: wicket trunk revision 588784
> JDK 1.5.0_13-b05
> Maven version: 2.0.7
>            Reporter: Michal Capo
>            Assignee: Johan Compagner
>             Fix For: 1.3.3
>
>         Attachments: wicket-portlets-test.zip
>
>
> I have two wicket portlets using RatingPanel they are almost same. There is one difference in the markup.
> First:
> <head>
> 	<link rel="stylesheet" type="text/css" href="style.css"/>
> </head>
> <html>
> 	<span wicket:id="rating"></span>
> </html>
> Second:
> <html>
> 	<span wicket:id="rating"></span>
> </html>
> In first one is request executed via ajax. In second one not. In first one rendered page contains reference to 'wicket-ajax.js' file but in the second not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1105) Missing javascript header referencies in Wicket portlet

Posted by "Michal Capo (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michal Capo updated WICKET-1105:
--------------------------------

    Attachment: wicket-portlets-test.zip

Test portlets for bug reproduction.

Steps:
1. unzip file
2. 'mvn eclipse:eclipse' (for eclipse of course)
3. run 'TestPortal' bean like java application (in src/test/java folder)
4. type in your browser 'http://localhost:8083/portlet1' for bad behavior
5. type in your browser 'http://localhost:8083/portlet2' for bad behavior


> Missing javascript header referencies in Wicket portlet
> -------------------------------------------------------
>
>                 Key: WICKET-1105
>                 URL: https://issues.apache.org/jira/browse/WICKET-1105
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-portlet
>         Environment: wicket trunk revision 588784
> JDK 1.5.0_13-b05
> Maven version: 2.0.7
>            Reporter: Michal Capo
>         Attachments: wicket-portlets-test.zip
>
>
> I have two wicket portlets using RatingPanel they are almost same. There is one difference in the markup.
> First:
> <head>
> 	<link rel="stylesheet" type="text/css" href="style.css"/>
> </head>
> <html>
> 	<span wicket:id="rating"></span>
> </html>
> Second:
> <html>
> 	<span wicket:id="rating"></span>
> </html>
> In first one is request executed via ajax. In second one not. In first one rendered page contains reference to 'wicket-ajax.js' file but in the second not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1105) Missing javascript header referencies when there are no body or head tags.

Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Johan Compagner updated WICKET-1105:
------------------------------------

      Component/s:     (was: wicket-portlet)
                   wicket
    Fix Version/s: 1.3.0-rc2
          Summary: Missing javascript header referencies when there are no body or head tags.  (was: Missing javascript header referencies in Wicket portlet)

> Missing javascript header referencies when there are no body or head tags.
> --------------------------------------------------------------------------
>
>                 Key: WICKET-1105
>                 URL: https://issues.apache.org/jira/browse/WICKET-1105
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>         Environment: wicket trunk revision 588784
> JDK 1.5.0_13-b05
> Maven version: 2.0.7
>            Reporter: Michal Capo
>            Assignee: Juergen Donnerstag
>             Fix For: 1.3.0-rc2
>
>         Attachments: wicket-portlets-test.zip
>
>
> I have two wicket portlets using RatingPanel they are almost same. There is one difference in the markup.
> First:
> <head>
> 	<link rel="stylesheet" type="text/css" href="style.css"/>
> </head>
> <html>
> 	<span wicket:id="rating"></span>
> </html>
> Second:
> <html>
> 	<span wicket:id="rating"></span>
> </html>
> In first one is request executed via ajax. In second one not. In first one rendered page contains reference to 'wicket-ajax.js' file but in the second not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1105) Missing javascript header referencies when there are no body or head tags.

Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Frank Bille Jensen updated WICKET-1105:
---------------------------------------

    Fix Version/s:     (was: 1.3.1)
                   1.3.2

> Missing javascript header referencies when there are no body or head tags.
> --------------------------------------------------------------------------
>
>                 Key: WICKET-1105
>                 URL: https://issues.apache.org/jira/browse/WICKET-1105
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>         Environment: wicket trunk revision 588784
> JDK 1.5.0_13-b05
> Maven version: 2.0.7
>            Reporter: Michal Capo
>            Assignee: Juergen Donnerstag
>             Fix For: 1.3.2
>
>         Attachments: wicket-portlets-test.zip
>
>
> I have two wicket portlets using RatingPanel they are almost same. There is one difference in the markup.
> First:
> <head>
> 	<link rel="stylesheet" type="text/css" href="style.css"/>
> </head>
> <html>
> 	<span wicket:id="rating"></span>
> </html>
> Second:
> <html>
> 	<span wicket:id="rating"></span>
> </html>
> In first one is request executed via ajax. In second one not. In first one rendered page contains reference to 'wicket-ajax.js' file but in the second not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.