You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by Apache Wiki <wi...@apache.org> on 2015/05/13 08:45:41 UTC

[Hadoop Wiki] Update of "HowToContribute" by AkiraAjisaka

Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Hadoop Wiki" for change notification.

The "HowToContribute" page has been changed by AkiraAjisaka:
https://wiki.apache.org/hadoop/HowToContribute?action=diff&rev1=106&rev2=107

Comment:
Reflected HADOOP-11746 (rewrite test-patch.sh).

  
  Patches for trunk should be named according to the Jira, with a version number: '''<jiraName>.<versionNum>.patch''', e.g. HADOOP-1234.001.patch, HDFS-4321.002.patch.
  
- Patches for a non-trunk branch should be named '''<jiraName>-<branchName>.<versionNum>.patch''', e.g. HDFS-1234-branch-0.23.003.patch.  The branch name suffix should be the exact name of a git branch, such as "branch-0.23". Please note that the Jenkins pre-commit build is only run against trunk.
+ Patches for a non-trunk branch should be named '''<jiraName>-<branchName>.<versionNum>.patch''', e.g. HDFS-1234-branch-2.003.patch. The branch name suffix should be the exact name of a git branch, such as "branch-2". Jenkins will check the name of the patch and detect the appropriate branch for testing.
+ 
+ Please note that the Jenkins pre-commit build is not run against minor branches (e.g. branch-2.7) or the branches starting with branch-0 (e.g. branch-0.23).
  
  It's also OK to upload a new patch to Jira with the same name as an existing patch. If you select the "Activity>All" tab then the different versions are linked in the comment stream, providing context. However, many reviewers find it helpful to include a version number in the patch name (three-digit version number is recommended), '''so including a version number is the preferred style'''.
  
@@ -164, +166 @@

  Run this command from a clean workspace (ie {{{git status}}} shows no modifications or additions) as follows:
  
  {{{
- dev-support/test-patch.sh /path/to/my.patch
+ dev-support/test-patch.sh [options] patch-file | defect-number
  }}}
  
- At the end, you should get a message on your console that is similar to the comment added to Jira by Jenkins's automated patch test system, listing +1 and -1 results.  For non-trunk patches (prior to HADOOP-7435 being implemented), please copy this results summary into the Jira as a comment.  Generally you should expect a +1 overall in order to have your patch committed; exceptions will be made for false positives that are unrelated to your patch.  The scratch directory (which defaults to the value of {{{${user.home}/tmp}}}) will contain some output files that will be useful in determining cause if issues were found in the patch.
+ At the end, you should get a message on your console that is similar to the comment added to Jira by Jenkins's automated patch test system, listing +1 and -1 results. Generally you should expect a +1 overall in order to have your patch committed; exceptions will be made for false positives that are unrelated to your patch.  The scratch directory (which defaults to the value of {{{${user.home}/tmp}}}) will contain some output files that will be useful in determining cause if issues were found in the patch.
  
  Some things to note: