You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/04/06 20:23:01 UTC

[GitHub] [cloudstack] ustcweizhou opened a new pull request #4019: server: Move restoreVM to vm work job queue

ustcweizhou opened a new pull request #4019: server: Move restoreVM to vm work job queue
URL: https://github.com/apache/cloudstack/pull/4019
 
 
   ## Description
   <!--- Describe your changes in detail -->
   
   When restore a Running vm twice, the vm cannot be started.
   
   Steps to reproduce the issue
   (1) deploy a vm
   (2) restore the vm twice by cloudmonkey
   cloudmonkey restore virtualmachine virtualmachineid=<vmid> & cloudmonkey restore virtualmachine virtualmachineid=<vmid>&
   
   The vm cannot be restarted again as there are two ROOT volumes.
   
   ![image](https://user-images.githubusercontent.com/3204966/78601410-07678700-7855-11ea-9026-f4f051d934b8.png)
   
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   Same steps succeed with this PR (the vm will be restored twice).
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] DaanHoogland commented on issue #4019: server: Move restoreVM to vm work job queue

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #4019: server: Move restoreVM to vm work job queue
URL: https://github.com/apache/cloudstack/pull/4019#issuecomment-610408436
 
 
   @blueorangutan package

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #4019: server: Move restoreVM to vm work job queue

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #4019: server: Move restoreVM to vm work job queue
URL: https://github.com/apache/cloudstack/pull/4019#issuecomment-610426269
 
 
   Packaging result: ✔centos7 ✔debian. JID-1144

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] weizhouapache commented on issue #4019: server: Move restoreVM to vm work job queue

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #4019: server: Move restoreVM to vm work job queue
URL: https://github.com/apache/cloudstack/pull/4019#issuecomment-610359046
 
 
   > @ustcweizhou stupid question. do we speak from a restore template to vm?
   
   @svenvogel yes, restore(in another word, reinstall) vm from original template (or other template).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] svenvogel commented on issue #4019: server: Move restoreVM to vm work job queue

Posted by GitBox <gi...@apache.org>.
svenvogel commented on issue #4019: server: Move restoreVM to vm work job queue
URL: https://github.com/apache/cloudstack/pull/4019#issuecomment-610339511
 
 
   @ustcweizhou stupid question. do we speak from a restore template to vm?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #4019: server: Move restoreVM to vm work job queue

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #4019: server: Move restoreVM to vm work job queue
URL: https://github.com/apache/cloudstack/pull/4019#issuecomment-610409152
 
 
   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services