[GitHub] [netbeans] vieiro commented on pull request #5317: harness/o.n.insane code cleanup

["vieiro (via GitHub)" <gi...@apache.org>]

vieiro commented on PR #5317:
URL: https://github.com/apache/netbeans/pull/5317#issuecomment-1407627517

   > This module's properties mentions "Export packages onlly to friends" and mentions 3 packages. Does it mean that it is only used by these three mentioned packages? If so does it make sense to test only API calls that are actually used by those packages and maybe later remove all the unused code (code not covered by new tests)?
   
   I'd add whatever tests are required so that we are sure that this problem that Matthias detected...
   
   > The compilation error is caused by using the wrong generics in ObjectSet, you reverted the introduced generic. Exactly these kind of problems are the reason to be very careful to quickly introduce generics, there is a high chance, that it will be not the right type.
   
   ... does not happen (nor any other problem). 
   
   The objective is to make sure NetBeans works the same (or better) as before the change: i.e., that no bugs are being introduced with the change. Maintainers can detect many bugs, but are humans also and can skip subtle ones.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists