You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2010/11/25 19:27:15 UTC

[jira] Resolved: (CASSANDRA-1778) Change classloader strategy to load version from non system classloader

     [ https://issues.apache.org/jira/browse/CASSANDRA-1778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis resolved CASSANDRA-1778.
---------------------------------------

    Resolution: Fixed
      Reviewer: jbellis
      Assignee: Bram de Kruijff

thanks, committed the simpler approach.  open to revisiting w/ configuration option if/when it is necessary.

> Change classloader strategy to load version from non system classloader
> -----------------------------------------------------------------------
>
>                 Key: CASSANDRA-1778
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1778
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.7 beta 3
>            Reporter: Bram de Kruijff
>            Assignee: Bram de Kruijff
>
> At present when initializing the StorageService, FBUtilities.getReleaseVersionString()  tries to load the version.info resource from the ClassLoader.getSystemClassLoader(). This typically fails in an embedded scenario (such as an OSGi container) resulting in a dummy version at INFO and a stacktrace at WARN
>             logger_.warn("Unable to load version.properties", e);
>             return "debug version";
> My guess is that changing the implementation to using the FBUtilities.class.getClassLoader() for loading resources would solve it and will work in almost any case I can think off. However, as discussed on the Apache Felix mailing list, the only "right"way to do it is to allow an optional ClassLoader to be specified (@see http://www.mail-archive.com/users@felix.apache.org/msg09060.html).
> This issue was initially reported at the Amdatu jira:
> http://jira.amdatu.org/jira/browse/AMDATU-127

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.