You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Miklos Gergely <mg...@hortonworks.com> on 2020/02/21 08:00:07 UTC
Review Request 72154: Break up DDLSemanticAnalyzer - extract the rest
of the Alter Table analyzers
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72154/
-----------------------------------------------------------
Review request for hive and Zoltan Haindrich.
Bugs: HIVE-22907
https://issues.apache.org/jira/browse/HIVE-22907
Repository: hive-git
Description
-------
DDLSemanticAnalyzer is a huge class, more than 4000 lines long. The goal is to refactor it in order to have everything cut into more handleable classes under the package org.apache.hadoop.hive.ql.exec.ddl:
have a separate class for each analyzers
have a package for each operation, containing an analyzer, a description, and an operation, so the amount of classes under a package is more manageable
Step #15: extract the rest of the alter table analyzers from DDLSemanticAnalyzer, and move them under the new package. Remove DDLSemanticAnalyzer.
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/AbstractAlterTableAnalyzer.java 0acd5011cc
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/AbstractAlterTableOperation.java 323cdc42d3
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/AbstractBaseAlterTableAnalyzer.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/drop/DropTableOperation.java f4d1a35d72
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/misc/AlterTableRenameDesc.java 091c146940
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/misc/AlterTableRenameOperation.java 73ea400dcc
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/misc/AlterTableSetOwnerDesc.java 1fb11ce7c3
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/misc/AlterTableSetOwnerOperation.java 02b9b91dfc
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/misc/AlterTableSetPropertiesDesc.java 2d615a64cc
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/misc/AlterTableSetPropertiesOperation.java ff6b08b5d5
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/misc/AlterTableTouchDesc.java 207f5b443f
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/misc/AlterTableTouchOperation.java 8d8ac20350
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/misc/AlterTableUnsetPropertiesDesc.java bea9a365e9
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/misc/AlterTableUnsetPropertiesOperation.java 31a27fc8d2
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/misc/PreInsertTableDesc.java bc378809ad
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/misc/PreInsertTableOperation.java 928ace9ed1
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/misc/TruncateTableDesc.java 04fa1b9901
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/misc/TruncateTableOperation.java 3c62b0a1fa
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/misc/columnstats/AlterTableUpdateColumnStatistictAnalyzer.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/misc/owner/AlterTableSetOwnerAnalyzer.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/misc/properties/AbstractAlterTablePropertiesAnalyzer.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/misc/properties/AbstractAlterTableSetPropertiesAnalyzer.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/misc/properties/AbstractAlterTableUnsetPropertiesAnalyzer.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/misc/properties/AlterTableSetPropertiesAnalyzer.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/misc/properties/AlterTableUnsetPropertiesAnalyzer.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/misc/rename/AbstractAlterTableRenameAnalyzer.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/misc/rename/AlterTableRenameAnalyzer.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/misc/touch/AlterTableTouchAnalyzer.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/misc/truncate/TruncateTableAnalyzer.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/drop/AlterTableDropPartitionOperation.java 9d186db7af
ql/src/java/org/apache/hadoop/hive/ql/ddl/view/drop/DropViewOperation.java a029b6cca4
ql/src/java/org/apache/hadoop/hive/ql/ddl/view/materialized/drop/DropMaterializedViewOperation.java 93b25d4be3
ql/src/java/org/apache/hadoop/hive/ql/ddl/view/properties/AlterViewSetPropertiesAnalyzer.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/view/properties/AlterViewUnsetPropertiesAnalyzer.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/ddl/view/rename/AlterViewRenameAnalyzer.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/incremental/IncrementalLoadTasksBuilder.java d7b6eeae55
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/util/ReplUtils.java fc7f226d77
ql/src/java/org/apache/hadoop/hive/ql/parse/AcidExportSemanticAnalyzer.java cc3c5da8ce
ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 46bb37a0c2
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java ba019c7553
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java f46739eb67
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java 9748fbddc2
ql/src/java/org/apache/hadoop/hive/ql/parse/authorization/HiveAuthorizationTaskFactoryImpl.java d54325d810
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/message/RenameTableHandler.java 82e50ff442
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/message/TruncatePartitionHandler.java 25e524af37
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/message/TruncateTableHandler.java 35b8e0e684
ql/src/test/org/apache/hadoop/hive/ql/parse/authorization/AuthorizationTestUtil.java 72a6c66aed
ql/src/test/results/clientnegative/alter_tableprops_external_with_default_constraint.q.out de5e2763b4
ql/src/test/results/clientnegative/alter_tableprops_external_with_notnull_constraint.q.out 6cfc93261f
Diff: https://reviews.apache.org/r/72154/diff/1/
Testing
-------
All tests are still passing.
Thanks,
Miklos Gergely