You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/31 14:12:11 UTC
[GitHub] [flink] dawidwys commented on a change in pull request #18539: [FLINK-25745] Support RocksDB incremental native savepoints
dawidwys commented on a change in pull request #18539:
URL: https://github.com/apache/flink/pull/18539#discussion_r795706462
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CompletedCheckpoint.java
##########
@@ -203,10 +204,37 @@ public long getStateSize() {
*
* @param sharedStateRegistry The registry where shared states are registered
*/
- public void registerSharedStatesAfterRestored(SharedStateRegistry sharedStateRegistry) {
- // in claim mode we should not register any shared handles
+ public void registerSharedStatesAfterRestored(
+ SharedStateRegistry sharedStateRegistry, boolean claim) {
+ // in no_claim mode we should not register any shared handles
if (!props.isUnclaimed()) {
- sharedStateRegistry.registerAll(operatorStates.values(), checkpointID);
+ if (claim) {
Review comment:
`Unclaimed` = `NO_CLAIM` + `LEGACY`
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CompletedCheckpoint.java
##########
@@ -203,10 +204,37 @@ public long getStateSize() {
*
* @param sharedStateRegistry The registry where shared states are registered
*/
- public void registerSharedStatesAfterRestored(SharedStateRegistry sharedStateRegistry) {
- // in claim mode we should not register any shared handles
+ public void registerSharedStatesAfterRestored(
+ SharedStateRegistry sharedStateRegistry, boolean claim) {
+ // in no_claim mode we should not register any shared handles
if (!props.isUnclaimed()) {
- sharedStateRegistry.registerAll(operatorStates.values(), checkpointID);
+ if (claim) {
Review comment:
`Unclaimed` = `CLAIM` + `LEGACY`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org