You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by talentdeficit <gi...@git.apache.org> on 2014/08/07 15:39:43 UTC
[GitHub] thrift pull request: THRIFT-2651: struct names that are restricted...
GitHub user talentdeficit opened a pull request:
https://github.com/apache/thrift/pull/176
THRIFT-2651: struct names that are restricted erlang terms generate inva...
...lid type signatures
patch: alisdairsullivan@yahoo.ca
client: erlang
fixes error exposed in THRIFT-2647 by avoiding using restricted identifiers in erlang type signatures generated by the compiler
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/talentdeficit/thrift thrift-2651
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/176.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #176
----
commit 156e344023b22331d680ff4d4f3ac3a295a1dc13
Author: alisdair sullivan <al...@yahoo.ca>
Date: 2014-08-07T13:32:37Z
THRIFT-2651: struct names that are restricted erlang terms generate invalid type signatures
patch: alisdairsullivan@yahoo.ca
client: erlang
fixes error exposed in THRIFT-2647 by avoiding using restricted identifiers in erlang type signatures generated by the compiler
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-2651: struct names that are restricted...
Posted by bufferoverflow <gi...@git.apache.org>.
Github user bufferoverflow commented on the pull request:
https://github.com/apache/thrift/pull/176#issuecomment-52540202
please close this, already committed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-2651: struct names that are restricted...
Posted by talentdeficit <gi...@git.apache.org>.
Github user talentdeficit closed the pull request at:
https://github.com/apache/thrift/pull/176
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---