You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "OneSizeFitsQuorum (via GitHub)" <gi...@apache.org> on 2023/05/23 10:00:52 UTC

[GitHub] [iotdb] OneSizeFitsQuorum commented on a diff in pull request #9901: [IOTDB-5796][IOTDB-5701] Remove recorder and optimize the usage of metrics

OneSizeFitsQuorum commented on code in PR #9901:
URL: https://github.com/apache/iotdb/pull/9901#discussion_r1201957627


##########
consensus/src/main/java/org/apache/iotdb/consensus/iot/IoTConsensusServerImpl.java:
##########
@@ -136,32 +132,32 @@ public IoTConsensusServerImpl(
       persistConfiguration();
     }
     this.config = config;
-    this.logDispatcher = new LogDispatcher(this, clientManager);
+    this.consensusGroupId = thisNode.getGroupId().toString();
     reader = (ConsensusReqReader) stateMachine.read(new GetConsensusReqReaderPlan());

Review Comment:
   We need to initialize the reader before we initialize the logdispatcher



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org