[GitHub] [samza] prateekm commented on a change in pull request #1158: SAMZA-2324: Adding KV store metrics for rocksdb

[GitBox <gi...@apache.org>]

prateekm commented on a change in pull request #1158: SAMZA-2324: Adding KV store metrics for rocksdb
URL: https://github.com/apache/samza/pull/1158#discussion_r328327602
 
 

 ##########
 File path: samza-kv/src/main/scala/org/apache/samza/storage/kv/SerializedKeyValueStore.scala
 ##########
 @@ -55,23 +55,27 @@ class SerializedKeyValueStore[K, V](
   }
 
   def put(key: K, value: V) {
-    metrics.puts.inc
     val keyBytes = toBytesOrNull(key, keySerde)
     val valBytes = toBytesOrNull(value, msgSerde)
     store.put(keyBytes, valBytes)
+    metrics.puts.inc
+    metrics.maxRecordSizeBytes.set(Math.max(metrics.maxRecordSizeBytes.getValue, valBytes.length))
 
 Review comment:
   Max would be sufficient for now. Percentiles are more useful but also more expensive, we can add them if we get a request for them. The original request was for a metric to set alerts on if record sizes are increasing over time (e.g. for list values) and getting closer to the max logged store size limit. Re: single outlier, that's still relevant since a single large message will cause the produce to fail.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services