You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/09/13 12:24:28 UTC
[GitHub] [dubbo-getty] sdttttt opened a new pull request #47: [WIP] Ftr: Migrate travis Ci to GithubActions
sdttttt opened a new pull request #47:
URL: https://github.com/apache/dubbo-getty/pull/47
**What this PR does**:
GithubActions is faster than TravisCI.
**Special notes for your reviewer**:
Please note whether the CI behavior has been changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dubbo-getty] watermelo commented on a change in pull request #47: Ftr: Migrate travis Ci to GithubActions
Posted by GitBox <gi...@apache.org>.
watermelo commented on a change in pull request #47:
URL: https://github.com/apache/dubbo-getty/pull/47#discussion_r487533333
##########
File path: .github/workflows/github-actions.yml
##########
@@ -0,0 +1,104 @@
+name: CI
+
+on:
+ push:
+ branches: [ master ]
+ pull_request:
+ branches: "*"
+
+jobs:
+
+ build:
+ name: Build
+ runs-on: ${{ matrix.os }}
+ strategy:
+ matrix:
+ go_version:
+ - 1.13
+ os:
+ - ubuntu-latest
+
+ env:
+ DING_TOKEN: db178ff8c63cdc1b9ae0b86f7c4006ddf35e0249f4ae03441d80e55fdc600419
Review comment:
Should not be exposed here, Is there any other way to set it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dubbo-getty] codecov-commenter commented on pull request #47: Ftr: Migrate travis Ci to GithubActions
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #47:
URL: https://github.com/apache/dubbo-getty/pull/47#issuecomment-691671528
# [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/47?src=pr&el=h1) Report
> Merging [#47](https://codecov.io/gh/apache/dubbo-getty/pull/47?src=pr&el=desc) into [master](https://codecov.io/gh/apache/dubbo-getty/commit/fc4127d58c486844d448b51262caab3b9ac0663d?el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-getty/pull/47?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #47 +/- ##
=======================================
Coverage 68.75% 68.75%
=======================================
Files 8 8
Lines 1520 1520
=======================================
Hits 1045 1045
Misses 382 382
Partials 93 93
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/47?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/47?src=pr&el=footer). Last update [fc4127d...9ebdfd3](https://codecov.io/gh/apache/dubbo-getty/pull/47?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dubbo-getty] DogBaoBao commented on pull request #47: Ftr: Migrate travis Ci to GithubActions
Posted by GitBox <gi...@apache.org>.
DogBaoBao commented on pull request #47:
URL: https://github.com/apache/dubbo-getty/pull/47#issuecomment-691673521
The token is expose looks dangerous。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dubbo-getty] sdttttt edited a comment on pull request #47: Ftr: Migrate travis Ci to GithubActions
Posted by GitBox <gi...@apache.org>.
sdttttt edited a comment on pull request #47:
URL: https://github.com/apache/dubbo-getty/pull/47#issuecomment-691674162
> The token is expose looks dangerous。
If want to hide it, need to set up the **secret** of the repository. ref it through context in the workflow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dubbo-getty] sdttttt edited a comment on pull request #47: Ftr: Migrate travis Ci to GithubActions
Posted by GitBox <gi...@apache.org>.
sdttttt edited a comment on pull request #47:
URL: https://github.com/apache/dubbo-getty/pull/47#issuecomment-691674162
> The token is expose looks dangerous。
If want to hide it, need to set up the **secret** of the warehouse. ref it through context in the workflow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dubbo-getty] sdttttt edited a comment on pull request #47: Ftr: Migrate travis Ci to GithubActions
Posted by GitBox <gi...@apache.org>.
sdttttt edited a comment on pull request #47:
URL: https://github.com/apache/dubbo-getty/pull/47#issuecomment-691674162
> The token is expose looks dangerous。
If want to hide it, need to set up the secret of the warehouse. ref it through context in the workflow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dubbo-getty] sdttttt commented on pull request #47: Ftr: Migrate travis Ci to GithubActions
Posted by GitBox <gi...@apache.org>.
sdttttt commented on pull request #47:
URL: https://github.com/apache/dubbo-getty/pull/47#issuecomment-691674162
> The token is expose looks dangerous。
If you want to hide it, you need to set up the secret of the warehouse. ref it through context in the workflow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dubbo-getty] sdttttt commented on a change in pull request #47: Ftr: Migrate travis Ci to GithubActions
Posted by GitBox <gi...@apache.org>.
sdttttt commented on a change in pull request #47:
URL: https://github.com/apache/dubbo-getty/pull/47#discussion_r487534493
##########
File path: .github/workflows/github-actions.yml
##########
@@ -0,0 +1,104 @@
+name: CI
+
+on:
+ push:
+ branches: [ master ]
+ pull_request:
+ branches: "*"
+
+jobs:
+
+ build:
+ name: Build
+ runs-on: ${{ matrix.os }}
+ strategy:
+ matrix:
+ go_version:
+ - 1.13
+ os:
+ - ubuntu-latest
+
+ env:
+ DING_TOKEN: db178ff8c63cdc1b9ae0b86f7c4006ddf35e0249f4ae03441d80e55fdc600419
Review comment:
Someone with super access is needed to set up the repository's **secrets**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org