You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@climate.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/10/22 00:37:58 UTC
[jira] [Commented] (CLIMATE-883) Ensure python 3 builds pass unit
tests
[ https://issues.apache.org/jira/browse/CLIMATE-883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15596797#comment-15596797 ]
ASF GitHub Bot commented on CLIMATE-883:
----------------------------------------
GitHub user agoodm opened a pull request:
https://github.com/apache/climate/pull/416
CLIMATE-883 - Ensure python 3 builds pass unit tests
This PR should solve most of the Python 3 compatibility issues we have been having. The biggest ones remaining are some of our examples as well as `run_RCMES.py`. I included a minor hotfix to an issue with that file as well for the sake of ensuring these changes don't break our workflow in Python 2.7.
In addition to unit tests, I also ran the podaac example and other than some deprecation warnings, everything seems good.
@lewismc @huikyole please review / comment. I have tested one config file for CORDEX Africa and it worked, but feel free to perform any other tests as you see fit.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/agoodm/climate CLIMATE-883
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/climate/pull/416.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #416
----
commit 528fe168c007ca3509f23f0bec9157fc0b2801be
Author: Alex Goodman <ag...@users.noreply.github.com>
Date: 2016-10-21T23:47:49Z
CLIMATE-883 - Ensure python 3 builds pass unit tests
commit 4331ed08874b5a64cb1d82276db1e707619e600f
Author: Alex Goodman <ag...@users.noreply.github.com>
Date: 2016-10-22T00:30:08Z
Fix minor error in run_RCMES.py
----
> Ensure python 3 builds pass unit tests
> --------------------------------------
>
> Key: CLIMATE-883
> URL: https://issues.apache.org/jira/browse/CLIMATE-883
> Project: Apache Open Climate Workbench
> Issue Type: Bug
> Components: build process, tests
> Affects Versions: 1.1.0
> Reporter: Alex Goodman
> Assignee: Alex Goodman
> Priority: Critical
> Fix For: 1.2.0
>
>
> To make sure our code is python 3 compatible to the best of our ability, we need to at least make sure all of our unit tests can pass for python 3 builds.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)