You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/10/28 17:17:43 UTC
[GitHub] [camel-quarkus] aldettinger opened a new pull request #1965: Added the joni optional dependency in order fix the native build #1961
aldettinger opened a new pull request #1965:
URL: https://github.com/apache/camel-quarkus/pull/1965
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger edited a comment on pull request #1965: Added the joni optional dependency in order fix the native build #1961
Posted by GitBox <gi...@apache.org>.
aldettinger edited a comment on pull request #1965:
URL: https://github.com/apache/camel-quarkus/pull/1965#issuecomment-718086322
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #1965: Added the joni optional dependency in order fix the native build #1961
Posted by GitBox <gi...@apache.org>.
aldettinger commented on pull request #1965:
URL: https://github.com/apache/camel-quarkus/pull/1965#issuecomment-718086322
Proposal fix for issue https://github.com/apache/camel-quarkus/issues/1961.
The ECMA 262 feature is not exposed from camel-json-validator. However, I've found clean maintenance way to cut the problematic code path with native substitution.
So, I propose to take the option dependency.
@jamesnetherton What do you think ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger merged pull request #1965: Added the joni optional dependency in order fix the native build #1961
Posted by GitBox <gi...@apache.org>.
aldettinger merged pull request #1965:
URL: https://github.com/apache/camel-quarkus/pull/1965
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on pull request #1965: Added the joni optional dependency in order fix the native build #1961
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on pull request #1965:
URL: https://github.com/apache/camel-quarkus/pull/1965#issuecomment-718152280
> So, I propose to take the optional dependency to please native image static points to analysis.
I think that's fine for now. We can revisit in furture if we need to.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger edited a comment on pull request #1965: Added the joni optional dependency in order fix the native build #1961
Posted by GitBox <gi...@apache.org>.
aldettinger edited a comment on pull request #1965:
URL: https://github.com/apache/camel-quarkus/pull/1965#issuecomment-718086322
Proposal fix for issue https://github.com/apache/camel-quarkus/issues/1961.
The ECMA 262 feature is not exposed from camel-json-validator. However, I've not found a maintenable way to cut the problematic code path with a native substitution.
So, I propose to take the optional dependency to please native image static points to analysis.
@jamesnetherton What do you think ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org