You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/01/19 12:47:25 UTC
[GitHub] [hive] kasakrisz opened a new pull request #2953: HIVE-25878: Unable to compile cpp metastore thrift client
kasakrisz opened a new pull request #2953:
URL: https://github.com/apache/hive/pull/2953
### What changes were proposed in this pull request?
Thrift generates cpp client with structs/classes having non-pointer fields. This blocks forward declaration.
However `SourceTable` is referenced from `CreationMetadata` as a collection element type which makes thrift to generate a pointer type for `SourceTable`. To resolve the circular dependency issue move `SourceTable` definition after `Table` definition in hive_metastore.thrift.
Also change the collection type `set<SourceTable>` to list<SourceTable> because set requires additional changes on the element type.
### Why are the changes needed?
Fix compilation errors in cpp thrift metastore client.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Compile the cpp client.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kasakrisz merged pull request #2953: HIVE-25878: Unable to compile cpp metastore thrift client
Posted by GitBox <gi...@apache.org>.
kasakrisz merged pull request #2953:
URL: https://github.com/apache/hive/pull/2953
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org