You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "Jackie-Jiang (via GitHub)" <gi...@apache.org> on 2023/02/27 18:30:06 UTC
[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10343: Add min / max values to virtual column metadata to allow segment pruning
Jackie-Jiang commented on code in PR #10343:
URL: https://github.com/apache/pinot/pull/10343#discussion_r1119134224
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/column/DefaultNullValueVirtualColumnProvider.java:
##########
@@ -88,6 +88,11 @@ public ColumnMetadataImpl buildMetadata(VirtualColumnContext context) {
ColumnMetadataImpl.Builder builder = getColumnMetadataBuilder(context).setCardinality(1).setHasDictionary(true);
if (context.getFieldSpec().isSingleValueField()) {
builder.setSorted(true);
+
+ if (context.getFieldSpec().getDefaultNullValue() instanceof Comparable) {
Review Comment:
(minor) Put `context.getFieldSpec().getDefaultNullValue()` into a local variable to be reused
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/column/DefaultNullValueVirtualColumnProvider.java:
##########
@@ -88,6 +88,11 @@ public ColumnMetadataImpl buildMetadata(VirtualColumnContext context) {
ColumnMetadataImpl.Builder builder = getColumnMetadataBuilder(context).setCardinality(1).setHasDictionary(true);
if (context.getFieldSpec().isSingleValueField()) {
builder.setSorted(true);
+
+ if (context.getFieldSpec().getDefaultNullValue() instanceof Comparable) {
+ builder.setMinValue((Comparable) context.getFieldSpec().getDefaultNullValue());
+ builder.setMaxValue((Comparable) context.getFieldSpec().getDefaultNullValue());
+ }
} else {
// When there is no value for a multi-value column, the maxNumberOfMultiValues and cardinality should be
Review Comment:
We want to set the same min & max value for the MV column
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/column/DefaultNullValueVirtualColumnProvider.java:
##########
@@ -88,6 +88,11 @@ public ColumnMetadataImpl buildMetadata(VirtualColumnContext context) {
ColumnMetadataImpl.Builder builder = getColumnMetadataBuilder(context).setCardinality(1).setHasDictionary(true);
if (context.getFieldSpec().isSingleValueField()) {
builder.setSorted(true);
+
+ if (context.getFieldSpec().getDefaultNullValue() instanceof Comparable) {
Review Comment:
For BYTES column, we want to wrap the value into a `ByteArray` object and set it as the min & max value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org