You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zhangbutao (via GitHub)" <gi...@apache.org> on 2024/04/29 09:39:03 UTC
[PR] [Opt](Iceberg) Simplify the code of getting time travel snapshotId [doris]
zhangbutao opened a new pull request, #34299:
URL: https://github.com/apache/doris/pull/34299
## Proposed changes
Optimize the code of getting snapshotId.
We can use the Apache Iceberg funtion to get time travel snapshotId.
Issue Number: close #xxx
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Opt](Iceberg) Simplify the code of getting time travel snapshotId [doris]
Posted by "zhangbutao (via GitHub)" <gi...@apache.org>.
zhangbutao commented on PR #34299:
URL: https://github.com/apache/doris/pull/34299#issuecomment-2115695209
@morningman Thanks for review! Can we merge this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Opt](Iceberg) Simplify the code of getting time travel snapshotId [doris]
Posted by "wuwenchi (via GitHub)" <gi...@apache.org>.
wuwenchi commented on PR #34299:
URL: https://github.com/apache/doris/pull/34299#issuecomment-2111453581
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Opt](Iceberg) Simplify the code of getting time travel snapshotId [doris]
Posted by "zhangbutao (via GitHub)" <gi...@apache.org>.
zhangbutao commented on PR #34299:
URL: https://github.com/apache/doris/pull/34299#issuecomment-2084260528
@morningman Could you please take a look? Thx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Opt](Iceberg) Simplify the code of getting time travel snapshotId [doris]
Posted by "zhangbutao (via GitHub)" <gi...@apache.org>.
zhangbutao commented on PR #34299:
URL: https://github.com/apache/doris/pull/34299#issuecomment-2083012877
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Opt](Iceberg) Simplify the code of getting time travel snapshotId [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34299:
URL: https://github.com/apache/doris/pull/34299#issuecomment-2110501230
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Opt](Iceberg) Simplify the code of getting time travel snapshotId [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #34299:
URL: https://github.com/apache/doris/pull/34299#issuecomment-2082286044
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Opt](Iceberg) Simplify the code of getting time travel snapshotId [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #34299:
URL: https://github.com/apache/doris/pull/34299#issuecomment-2083113788
<details>
<summary>TPC-DS: <b>Total hot run time: 186215 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 522b320425f3ee577890636d7c2bc0c545f1af8b, data reload: false
query1 909 353 368 353
query2 6303 2288 2189 2189
query3 6661 214 205 205
query4 23096 21787 21926 21787
query5 3811 422 434 422
query6 278 197 160 160
query7 4556 285 296 285
query8 235 168 189 168
query9 8450 2314 2333 2314
query10 416 241 260 241
query11 15158 14868 14821 14821
query12 118 89 82 82
query13 1625 371 364 364
query14 10367 6554 7411 6554
query15 243 166 161 161
query16 8101 244 246 244
query17 1733 536 543 536
query18 2051 262 259 259
query19 198 148 141 141
query20 86 80 82 80
query21 184 146 124 124
query22 4990 4820 4795 4795
query23 33747 33066 33150 33066
query24 10582 2904 2861 2861
query25 587 373 361 361
query26 1120 147 142 142
query27 2813 308 304 304
query28 7552 1963 1943 1943
query29 842 584 581 581
query30 232 147 151 147
query31 961 708 704 704
query32 86 49 50 49
query33 733 234 243 234
query34 1064 462 456 456
query35 813 664 643 643
query36 1073 939 910 910
query37 123 63 63 63
query38 3109 3018 3051 3018
query39 1575 1616 1532 1532
query40 207 119 121 119
query41 40 37 37 37
query42 101 90 99 90
query43 565 521 537 521
query44 1201 719 724 719
query45 279 266 259 259
query46 1070 707 695 695
query47 1933 1840 1844 1840
query48 373 293 296 293
query49 882 384 393 384
query50 783 373 375 373
query51 6868 6699 6674 6674
query52 104 88 99 88
query53 346 277 281 277
query54 301 240 237 237
query55 76 71 72 71
query56 242 230 222 222
query57 1190 1134 1127 1127
query58 223 208 204 204
query59 3266 3099 3085 3085
query60 255 231 234 231
query61 108 105 107 105
query62 644 451 431 431
query63 300 273 272 272
query64 8590 7264 7208 7208
query65 3128 3062 3037 3037
query66 1370 335 422 335
query67 15750 14929 15009 14929
query68 9477 545 548 545
query69 596 305 295 295
query70 1322 1031 1117 1031
query71 504 255 277 255
query72 8329 2557 2408 2408
query73 1539 317 309 309
query74 6434 6068 6026 6026
query75 4586 2631 2666 2631
query76 5722 946 937 937
query77 662 258 256 256
query78 11112 10157 10360 10157
query79 10430 507 506 506
query80 1413 419 417 417
query81 503 221 216 216
query82 239 84 93 84
query83 224 163 163 163
query84 260 82 82 82
query85 1150 264 297 264
query86 440 316 319 316
query87 3304 3075 3073 3073
query88 5107 2384 2384 2384
query89 499 361 366 361
query90 2054 178 176 176
query91 119 94 96 94
query92 58 47 46 46
query93 6744 492 489 489
query94 1286 177 175 175
query95 1090 1097 1086 1086
query96 604 263 261 261
query97 3113 2922 2970 2922
query98 233 217 221 217
query99 1213 898 871 871
Total cold run time: 307142 ms
Total hot run time: 186215 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Opt](Iceberg) Simplify the code of getting time travel snapshotId [doris]
Posted by "zhangbutao (via GitHub)" <gi...@apache.org>.
zhangbutao commented on PR #34299:
URL: https://github.com/apache/doris/pull/34299#issuecomment-2097355615
Gentle ping :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Opt](Iceberg) Simplify the code of getting time travel snapshotId [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34299:
URL: https://github.com/apache/doris/pull/34299#issuecomment-2110501300
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org