You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/08/04 06:41:42 UTC
[GitHub] [flink] tsreaper opened a new pull request #16699: [FLINK-23420][table-runtime] LinkedListSerializer now checks for null elements in the list
tsreaper opened a new pull request #16699:
URL: https://github.com/apache/flink/pull/16699
## What is the purpose of the change
`LinkedListSerializer` in the table runtime module currently is not aware of the null elements in the list. This will cause NPE in some functions like the `LAG` aggregation function.
This PR fixes this issue and at the mean time keep the compatibility of the states.
## Brief change log
- LinkedListSerializer now checks for null elements in the list
## Verifying this change
This change added tests and can be verified by running the added tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: **YES**
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi commented on pull request #16699: [FLINK-23420][table-runtime] LinkedListSerializer now checks for null elements in the list
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on pull request #16699:
URL: https://github.com/apache/flink/pull/16699#issuecomment-900092972
@tsreaper Can you create JIRA for 1.13?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16699: [FLINK-23420][table-runtime] LinkedListSerializer now checks for null elements in the list
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16699:
URL: https://github.com/apache/flink/pull/16699#issuecomment-892415455
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3fef5459a0a1ac345b72c749f025b8e0136709e0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21467",
"triggerID" : "3fef5459a0a1ac345b72c749f025b8e0136709e0",
"triggerType" : "PUSH"
}, {
"hash" : "2628e78aff84d298c55e52428ab232be78b521a9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21491",
"triggerID" : "2628e78aff84d298c55e52428ab232be78b521a9",
"triggerType" : "PUSH"
}, {
"hash" : "2628e78aff84d298c55e52428ab232be78b521a9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21562",
"triggerID" : "893064811",
"triggerType" : "MANUAL"
}, {
"hash" : "2628e78aff84d298c55e52428ab232be78b521a9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21491",
"triggerID" : "893064811",
"triggerType" : "MANUAL"
}, {
"hash" : "fb666804b2cf16e3aefac6dc51026384749f589f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21610",
"triggerID" : "fb666804b2cf16e3aefac6dc51026384749f589f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fb666804b2cf16e3aefac6dc51026384749f589f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21610)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16699: [FLINK-23420][table-runtime] LinkedListSerializer now checks for null elements in the list
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16699:
URL: https://github.com/apache/flink/pull/16699#issuecomment-892415455
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3fef5459a0a1ac345b72c749f025b8e0136709e0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3fef5459a0a1ac345b72c749f025b8e0136709e0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3fef5459a0a1ac345b72c749f025b8e0136709e0 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi merged pull request #16699: [FLINK-23420][table-runtime] LinkedListSerializer now checks for null elements in the list
Posted by GitBox <gi...@apache.org>.
JingsongLi merged pull request #16699:
URL: https://github.com/apache/flink/pull/16699
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi commented on a change in pull request #16699: [FLINK-23420][table-runtime] LinkedListSerializer now checks for null elements in the list
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #16699:
URL: https://github.com/apache/flink/pull/16699#discussion_r683263937
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/typeutils/LinkedListSerializer.java
##########
@@ -186,12 +267,28 @@ public int getCurrentOuterSnapshotVersion() {
return CURRENT_VERSION;
}
+ @Override
+ protected void readOuterSnapshot(
+ int readOuterSnapshotVersion, DataInputView in, ClassLoader userCodeClassLoader) {
+ readVersion = readOuterSnapshotVersion;
+ }
+
+ @Override
+ protected OuterSchemaCompatibility resolveOuterSchemaCompatibility(
+ LinkedListSerializer<T> newSerializer) {
+ if (readVersion <= LAST_NULL_NOT_CHECKED_VERSION) {
+ return OuterSchemaCompatibility.COMPATIBLE_AFTER_MIGRATION;
Review comment:
Or you can use `MaskUtils` and ignore `checkIfNullSupported`. This way will not waste much space.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16699: [FLINK-23420][table-runtime] LinkedListSerializer now checks for null elements in the list
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16699:
URL: https://github.com/apache/flink/pull/16699#issuecomment-892415455
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3fef5459a0a1ac345b72c749f025b8e0136709e0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21467",
"triggerID" : "3fef5459a0a1ac345b72c749f025b8e0136709e0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3fef5459a0a1ac345b72c749f025b8e0136709e0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21467)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16699: [FLINK-23420][table-runtime] LinkedListSerializer now checks for null elements in the list
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16699:
URL: https://github.com/apache/flink/pull/16699#issuecomment-892415455
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3fef5459a0a1ac345b72c749f025b8e0136709e0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21467",
"triggerID" : "3fef5459a0a1ac345b72c749f025b8e0136709e0",
"triggerType" : "PUSH"
}, {
"hash" : "2628e78aff84d298c55e52428ab232be78b521a9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21491",
"triggerID" : "2628e78aff84d298c55e52428ab232be78b521a9",
"triggerType" : "PUSH"
}, {
"hash" : "2628e78aff84d298c55e52428ab232be78b521a9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21562",
"triggerID" : "893064811",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 2628e78aff84d298c55e52428ab232be78b521a9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21491) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21562)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16699: [FLINK-23420][table-runtime] LinkedListSerializer now checks for null elements in the list
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16699:
URL: https://github.com/apache/flink/pull/16699#issuecomment-892415455
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3fef5459a0a1ac345b72c749f025b8e0136709e0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21467",
"triggerID" : "3fef5459a0a1ac345b72c749f025b8e0136709e0",
"triggerType" : "PUSH"
}, {
"hash" : "2628e78aff84d298c55e52428ab232be78b521a9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21491",
"triggerID" : "2628e78aff84d298c55e52428ab232be78b521a9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2628e78aff84d298c55e52428ab232be78b521a9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21491)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16699: [FLINK-23420][table-runtime] LinkedListSerializer now checks for null elements in the list
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16699:
URL: https://github.com/apache/flink/pull/16699#issuecomment-892415455
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3fef5459a0a1ac345b72c749f025b8e0136709e0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21467",
"triggerID" : "3fef5459a0a1ac345b72c749f025b8e0136709e0",
"triggerType" : "PUSH"
}, {
"hash" : "2628e78aff84d298c55e52428ab232be78b521a9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21491",
"triggerID" : "2628e78aff84d298c55e52428ab232be78b521a9",
"triggerType" : "PUSH"
}, {
"hash" : "2628e78aff84d298c55e52428ab232be78b521a9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21562",
"triggerID" : "893064811",
"triggerType" : "MANUAL"
}, {
"hash" : "2628e78aff84d298c55e52428ab232be78b521a9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21491",
"triggerID" : "893064811",
"triggerType" : "MANUAL"
}, {
"hash" : "fb666804b2cf16e3aefac6dc51026384749f589f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21610",
"triggerID" : "fb666804b2cf16e3aefac6dc51026384749f589f",
"triggerType" : "PUSH"
}, {
"hash" : "7343f8b1adde98e86eba0f3bcbc647df92f82223",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21751",
"triggerID" : "7343f8b1adde98e86eba0f3bcbc647df92f82223",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fb666804b2cf16e3aefac6dc51026384749f589f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21610)
* 7343f8b1adde98e86eba0f3bcbc647df92f82223 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21751)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16699: [FLINK-23420][table-runtime] LinkedListSerializer now checks for null elements in the list
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16699:
URL: https://github.com/apache/flink/pull/16699#issuecomment-892415455
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3fef5459a0a1ac345b72c749f025b8e0136709e0",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21467",
"triggerID" : "3fef5459a0a1ac345b72c749f025b8e0136709e0",
"triggerType" : "PUSH"
}, {
"hash" : "2628e78aff84d298c55e52428ab232be78b521a9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21491",
"triggerID" : "2628e78aff84d298c55e52428ab232be78b521a9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3fef5459a0a1ac345b72c749f025b8e0136709e0 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21467)
* 2628e78aff84d298c55e52428ab232be78b521a9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21491)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16699: [FLINK-23420][table-runtime] LinkedListSerializer now checks for null elements in the list
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16699:
URL: https://github.com/apache/flink/pull/16699#issuecomment-892415455
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16699: [FLINK-23420][table-runtime] LinkedListSerializer now checks for null elements in the list
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16699:
URL: https://github.com/apache/flink/pull/16699#issuecomment-892415455
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3fef5459a0a1ac345b72c749f025b8e0136709e0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21467",
"triggerID" : "3fef5459a0a1ac345b72c749f025b8e0136709e0",
"triggerType" : "PUSH"
}, {
"hash" : "2628e78aff84d298c55e52428ab232be78b521a9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21491",
"triggerID" : "2628e78aff84d298c55e52428ab232be78b521a9",
"triggerType" : "PUSH"
}, {
"hash" : "2628e78aff84d298c55e52428ab232be78b521a9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21562",
"triggerID" : "893064811",
"triggerType" : "MANUAL"
}, {
"hash" : "2628e78aff84d298c55e52428ab232be78b521a9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21491",
"triggerID" : "893064811",
"triggerType" : "MANUAL"
}, {
"hash" : "fb666804b2cf16e3aefac6dc51026384749f589f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21610",
"triggerID" : "fb666804b2cf16e3aefac6dc51026384749f589f",
"triggerType" : "PUSH"
}, {
"hash" : "7343f8b1adde98e86eba0f3bcbc647df92f82223",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21751",
"triggerID" : "7343f8b1adde98e86eba0f3bcbc647df92f82223",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7343f8b1adde98e86eba0f3bcbc647df92f82223 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21751)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16699: [FLINK-23420][table-runtime] LinkedListSerializer now checks for null elements in the list
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16699:
URL: https://github.com/apache/flink/pull/16699#issuecomment-892415455
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3fef5459a0a1ac345b72c749f025b8e0136709e0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21467",
"triggerID" : "3fef5459a0a1ac345b72c749f025b8e0136709e0",
"triggerType" : "PUSH"
}, {
"hash" : "2628e78aff84d298c55e52428ab232be78b521a9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21491",
"triggerID" : "2628e78aff84d298c55e52428ab232be78b521a9",
"triggerType" : "PUSH"
}, {
"hash" : "2628e78aff84d298c55e52428ab232be78b521a9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21562",
"triggerID" : "893064811",
"triggerType" : "MANUAL"
}, {
"hash" : "2628e78aff84d298c55e52428ab232be78b521a9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21491",
"triggerID" : "893064811",
"triggerType" : "MANUAL"
}, {
"hash" : "fb666804b2cf16e3aefac6dc51026384749f589f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21610",
"triggerID" : "fb666804b2cf16e3aefac6dc51026384749f589f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2628e78aff84d298c55e52428ab232be78b521a9 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21562) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21491)
* fb666804b2cf16e3aefac6dc51026384749f589f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21610)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tsreaper commented on a change in pull request #16699: [FLINK-23420][table-runtime] LinkedListSerializer now checks for null elements in the list
Posted by GitBox <gi...@apache.org>.
tsreaper commented on a change in pull request #16699:
URL: https://github.com/apache/flink/pull/16699#discussion_r684878442
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/typeutils/LinkedListSerializer.java
##########
@@ -110,17 +124,40 @@ public int getLength() {
@Override
public void serialize(LinkedList<T> list, DataOutputView target) throws IOException {
target.writeInt(list.size());
+ if (hasNullMask) {
+ MaskUtils.writeMask(getNullMask(list), target);
+ }
for (T element : list) {
- elementSerializer.serialize(element, target);
+ if (element != null) {
+ elementSerializer.serialize(element, target);
+ }
}
}
+ private boolean[] getNullMask(LinkedList<T> list) {
+ boolean[] mask = new boolean[list.size()];
Review comment:
I suppose by "reusing" you're meant to not creating a boolean array every time and change its size when the length of list grows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi commented on a change in pull request #16699: [FLINK-23420][table-runtime] LinkedListSerializer now checks for null elements in the list
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #16699:
URL: https://github.com/apache/flink/pull/16699#discussion_r683264310
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/typeutils/LinkedListSerializer.java
##########
@@ -39,18 +39,27 @@
@Internal
public final class LinkedListSerializer<T> extends TypeSerializer<LinkedList<T>> {
+ // legacy, don't touch until we drop support for 1.9 savepoints
private static final long serialVersionUID = 1L;
- /** The serializer for the elements of the list. */
+ // The serializer for the elements of the list.
private final TypeSerializer<T> elementSerializer;
+ // When legacy mode is enabled serializer will not check for null values.
+ private final boolean legacyModeEnabled;
Review comment:
Use `MaskUtils` and ignore this comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi commented on a change in pull request #16699: [FLINK-23420][table-runtime] LinkedListSerializer now checks for null elements in the list
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #16699:
URL: https://github.com/apache/flink/pull/16699#discussion_r683264663
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/typeutils/LinkedListSerializer.java
##########
@@ -186,12 +267,28 @@ public int getCurrentOuterSnapshotVersion() {
return CURRENT_VERSION;
}
+ @Override
+ protected void readOuterSnapshot(
+ int readOuterSnapshotVersion, DataInputView in, ClassLoader userCodeClassLoader) {
+ readVersion = readOuterSnapshotVersion;
+ }
+
+ @Override
+ protected OuterSchemaCompatibility resolveOuterSchemaCompatibility(
+ LinkedListSerializer<T> newSerializer) {
+ if (readVersion <= LAST_NULL_NOT_CHECKED_VERSION) {
Review comment:
It is better to extract a method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16699: [FLINK-23420][table-runtime] LinkedListSerializer now checks for null elements in the list
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16699:
URL: https://github.com/apache/flink/pull/16699#issuecomment-892407951
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 3fef5459a0a1ac345b72c749f025b8e0136709e0 (Wed Aug 04 06:44:55 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi commented on a change in pull request #16699: [FLINK-23420][table-runtime] LinkedListSerializer now checks for null elements in the list
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #16699:
URL: https://github.com/apache/flink/pull/16699#discussion_r686606880
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/typeutils/LinkedListSerializer.java
##########
@@ -110,17 +122,42 @@ public int getLength() {
@Override
public void serialize(LinkedList<T> list, DataOutputView target) throws IOException {
target.writeInt(list.size());
+ if (hasNullMask) {
+ MaskUtils.writeMask(getNullMask(list), target);
+ }
for (T element : list) {
- elementSerializer.serialize(element, target);
+ if (element != null) {
+ elementSerializer.serialize(element, target);
+ }
}
}
+ private boolean[] getNullMask(LinkedList<T> list) {
+ if (reuseMask == null || reuseMask.length != list.size()) {
Review comment:
`reuseMask.length < list.size()`
We can introduce a `void writeMask(boolean[] mask, int length, DataOutputView target)` to `MaskUtils`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16699: [FLINK-23420][table-runtime] LinkedListSerializer now checks for null elements in the list
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16699:
URL: https://github.com/apache/flink/pull/16699#issuecomment-892415455
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3fef5459a0a1ac345b72c749f025b8e0136709e0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21467",
"triggerID" : "3fef5459a0a1ac345b72c749f025b8e0136709e0",
"triggerType" : "PUSH"
}, {
"hash" : "2628e78aff84d298c55e52428ab232be78b521a9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21491",
"triggerID" : "2628e78aff84d298c55e52428ab232be78b521a9",
"triggerType" : "PUSH"
}, {
"hash" : "2628e78aff84d298c55e52428ab232be78b521a9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21562",
"triggerID" : "893064811",
"triggerType" : "MANUAL"
}, {
"hash" : "2628e78aff84d298c55e52428ab232be78b521a9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21491",
"triggerID" : "893064811",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 2628e78aff84d298c55e52428ab232be78b521a9 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21562) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21491)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16699: [FLINK-23420][table-runtime] LinkedListSerializer now checks for null elements in the list
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16699:
URL: https://github.com/apache/flink/pull/16699#issuecomment-892415455
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3fef5459a0a1ac345b72c749f025b8e0136709e0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21467",
"triggerID" : "3fef5459a0a1ac345b72c749f025b8e0136709e0",
"triggerType" : "PUSH"
}, {
"hash" : "2628e78aff84d298c55e52428ab232be78b521a9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21491",
"triggerID" : "2628e78aff84d298c55e52428ab232be78b521a9",
"triggerType" : "PUSH"
}, {
"hash" : "2628e78aff84d298c55e52428ab232be78b521a9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21562",
"triggerID" : "893064811",
"triggerType" : "MANUAL"
}, {
"hash" : "2628e78aff84d298c55e52428ab232be78b521a9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21491",
"triggerID" : "893064811",
"triggerType" : "MANUAL"
}, {
"hash" : "fb666804b2cf16e3aefac6dc51026384749f589f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21610",
"triggerID" : "fb666804b2cf16e3aefac6dc51026384749f589f",
"triggerType" : "PUSH"
}, {
"hash" : "7343f8b1adde98e86eba0f3bcbc647df92f82223",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21751",
"triggerID" : "7343f8b1adde98e86eba0f3bcbc647df92f82223",
"triggerType" : "PUSH"
}, {
"hash" : "cbd9c3e0b04fd380bf7f982ce651f701ce5c0daa",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21946",
"triggerID" : "cbd9c3e0b04fd380bf7f982ce651f701ce5c0daa",
"triggerType" : "PUSH"
}, {
"hash" : "cbd9c3e0b04fd380bf7f982ce651f701ce5c0daa",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22047",
"triggerID" : "898191329",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* cbd9c3e0b04fd380bf7f982ce651f701ce5c0daa Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21946) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22047)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tsreaper commented on pull request #16699: [FLINK-23420][table-runtime] LinkedListSerializer now checks for null elements in the list
Posted by GitBox <gi...@apache.org>.
tsreaper commented on pull request #16699:
URL: https://github.com/apache/flink/pull/16699#issuecomment-898191329
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16699: [FLINK-23420][table-runtime] LinkedListSerializer now checks for null elements in the list
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16699:
URL: https://github.com/apache/flink/pull/16699#issuecomment-892415455
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3fef5459a0a1ac345b72c749f025b8e0136709e0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21467",
"triggerID" : "3fef5459a0a1ac345b72c749f025b8e0136709e0",
"triggerType" : "PUSH"
}, {
"hash" : "2628e78aff84d298c55e52428ab232be78b521a9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21491",
"triggerID" : "2628e78aff84d298c55e52428ab232be78b521a9",
"triggerType" : "PUSH"
}, {
"hash" : "2628e78aff84d298c55e52428ab232be78b521a9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21562",
"triggerID" : "893064811",
"triggerType" : "MANUAL"
}, {
"hash" : "2628e78aff84d298c55e52428ab232be78b521a9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21491",
"triggerID" : "893064811",
"triggerType" : "MANUAL"
}, {
"hash" : "fb666804b2cf16e3aefac6dc51026384749f589f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fb666804b2cf16e3aefac6dc51026384749f589f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2628e78aff84d298c55e52428ab232be78b521a9 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21562) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21491)
* fb666804b2cf16e3aefac6dc51026384749f589f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16699: [FLINK-23420][table-runtime] LinkedListSerializer now checks for null elements in the list
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16699:
URL: https://github.com/apache/flink/pull/16699#issuecomment-892415455
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3fef5459a0a1ac345b72c749f025b8e0136709e0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21467",
"triggerID" : "3fef5459a0a1ac345b72c749f025b8e0136709e0",
"triggerType" : "PUSH"
}, {
"hash" : "2628e78aff84d298c55e52428ab232be78b521a9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21491",
"triggerID" : "2628e78aff84d298c55e52428ab232be78b521a9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3fef5459a0a1ac345b72c749f025b8e0136709e0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21467)
* 2628e78aff84d298c55e52428ab232be78b521a9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21491)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16699: [FLINK-23420][table-runtime] LinkedListSerializer now checks for null elements in the list
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16699:
URL: https://github.com/apache/flink/pull/16699#issuecomment-892415455
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3fef5459a0a1ac345b72c749f025b8e0136709e0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21467",
"triggerID" : "3fef5459a0a1ac345b72c749f025b8e0136709e0",
"triggerType" : "PUSH"
}, {
"hash" : "2628e78aff84d298c55e52428ab232be78b521a9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2628e78aff84d298c55e52428ab232be78b521a9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3fef5459a0a1ac345b72c749f025b8e0136709e0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21467)
* 2628e78aff84d298c55e52428ab232be78b521a9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tsreaper commented on pull request #16699: [FLINK-23420][table-runtime] LinkedListSerializer now checks for null elements in the list
Posted by GitBox <gi...@apache.org>.
tsreaper commented on pull request #16699:
URL: https://github.com/apache/flink/pull/16699#issuecomment-893064811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16699: [FLINK-23420][table-runtime] LinkedListSerializer now checks for null elements in the list
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16699:
URL: https://github.com/apache/flink/pull/16699#issuecomment-892415455
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3fef5459a0a1ac345b72c749f025b8e0136709e0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21467",
"triggerID" : "3fef5459a0a1ac345b72c749f025b8e0136709e0",
"triggerType" : "PUSH"
}, {
"hash" : "2628e78aff84d298c55e52428ab232be78b521a9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21491",
"triggerID" : "2628e78aff84d298c55e52428ab232be78b521a9",
"triggerType" : "PUSH"
}, {
"hash" : "2628e78aff84d298c55e52428ab232be78b521a9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21562",
"triggerID" : "893064811",
"triggerType" : "MANUAL"
}, {
"hash" : "2628e78aff84d298c55e52428ab232be78b521a9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21491",
"triggerID" : "893064811",
"triggerType" : "MANUAL"
}, {
"hash" : "fb666804b2cf16e3aefac6dc51026384749f589f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21610",
"triggerID" : "fb666804b2cf16e3aefac6dc51026384749f589f",
"triggerType" : "PUSH"
}, {
"hash" : "7343f8b1adde98e86eba0f3bcbc647df92f82223",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21751",
"triggerID" : "7343f8b1adde98e86eba0f3bcbc647df92f82223",
"triggerType" : "PUSH"
}, {
"hash" : "cbd9c3e0b04fd380bf7f982ce651f701ce5c0daa",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cbd9c3e0b04fd380bf7f982ce651f701ce5c0daa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7343f8b1adde98e86eba0f3bcbc647df92f82223 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21751)
* cbd9c3e0b04fd380bf7f982ce651f701ce5c0daa UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tsreaper commented on pull request #16699: [FLINK-23420][table-runtime] LinkedListSerializer now checks for null elements in the list
Posted by GitBox <gi...@apache.org>.
tsreaper commented on pull request #16699:
URL: https://github.com/apache/flink/pull/16699#issuecomment-893298688
After discussing with @JingsongLi , the biggest problem of the current implementation is the overhead of the null boolean before each element. We're going to use `MaskUtils#writeMask` like `RowSerializer` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16699: [FLINK-23420][table-runtime] LinkedListSerializer now checks for null elements in the list
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16699:
URL: https://github.com/apache/flink/pull/16699#issuecomment-892415455
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3fef5459a0a1ac345b72c749f025b8e0136709e0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21467",
"triggerID" : "3fef5459a0a1ac345b72c749f025b8e0136709e0",
"triggerType" : "PUSH"
}, {
"hash" : "2628e78aff84d298c55e52428ab232be78b521a9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21491",
"triggerID" : "2628e78aff84d298c55e52428ab232be78b521a9",
"triggerType" : "PUSH"
}, {
"hash" : "2628e78aff84d298c55e52428ab232be78b521a9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21562",
"triggerID" : "893064811",
"triggerType" : "MANUAL"
}, {
"hash" : "2628e78aff84d298c55e52428ab232be78b521a9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21491",
"triggerID" : "893064811",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 2628e78aff84d298c55e52428ab232be78b521a9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21562) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21491)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16699: [FLINK-23420][table-runtime] LinkedListSerializer now checks for null elements in the list
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16699:
URL: https://github.com/apache/flink/pull/16699#issuecomment-892415455
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3fef5459a0a1ac345b72c749f025b8e0136709e0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21467",
"triggerID" : "3fef5459a0a1ac345b72c749f025b8e0136709e0",
"triggerType" : "PUSH"
}, {
"hash" : "2628e78aff84d298c55e52428ab232be78b521a9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21491",
"triggerID" : "2628e78aff84d298c55e52428ab232be78b521a9",
"triggerType" : "PUSH"
}, {
"hash" : "2628e78aff84d298c55e52428ab232be78b521a9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21562",
"triggerID" : "893064811",
"triggerType" : "MANUAL"
}, {
"hash" : "2628e78aff84d298c55e52428ab232be78b521a9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21491",
"triggerID" : "893064811",
"triggerType" : "MANUAL"
}, {
"hash" : "fb666804b2cf16e3aefac6dc51026384749f589f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21610",
"triggerID" : "fb666804b2cf16e3aefac6dc51026384749f589f",
"triggerType" : "PUSH"
}, {
"hash" : "7343f8b1adde98e86eba0f3bcbc647df92f82223",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7343f8b1adde98e86eba0f3bcbc647df92f82223",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fb666804b2cf16e3aefac6dc51026384749f589f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21610)
* 7343f8b1adde98e86eba0f3bcbc647df92f82223 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tsreaper commented on pull request #16699: [FLINK-23420][table-runtime] LinkedListSerializer now checks for null elements in the list
Posted by GitBox <gi...@apache.org>.
tsreaper commented on pull request #16699:
URL: https://github.com/apache/flink/pull/16699#issuecomment-893064811
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16699: [FLINK-23420][table-runtime] LinkedListSerializer now checks for null elements in the list
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16699:
URL: https://github.com/apache/flink/pull/16699#issuecomment-892415455
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3fef5459a0a1ac345b72c749f025b8e0136709e0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21467",
"triggerID" : "3fef5459a0a1ac345b72c749f025b8e0136709e0",
"triggerType" : "PUSH"
}, {
"hash" : "2628e78aff84d298c55e52428ab232be78b521a9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21491",
"triggerID" : "2628e78aff84d298c55e52428ab232be78b521a9",
"triggerType" : "PUSH"
}, {
"hash" : "2628e78aff84d298c55e52428ab232be78b521a9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21562",
"triggerID" : "893064811",
"triggerType" : "MANUAL"
}, {
"hash" : "2628e78aff84d298c55e52428ab232be78b521a9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21491",
"triggerID" : "893064811",
"triggerType" : "MANUAL"
}, {
"hash" : "fb666804b2cf16e3aefac6dc51026384749f589f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21610",
"triggerID" : "fb666804b2cf16e3aefac6dc51026384749f589f",
"triggerType" : "PUSH"
}, {
"hash" : "7343f8b1adde98e86eba0f3bcbc647df92f82223",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21751",
"triggerID" : "7343f8b1adde98e86eba0f3bcbc647df92f82223",
"triggerType" : "PUSH"
}, {
"hash" : "cbd9c3e0b04fd380bf7f982ce651f701ce5c0daa",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21946",
"triggerID" : "cbd9c3e0b04fd380bf7f982ce651f701ce5c0daa",
"triggerType" : "PUSH"
}, {
"hash" : "cbd9c3e0b04fd380bf7f982ce651f701ce5c0daa",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22047",
"triggerID" : "898191329",
"triggerType" : "MANUAL"
}, {
"hash" : "cbd9c3e0b04fd380bf7f982ce651f701ce5c0daa",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21946",
"triggerID" : "898191329",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* cbd9c3e0b04fd380bf7f982ce651f701ce5c0daa Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22047) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21946)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi commented on a change in pull request #16699: [FLINK-23420][table-runtime] LinkedListSerializer now checks for null elements in the list
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #16699:
URL: https://github.com/apache/flink/pull/16699#discussion_r684875870
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/typeutils/LinkedListSerializer.java
##########
@@ -110,17 +124,40 @@ public int getLength() {
@Override
public void serialize(LinkedList<T> list, DataOutputView target) throws IOException {
target.writeInt(list.size());
+ if (hasNullMask) {
+ MaskUtils.writeMask(getNullMask(list), target);
+ }
for (T element : list) {
- elementSerializer.serialize(element, target);
+ if (element != null) {
+ elementSerializer.serialize(element, target);
+ }
}
}
+ private boolean[] getNullMask(LinkedList<T> list) {
+ boolean[] mask = new boolean[list.size()];
Review comment:
I think we should reuse this mask.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16699: [FLINK-23420][table-runtime] LinkedListSerializer now checks for null elements in the list
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16699:
URL: https://github.com/apache/flink/pull/16699#issuecomment-892415455
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3fef5459a0a1ac345b72c749f025b8e0136709e0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21467",
"triggerID" : "3fef5459a0a1ac345b72c749f025b8e0136709e0",
"triggerType" : "PUSH"
}, {
"hash" : "2628e78aff84d298c55e52428ab232be78b521a9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21491",
"triggerID" : "2628e78aff84d298c55e52428ab232be78b521a9",
"triggerType" : "PUSH"
}, {
"hash" : "2628e78aff84d298c55e52428ab232be78b521a9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21562",
"triggerID" : "893064811",
"triggerType" : "MANUAL"
}, {
"hash" : "2628e78aff84d298c55e52428ab232be78b521a9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21491",
"triggerID" : "893064811",
"triggerType" : "MANUAL"
}, {
"hash" : "fb666804b2cf16e3aefac6dc51026384749f589f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21610",
"triggerID" : "fb666804b2cf16e3aefac6dc51026384749f589f",
"triggerType" : "PUSH"
}, {
"hash" : "7343f8b1adde98e86eba0f3bcbc647df92f82223",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21751",
"triggerID" : "7343f8b1adde98e86eba0f3bcbc647df92f82223",
"triggerType" : "PUSH"
}, {
"hash" : "cbd9c3e0b04fd380bf7f982ce651f701ce5c0daa",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21946",
"triggerID" : "cbd9c3e0b04fd380bf7f982ce651f701ce5c0daa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cbd9c3e0b04fd380bf7f982ce651f701ce5c0daa Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21946)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16699: [FLINK-23420][table-runtime] LinkedListSerializer now checks for null elements in the list
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16699:
URL: https://github.com/apache/flink/pull/16699#issuecomment-892415455
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3fef5459a0a1ac345b72c749f025b8e0136709e0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21467",
"triggerID" : "3fef5459a0a1ac345b72c749f025b8e0136709e0",
"triggerType" : "PUSH"
}, {
"hash" : "2628e78aff84d298c55e52428ab232be78b521a9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21491",
"triggerID" : "2628e78aff84d298c55e52428ab232be78b521a9",
"triggerType" : "PUSH"
}, {
"hash" : "2628e78aff84d298c55e52428ab232be78b521a9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21562",
"triggerID" : "893064811",
"triggerType" : "MANUAL"
}, {
"hash" : "2628e78aff84d298c55e52428ab232be78b521a9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21491",
"triggerID" : "893064811",
"triggerType" : "MANUAL"
}, {
"hash" : "fb666804b2cf16e3aefac6dc51026384749f589f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21610",
"triggerID" : "fb666804b2cf16e3aefac6dc51026384749f589f",
"triggerType" : "PUSH"
}, {
"hash" : "7343f8b1adde98e86eba0f3bcbc647df92f82223",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21751",
"triggerID" : "7343f8b1adde98e86eba0f3bcbc647df92f82223",
"triggerType" : "PUSH"
}, {
"hash" : "cbd9c3e0b04fd380bf7f982ce651f701ce5c0daa",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21946",
"triggerID" : "cbd9c3e0b04fd380bf7f982ce651f701ce5c0daa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7343f8b1adde98e86eba0f3bcbc647df92f82223 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21751)
* cbd9c3e0b04fd380bf7f982ce651f701ce5c0daa Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21946)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi commented on a change in pull request #16699: [FLINK-23420][table-runtime] LinkedListSerializer now checks for null elements in the list
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #16699:
URL: https://github.com/apache/flink/pull/16699#discussion_r683163489
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/typeutils/LinkedListSerializer.java
##########
@@ -186,12 +267,28 @@ public int getCurrentOuterSnapshotVersion() {
return CURRENT_VERSION;
}
+ @Override
+ protected void readOuterSnapshot(
+ int readOuterSnapshotVersion, DataInputView in, ClassLoader userCodeClassLoader) {
+ readVersion = readOuterSnapshotVersion;
+ }
+
+ @Override
+ protected OuterSchemaCompatibility resolveOuterSchemaCompatibility(
+ LinkedListSerializer<T> newSerializer) {
+ if (readVersion <= LAST_NULL_NOT_CHECKED_VERSION) {
Review comment:
```
private boolean isCompatible() {
return readVersion > LAST_NULL_NOT_CHECKED_VERSION || NullableSerializer.checkIfNullSupported(eleSer);
}
```
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/typeutils/LinkedListSerializer.java
##########
@@ -186,12 +267,28 @@ public int getCurrentOuterSnapshotVersion() {
return CURRENT_VERSION;
}
+ @Override
+ protected void readOuterSnapshot(
+ int readOuterSnapshotVersion, DataInputView in, ClassLoader userCodeClassLoader) {
+ readVersion = readOuterSnapshotVersion;
+ }
+
+ @Override
+ protected OuterSchemaCompatibility resolveOuterSchemaCompatibility(
+ LinkedListSerializer<T> newSerializer) {
+ if (readVersion <= LAST_NULL_NOT_CHECKED_VERSION) {
+ return OuterSchemaCompatibility.COMPATIBLE_AFTER_MIGRATION;
Review comment:
We could consider `NullableSerializer.checkIfNullSupported` too.
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/typeutils/LinkedListSerializer.java
##########
@@ -39,18 +39,27 @@
@Internal
public final class LinkedListSerializer<T> extends TypeSerializer<LinkedList<T>> {
+ // legacy, don't touch until we drop support for 1.9 savepoints
private static final long serialVersionUID = 1L;
- /** The serializer for the elements of the list. */
+ // The serializer for the elements of the list.
private final TypeSerializer<T> elementSerializer;
+ // When legacy mode is enabled serializer will not check for null values.
+ private final boolean legacyModeEnabled;
Review comment:
`nullSafe`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi commented on a change in pull request #16699: [FLINK-23420][table-runtime] LinkedListSerializer now checks for null elements in the list
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #16699:
URL: https://github.com/apache/flink/pull/16699#discussion_r683163489
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/typeutils/LinkedListSerializer.java
##########
@@ -186,12 +267,28 @@ public int getCurrentOuterSnapshotVersion() {
return CURRENT_VERSION;
}
+ @Override
+ protected void readOuterSnapshot(
+ int readOuterSnapshotVersion, DataInputView in, ClassLoader userCodeClassLoader) {
+ readVersion = readOuterSnapshotVersion;
+ }
+
+ @Override
+ protected OuterSchemaCompatibility resolveOuterSchemaCompatibility(
+ LinkedListSerializer<T> newSerializer) {
+ if (readVersion <= LAST_NULL_NOT_CHECKED_VERSION) {
Review comment:
```
private boolean isCompatible() {
return readVersion > LAST_NULL_NOT_CHECKED_VERSION || NullableSerializer.checkIfNullSupported(eleSer);
}
```
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/typeutils/LinkedListSerializer.java
##########
@@ -186,12 +267,28 @@ public int getCurrentOuterSnapshotVersion() {
return CURRENT_VERSION;
}
+ @Override
+ protected void readOuterSnapshot(
+ int readOuterSnapshotVersion, DataInputView in, ClassLoader userCodeClassLoader) {
+ readVersion = readOuterSnapshotVersion;
+ }
+
+ @Override
+ protected OuterSchemaCompatibility resolveOuterSchemaCompatibility(
+ LinkedListSerializer<T> newSerializer) {
+ if (readVersion <= LAST_NULL_NOT_CHECKED_VERSION) {
+ return OuterSchemaCompatibility.COMPATIBLE_AFTER_MIGRATION;
Review comment:
We could consider `NullableSerializer.checkIfNullSupported` too.
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/typeutils/LinkedListSerializer.java
##########
@@ -39,18 +39,27 @@
@Internal
public final class LinkedListSerializer<T> extends TypeSerializer<LinkedList<T>> {
+ // legacy, don't touch until we drop support for 1.9 savepoints
private static final long serialVersionUID = 1L;
- /** The serializer for the elements of the list. */
+ // The serializer for the elements of the list.
private final TypeSerializer<T> elementSerializer;
+ // When legacy mode is enabled serializer will not check for null values.
+ private final boolean legacyModeEnabled;
Review comment:
`nullSafe`?
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/typeutils/LinkedListSerializer.java
##########
@@ -186,12 +267,28 @@ public int getCurrentOuterSnapshotVersion() {
return CURRENT_VERSION;
}
+ @Override
+ protected void readOuterSnapshot(
+ int readOuterSnapshotVersion, DataInputView in, ClassLoader userCodeClassLoader) {
+ readVersion = readOuterSnapshotVersion;
+ }
+
+ @Override
+ protected OuterSchemaCompatibility resolveOuterSchemaCompatibility(
+ LinkedListSerializer<T> newSerializer) {
+ if (readVersion <= LAST_NULL_NOT_CHECKED_VERSION) {
+ return OuterSchemaCompatibility.COMPATIBLE_AFTER_MIGRATION;
Review comment:
Or you can use `MaskUtils` and ignore `checkIfNullSupported`. This way will not waste much space.
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/typeutils/LinkedListSerializer.java
##########
@@ -39,18 +39,27 @@
@Internal
public final class LinkedListSerializer<T> extends TypeSerializer<LinkedList<T>> {
+ // legacy, don't touch until we drop support for 1.9 savepoints
private static final long serialVersionUID = 1L;
- /** The serializer for the elements of the list. */
+ // The serializer for the elements of the list.
private final TypeSerializer<T> elementSerializer;
+ // When legacy mode is enabled serializer will not check for null values.
+ private final boolean legacyModeEnabled;
Review comment:
Use `MaskUtils` and ignore this comment.
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/typeutils/LinkedListSerializer.java
##########
@@ -186,12 +267,28 @@ public int getCurrentOuterSnapshotVersion() {
return CURRENT_VERSION;
}
+ @Override
+ protected void readOuterSnapshot(
+ int readOuterSnapshotVersion, DataInputView in, ClassLoader userCodeClassLoader) {
+ readVersion = readOuterSnapshotVersion;
+ }
+
+ @Override
+ protected OuterSchemaCompatibility resolveOuterSchemaCompatibility(
+ LinkedListSerializer<T> newSerializer) {
+ if (readVersion <= LAST_NULL_NOT_CHECKED_VERSION) {
Review comment:
It is better to extract a method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16699: [FLINK-23420][table-runtime] LinkedListSerializer now checks for null elements in the list
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16699:
URL: https://github.com/apache/flink/pull/16699#issuecomment-892415455
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3fef5459a0a1ac345b72c749f025b8e0136709e0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21467",
"triggerID" : "3fef5459a0a1ac345b72c749f025b8e0136709e0",
"triggerType" : "PUSH"
}, {
"hash" : "2628e78aff84d298c55e52428ab232be78b521a9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21491",
"triggerID" : "2628e78aff84d298c55e52428ab232be78b521a9",
"triggerType" : "PUSH"
}, {
"hash" : "2628e78aff84d298c55e52428ab232be78b521a9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21562",
"triggerID" : "893064811",
"triggerType" : "MANUAL"
}, {
"hash" : "2628e78aff84d298c55e52428ab232be78b521a9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21491",
"triggerID" : "893064811",
"triggerType" : "MANUAL"
}, {
"hash" : "fb666804b2cf16e3aefac6dc51026384749f589f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21610",
"triggerID" : "fb666804b2cf16e3aefac6dc51026384749f589f",
"triggerType" : "PUSH"
}, {
"hash" : "7343f8b1adde98e86eba0f3bcbc647df92f82223",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21751",
"triggerID" : "7343f8b1adde98e86eba0f3bcbc647df92f82223",
"triggerType" : "PUSH"
}, {
"hash" : "cbd9c3e0b04fd380bf7f982ce651f701ce5c0daa",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21946",
"triggerID" : "cbd9c3e0b04fd380bf7f982ce651f701ce5c0daa",
"triggerType" : "PUSH"
}, {
"hash" : "cbd9c3e0b04fd380bf7f982ce651f701ce5c0daa",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22047",
"triggerID" : "898191329",
"triggerType" : "MANUAL"
}, {
"hash" : "cbd9c3e0b04fd380bf7f982ce651f701ce5c0daa",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21946",
"triggerID" : "898191329",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* cbd9c3e0b04fd380bf7f982ce651f701ce5c0daa Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22047) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21946)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org