You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@twill.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/03/03 21:41:04 UTC
[jira] [Commented] (TWILL-112) Improve ApplicationBundler
performance
[ https://issues.apache.org/jira/browse/TWILL-112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14345702#comment-14345702 ]
ASF GitHub Bot commented on TWILL-112:
--------------------------------------
GitHub user chtyim opened a pull request:
https://github.com/apache/incubator-twill/pull/27
(TWILL-112) Improve performance of ApplicationBundler
- Not to scan a directory again if the directory was added to the bundle jar that is building in progress already
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chtyim/incubator-twill feature/twill-112
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-twill/pull/27.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #27
----
commit d9967fd3360f277ede9931906b7dc9cb81a34bdb
Author: Terence Yim <ch...@apache.org>
Date: 2015-03-03T20:35:11Z
(TWILL-112) Not to scan a directory again if the directory was added to the bundle jar that is building in progress already
----
> Improve ApplicationBundler performance
> --------------------------------------
>
> Key: TWILL-112
> URL: https://issues.apache.org/jira/browse/TWILL-112
> Project: Apache Twill
> Issue Type: Improvement
> Affects Versions: 0.2.0-incubating, 0.1.0-incubating, 0.3.0-incubating, 0.4.0-incubating
> Reporter: Terence Yim
> Assignee: Terence Yim
> Fix For: 0.6.0-incubating
>
>
> The ApplicationBundler doesn't check for duplicate directory before scanning the directory recursively, resulting in a lot of time being wasted in just scanning and then figured that each file under the directory has been added to the final jar.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)