You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/03 21:46:30 UTC

[GitHub] [arrow-datafusion] renato2099 commented on pull request #1510: Add factorial function

renato2099 commented on PR #1510:
URL: https://github.com/apache/arrow-datafusion/pull/1510#issuecomment-1086955859

   hey guys sorry for the  long radio of silence but yeah ... life (and work) got in the middle :)
   Anyway, I have some questions before I can complete this feature
   
   > It might be good to check out `sqrt` which has a similar pattern (the implementation takes `f64` but the coercion logic will convert integer arguments to floats )
   
   @alamb would you mind sharing a pointer in the code where I could look this up? or do you mean using the `unary_primitive_array_op` and `downcast_compute_op` macros as other functions do?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org