[GitHub] [samza] cameronlee314 commented on a change in pull request #1566: SAMZA-2075: Add execEnvContainerId and execEnvAttemptId for diagnostics for Kubernetes job coordinator

[GitBox <gi...@apache.org>]

cameronlee314 commented on a change in pull request #1566:
URL: https://github.com/apache/samza/pull/1566#discussion_r763371235



##########
File path: samza-core/src/main/java/org/apache/samza/metrics/reporter/MetricsHeader.java
##########
@@ -21,13 +21,15 @@
 import java.util.HashMap;
 import java.util.Map;
 import java.util.Objects;
+import java.util.Optional;
 
 
 public class MetricsHeader {
   private static final String JOB_NAME = "job-name";
   private static final String JOB_ID = "job-id";
   private static final String CONTAINER_NAME = "container-name";
   private static final String EXEC_ENV_CONTAINER_ID = "exec-env-container-id";
+  private static final String EXEC_ENV_ATTEMPT_ID = "exec-env-attempt-id";

Review comment:
       Good suggestion. I like using `samzaEpochId`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org