You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "He Yongqiang (Created) (JIRA)" <ji...@apache.org> on 2011/10/20 19:34:10 UTC

[jira] [Created] (HIVE-2518) pull junit jar from maven repos via ivy

pull junit jar from maven repos via ivy
---------------------------------------

                 Key: HIVE-2518
                 URL: https://issues.apache.org/jira/browse/HIVE-2518
             Project: Hive
          Issue Type: Improvement
            Reporter: He Yongqiang
            Assignee: Kevin Wilfong


see https://issues.apache.org/jira/browse/HIVE-2505

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2518) pull junit jar from maven repos via ivy

Posted by "Kevin Wilfong (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133575#comment-13133575 ] 

Kevin Wilfong commented on HIVE-2518:
-------------------------------------

@Ashutosh
Sorry about that, I'll take care of it.
                
> pull junit jar from maven repos via ivy
> ---------------------------------------
>
>                 Key: HIVE-2518
>                 URL: https://issues.apache.org/jira/browse/HIVE-2518
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: He Yongqiang
>            Assignee: Kevin Wilfong
>
> see https://issues.apache.org/jira/browse/HIVE-2505

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2518) pull junit jar from maven repos via ivy

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240908#comment-13240908 ] 

Hudson commented on HIVE-2518:
------------------------------

Integrated in Hive-trunk-h0.21 #1338 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1338/])
    HIVE-2518 pull junit jar from maven repos via ivy
(Kevin Wilfong via namit) (Revision 1306470)

     Result = FAILURE
namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1306470
Files : 
* /hive/trunk/eclipse-templates/.classpath
* /hive/trunk/ql/ivy.xml
* /hive/trunk/testlibs/junit-4.10.LICENSE.txt
* /hive/trunk/testlibs/junit-4.10.jar

                
> pull junit jar from maven repos via ivy
> ---------------------------------------
>
>                 Key: HIVE-2518
>                 URL: https://issues.apache.org/jira/browse/HIVE-2518
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: He Yongqiang
>            Assignee: Kevin Wilfong
>             Fix For: 0.9.0
>
>         Attachments: HIVE-2518.D2493.1.patch
>
>
> see https://issues.apache.org/jira/browse/HIVE-2505

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2518) pull junit jar from maven repos via ivy

Posted by "Kevin Wilfong (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevin Wilfong updated HIVE-2518:
--------------------------------

    Status: Patch Available  (was: Open)
    
> pull junit jar from maven repos via ivy
> ---------------------------------------
>
>                 Key: HIVE-2518
>                 URL: https://issues.apache.org/jira/browse/HIVE-2518
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: He Yongqiang
>            Assignee: Kevin Wilfong
>         Attachments: HIVE-2518.D2493.1.patch
>
>
> see https://issues.apache.org/jira/browse/HIVE-2505

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2518) pull junit jar from maven repos via ivy

Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Phabricator updated HIVE-2518:
------------------------------

    Attachment: HIVE-2518.D2493.1.patch

kevinwilfong requested code review of "HIVE-2518 [jira] pull junit jar from maven repos via ivy".
Reviewers: JIRA

  https://issues.apache.org/jira/browse/HIVE-2518

  This patch pulls the junit jar from Ivy.  I updated the eclipse classpath and, the unit tests can be run from Eclipse, (once an Hbase test jar has been removed from the build path, a separate issue).

  I added it to the default library as this is where all jars pulled using Ivy, including mockito another test jar, seem to be going.

  see https://issues.apache.org/jira/browse/HIVE-2505

TEST PLAN
  EMPTY

REVISION DETAIL
  https://reviews.facebook.net/D2493

AFFECTED FILES
  eclipse-templates/.classpath
  testlibs/junit-4.10.jar
  testlibs/junit-4.10.LICENSE.txt
  ql/ivy.xml

MANAGE HERALD DIFFERENTIAL RULES
  https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
  https://reviews.facebook.net/herald/transcript/5583/

Tip: use the X-Herald-Rules header to filter Herald messages in your client.

                
> pull junit jar from maven repos via ivy
> ---------------------------------------
>
>                 Key: HIVE-2518
>                 URL: https://issues.apache.org/jira/browse/HIVE-2518
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: He Yongqiang
>            Assignee: Kevin Wilfong
>         Attachments: HIVE-2518.D2493.1.patch
>
>
> see https://issues.apache.org/jira/browse/HIVE-2505

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2518) pull junit jar from maven repos via ivy

Posted by "Ashutosh Chauhan (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236197#comment-13236197 ] 

Ashutosh Chauhan commented on HIVE-2518:
----------------------------------------

@Kevin,
Just checking if there is any progress on this one?
                
> pull junit jar from maven repos via ivy
> ---------------------------------------
>
>                 Key: HIVE-2518
>                 URL: https://issues.apache.org/jira/browse/HIVE-2518
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: He Yongqiang
>            Assignee: Kevin Wilfong
>
> see https://issues.apache.org/jira/browse/HIVE-2505

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2518) pull junit jar from maven repos via ivy

Posted by "Ashutosh Chauhan (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashutosh Chauhan updated HIVE-2518:
-----------------------------------

    Fix Version/s: 0.9.0
    
> pull junit jar from maven repos via ivy
> ---------------------------------------
>
>                 Key: HIVE-2518
>                 URL: https://issues.apache.org/jira/browse/HIVE-2518
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: He Yongqiang
>            Assignee: Kevin Wilfong
>             Fix For: 0.9.0
>
>         Attachments: HIVE-2518.D2493.1.patch
>
>
> see https://issues.apache.org/jira/browse/HIVE-2505

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2518) pull junit jar from maven repos via ivy

Posted by "Namit Jain (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain updated HIVE-2518:
-----------------------------

      Resolution: Fixed
    Hadoop Flags: Reviewed
          Status: Resolved  (was: Patch Available)

Committed. Thanks Kevin
                
> pull junit jar from maven repos via ivy
> ---------------------------------------
>
>                 Key: HIVE-2518
>                 URL: https://issues.apache.org/jira/browse/HIVE-2518
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: He Yongqiang
>            Assignee: Kevin Wilfong
>         Attachments: HIVE-2518.D2493.1.patch
>
>
> see https://issues.apache.org/jira/browse/HIVE-2505

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2518) pull junit jar from maven repos via ivy

Posted by "Ashutosh Chauhan (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133039#comment-13133039 ] 

Ashutosh Chauhan commented on HIVE-2518:
----------------------------------------

@Kevin,
Eclipse integration also broke with upgrade of junit lib version. Can you also take care of that? 
                
> pull junit jar from maven repos via ivy
> ---------------------------------------
>
>                 Key: HIVE-2518
>                 URL: https://issues.apache.org/jira/browse/HIVE-2518
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: He Yongqiang
>            Assignee: Kevin Wilfong
>
> see https://issues.apache.org/jira/browse/HIVE-2505

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2518) pull junit jar from maven repos via ivy

Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240188#comment-13240188 ] 

Phabricator commented on HIVE-2518:
-----------------------------------

njain has accepted the revision "HIVE-2518 [jira] pull junit jar from maven repos via ivy".

REVISION DETAIL
  https://reviews.facebook.net/D2493

BRANCH
  svn

                
> pull junit jar from maven repos via ivy
> ---------------------------------------
>
>                 Key: HIVE-2518
>                 URL: https://issues.apache.org/jira/browse/HIVE-2518
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: He Yongqiang
>            Assignee: Kevin Wilfong
>         Attachments: HIVE-2518.D2493.1.patch
>
>
> see https://issues.apache.org/jira/browse/HIVE-2505

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2518) pull junit jar from maven repos via ivy

Posted by "Ashutosh Chauhan (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237752#comment-13237752 ] 

Ashutosh Chauhan commented on HIVE-2518:
----------------------------------------

No worries : ) Thanks for the update. 
                
> pull junit jar from maven repos via ivy
> ---------------------------------------
>
>                 Key: HIVE-2518
>                 URL: https://issues.apache.org/jira/browse/HIVE-2518
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: He Yongqiang
>            Assignee: Kevin Wilfong
>
> see https://issues.apache.org/jira/browse/HIVE-2505

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2518) pull junit jar from maven repos via ivy

Posted by "Kevin Wilfong (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237748#comment-13237748 ] 

Kevin Wilfong commented on HIVE-2518:
-------------------------------------

@Ashutosh
Sorry about that, I had forgotten.  I made a change to pull the junit jar using maven and removed it from testlibs.  I also updated Eclipse's class path template to get the jar from the new location.  I'm running the tests now to make sure I haven't broken anything and will upload a diff if things go smoothly.

Also, I checked and I can run the tests in Eclipse (once a remove an Hbase test jar from the build path, but that seems to be a separate issue).
                
> pull junit jar from maven repos via ivy
> ---------------------------------------
>
>                 Key: HIVE-2518
>                 URL: https://issues.apache.org/jira/browse/HIVE-2518
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: He Yongqiang
>            Assignee: Kevin Wilfong
>
> see https://issues.apache.org/jira/browse/HIVE-2505

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira