You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Zakelly (via GitHub)" <gi...@apache.org> on 2023/11/07 02:39:18 UTC
[PR] [FLINK-20672] Catch throwable when sending checkpoint aborted messages from JM to TM [flink]
Zakelly opened a new pull request, #23676:
URL: https://github.com/apache/flink/pull/23676
## What is the purpose of the change
Avoid the RPC failure from JM to TM causing JM exit.
## Brief change log
Use try catch to protect the sending logic in async executor when sending checkpoint aborted messages.
## Verifying this change
This change is a trivial rework without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-20672] Catch throwable when sending checkpoint aborted messages from JM to TM [flink]
Posted by "masteryhx (via GitHub)" <gi...@apache.org>.
masteryhx merged PR #23676:
URL: https://github.com/apache/flink/pull/23676
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-20672] Catch throwable when sending checkpoint aborted messages from JM to TM [flink]
Posted by "Zakelly (via GitHub)" <gi...@apache.org>.
Zakelly commented on PR #23676:
URL: https://github.com/apache/flink/pull/23676#issuecomment-1801174911
> I think this is not true after [FLINK-23654](https://issues.apache.org/jira/browse/FLINK-23654) resolved.
@Myasuka Thanks for the information! However I think it is still valid (https://issues.apache.org/jira/browse/FLINK-20672?focusedCommentId=17783892&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17783892), please correct me if I'm wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-20672] Catch throwable when sending checkpoint aborted messages from JM to TM [flink]
Posted by "Zakelly (via GitHub)" <gi...@apache.org>.
Zakelly commented on PR #23676:
URL: https://github.com/apache/flink/pull/23676#issuecomment-1858830768
@Myasuka Sorry to bother you, just a ping...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-20672] Catch throwable when sending checkpoint aborted messages from JM to TM [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #23676:
URL: https://github.com/apache/flink/pull/23676#issuecomment-1797352588
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d420e386f030331c162f0e7ca4e38947f5669992",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d420e386f030331c162f0e7ca4e38947f5669992",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d420e386f030331c162f0e7ca4e38947f5669992 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org