You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/06/01 06:12:33 UTC

[GitHub] [ozone] ChenSammi commented on a diff in pull request #3382: HDDS-6686. Do Leadship check before SASL token verification.

ChenSammi commented on code in PR #3382:
URL: https://github.com/apache/ozone/pull/3382#discussion_r886350701


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OMInterServiceProtocolServerSideImpl.java:
##########
@@ -60,7 +64,7 @@ public BootstrapOMResponse bootstrap(RpcController controller,
           .build();
     }
 
-    checkLeaderStatus();
+    OzoneManagerRatisUtils.checkLeaderStatus(ozoneManager);

Review Comment:
   Hey @neils-dev,  sorry for the late response.  Just want to confirm that the comments left to address is the following, right? 
   
   > The javadoc for validateS3Credential can be updated to include the ServiceException that may be thrown.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org