You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "mhlakhani (via GitHub)" <gi...@apache.org> on 2025/08/25 23:32:35 UTC
[PR] THRIFT-5855: Add netstd fuzzers [thrift]
mhlakhani opened a new pull request, #3203:
URL: https://github.com/apache/thrift/pull/3203
<!-- Explain the changes in the pull request below: -->
Experimental RFC for netstd fuzzers. Requesting review for this one as I'm not sure if this is idiomatic C#, or how to build these projects.
I'm worried about bitrot here. Makefile inclusion will hopefully ensure these build in CI and we don't bitrot the build, but if no one's running these fuzzers regularly (due to lack of oss-fuzz support) I'm not sure how impactful these will be.
<!-- We recommend you review the checklist/tips before submitting a pull request. -->
- [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? ([Request account here](https://selfserve.apache.org/jira-account.html), not required for trivial changes)
- [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit? (not required, but preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
- [x] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] THRIFT-5855: Add netstd fuzzers [thrift]
Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G closed pull request #3203: THRIFT-5855: Add netstd fuzzers
URL: https://github.com/apache/thrift/pull/3203
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] THRIFT-5855: Add netstd fuzzers [thrift]
Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G commented on PR #3203:
URL: https://github.com/apache/thrift/pull/3203#issuecomment-3267962705
I checked twice that I installed sharpfuzz according to the docs but I always get
```
Build succeeded in 1.2s
Instrumenting assemblies for fuzzing ...
Skipping Thrift.FuzzTests.CompactRoundtripAFL.dll
Skipping Thrift.FuzzTests.BinaryParseLibfuzzer.dll
Instrumenting Microsoft.Extensions.Logging.dll
./buildfuzzers.sh: line 121: sharpfuzz: command not found
```
I used the docker jammy build environment, if that is relevant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] THRIFT-5855: Add netstd fuzzers [thrift]
Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G commented on PR #3203:
URL: https://github.com/apache/thrift/pull/3203#issuecomment-3652320714
Converted to draft. Please make it a PR again (via "ready to review") if you completed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] THRIFT-5855: Add netstd fuzzers [thrift]
Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G commented on PR #3203:
URL: https://github.com/apache/thrift/pull/3203#issuecomment-3531699045
see also #3235
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] THRIFT-5855: Add netstd fuzzers [thrift]
Posted by "mhlakhani (via GitHub)" <gi...@apache.org>.
mhlakhani commented on PR #3203:
URL: https://github.com/apache/thrift/pull/3203#issuecomment-3568309125
it looks like after the move to .net 10, this may not be possible, as sharpfuzz doesn't seem to support it. I'll have to do some more research (I'm not a .NET expert unfortunately)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] THRIFT-5855: Add netstd fuzzers [thrift]
Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G commented on PR #3203:
URL: https://github.com/apache/thrift/pull/3203#issuecomment-3577595805
Well, net10 was released only few weeks ago. They might need some time. Since it is the current LTS I would expect it will be supported soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] THRIFT-5855: Add netstd fuzzers [thrift]
Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G commented on PR #3203:
URL: https://github.com/apache/thrift/pull/3203#issuecomment-3293716935
Ping?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] THRIFT-5855: Add netstd fuzzers [thrift]
Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G commented on PR #3203:
URL: https://github.com/apache/thrift/pull/3203#issuecomment-4271522512
Superseded by #3402
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] THRIFT-5855: Add netstd fuzzers [thrift]
Posted by "mhlakhani (via GitHub)" <gi...@apache.org>.
mhlakhani commented on PR #3203:
URL: https://github.com/apache/thrift/pull/3203#issuecomment-3536027647
ah, sorry for the delay here, life got in the way - I'll make a pass this weekend
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org