You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "zhfeng (via GitHub)" <gi...@apache.org> on 2023/06/20 03:39:56 UTC
[GitHub] [camel-quarkus] zhfeng opened a new pull request, #5000: Re-enable jira tests
zhfeng opened a new pull request, #5000:
URL: https://github.com/apache/camel-quarkus/pull/5000
<!-- Uncomment and fill this section if your PR is not trivial
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a diff in pull request #5000: Re-enable jira tests
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on code in PR #5000:
URL: https://github.com/apache/camel-quarkus/pull/5000#discussion_r1234801055
##########
extensions/jira/deployment/src/main/java/org/apache/camel/quarkus/component/jira/deployment/JakartaEnablement.java:
##########
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.jira.deployment;
+
+import java.nio.ByteBuffer;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+
+import io.quarkus.bootstrap.classloading.QuarkusClassLoader;
+import io.quarkus.deployment.annotations.BuildProducer;
+import io.quarkus.deployment.annotations.BuildStep;
+import io.quarkus.deployment.builditem.BytecodeTransformerBuildItem;
+import org.eclipse.transformer.action.ActionContext;
+import org.eclipse.transformer.action.ByteData;
+import org.eclipse.transformer.action.impl.ActionContextImpl;
+import org.eclipse.transformer.action.impl.ByteDataImpl;
+import org.eclipse.transformer.action.impl.ClassActionImpl;
+import org.eclipse.transformer.action.impl.SelectionRuleImpl;
+import org.eclipse.transformer.action.impl.SignatureRuleImpl;
+import org.eclipse.transformer.util.FileUtils;
+import org.objectweb.asm.ClassReader;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Quartz is compiled using references to classes in the javax packages;
Review Comment:
```suggestion
* Jira REST client is compiled using references to classes in the javax packages;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on pull request #5000: Re-enable jira tests
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on PR #5000:
URL: https://github.com/apache/camel-quarkus/pull/5000#issuecomment-1598238989
The JVM tests looks good but the native test is still failing with
```
Error: org.apache.camel.quarkus.component.jira.it.JiraIT Time elapsed: 6.68 s <<< ERROR!
java.lang.NoClassDefFoundError: javax/ws/rs/core/UriBuilder
at com.atlassian.jira.rest.client.internal.async.AsynchronousJiraRestClient.<init>(AsynchronousJiraRestClient.java:58)
at org.apache.camel.component.jira.oauth.OAuthAsynchronousJiraRestClientFactory.create(OAuthAsynchronousJiraRestClientFactory.java:33)
at com.atlassian.jira.rest.client.internal.async.AsynchronousJiraRestClientFactory.createWithBasicHttpAuthentication(AsynchronousJiraRestClientFactory.java:42)
at org.apache.camel.quarkus.component.jira.it.JiraTest.beforeAll(JiraTest.java:78)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on a diff in pull request #5000: Re-enable jira tests
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on code in PR #5000:
URL: https://github.com/apache/camel-quarkus/pull/5000#discussion_r1235042282
##########
extensions/jira/deployment/src/main/java/org/apache/camel/quarkus/component/jira/deployment/JakartaEnablement.java:
##########
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.jira.deployment;
+
+import java.nio.ByteBuffer;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+
+import io.quarkus.bootstrap.classloading.QuarkusClassLoader;
+import io.quarkus.deployment.annotations.BuildProducer;
+import io.quarkus.deployment.annotations.BuildStep;
+import io.quarkus.deployment.builditem.BytecodeTransformerBuildItem;
+import org.eclipse.transformer.action.ActionContext;
+import org.eclipse.transformer.action.ByteData;
+import org.eclipse.transformer.action.impl.ActionContextImpl;
+import org.eclipse.transformer.action.impl.ByteDataImpl;
+import org.eclipse.transformer.action.impl.ClassActionImpl;
+import org.eclipse.transformer.action.impl.SelectionRuleImpl;
+import org.eclipse.transformer.action.impl.SignatureRuleImpl;
+import org.eclipse.transformer.util.FileUtils;
+import org.objectweb.asm.ClassReader;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Quartz is compiled using references to classes in the javax packages;
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on a diff in pull request #5000: Re-enable jira tests
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on code in PR #5000:
URL: https://github.com/apache/camel-quarkus/pull/5000#discussion_r1235179165
##########
integration-tests/jira/pom.xml:
##########
@@ -94,6 +94,16 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-failsafe-plugin</artifactId>
+ <configuration>
+ <!-- Theses classpath configurations must be removed when https://ecosystem.atlassian.net/browse/JRJC-262 gets resolved-->
+ <additionalClasspathElements>
+ <additionalClasspathElement>${project.build.directory}/camel-quarkus-integration-test-jira-${project.version}-native-image-source-jar/lib/modified-com.atlassian.jira.jira-rest-java-client-core-5.2.4.jar</additionalClasspathElement>
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on pull request #5000: Re-enable jira tests
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on PR #5000:
URL: https://github.com/apache/camel-quarkus/pull/5000#issuecomment-1598493940
The native 'JiraIT` test is running by `maven-failsafe-plugin` and I have to add some classpath configuration to the modified `jira-rest-java-client-core` jar. All of theses tricks must be removed when [JRJC-262](https://ecosystem.atlassian.net/browse/JRJC-262) gets resolved.
Anyway, the jira tests are backing to work now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng merged pull request #5000: Re-enable jira tests
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng merged PR #5000:
URL: https://github.com/apache/camel-quarkus/pull/5000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a diff in pull request #5000: Re-enable jira tests
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on code in PR #5000:
URL: https://github.com/apache/camel-quarkus/pull/5000#discussion_r1235063737
##########
integration-tests/jira/pom.xml:
##########
@@ -94,6 +94,16 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-failsafe-plugin</artifactId>
+ <configuration>
+ <!-- Theses classpath configurations must be removed when https://ecosystem.atlassian.net/browse/JRJC-262 gets resolved-->
+ <additionalClasspathElements>
+ <additionalClasspathElement>${project.build.directory}/camel-quarkus-integration-test-jira-${project.version}-native-image-source-jar/lib/modified-com.atlassian.jira.jira-rest-java-client-core-5.2.4.jar</additionalClasspathElement>
Review Comment:
This will fail on `camel-main` as the client has been upgraded in Camel to 5.2.5.
Can you add a version property for this into the project root pom.xml. E.g
```
<jira-rest-client.version>${jira-rest-client-api-version}</jira-rest-client.version>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on a diff in pull request #5000: Re-enable jira tests
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on code in PR #5000:
URL: https://github.com/apache/camel-quarkus/pull/5000#discussion_r1235072448
##########
integration-tests/jira/pom.xml:
##########
@@ -94,6 +94,16 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-failsafe-plugin</artifactId>
+ <configuration>
+ <!-- Theses classpath configurations must be removed when https://ecosystem.atlassian.net/browse/JRJC-262 gets resolved-->
+ <additionalClasspathElements>
+ <additionalClasspathElement>${project.build.directory}/camel-quarkus-integration-test-jira-${project.version}-native-image-source-jar/lib/modified-com.atlassian.jira.jira-rest-java-client-core-5.2.4.jar</additionalClasspathElement>
Review Comment:
Good point - I will add it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org