You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Mostafa Elhemali (JIRA)" <ji...@apache.org> on 2012/11/24 05:36:57 UTC

[jira] [Created] (HADOOP-9087) Queue size metric for metric sinks isn't actually maintained

Mostafa Elhemali created HADOOP-9087:
----------------------------------------

             Summary: Queue size metric for metric sinks isn't actually maintained
                 Key: HADOOP-9087
                 URL: https://issues.apache.org/jira/browse/HADOOP-9087
             Project: Hadoop Common
          Issue Type: Bug
            Reporter: Mostafa Elhemali
            Priority: Minor


Came across this while looking at the code for the metrics system: the qsize gauge in the MetricsSinkAdapter is not updated/maintained so it will always be zero (there's a compiler warning about it actually).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-9087) Queue size metric for metric sinks isn't actually maintained

Posted by "Mostafa Elhemali (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-9087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mostafa Elhemali updated HADOOP-9087:
-------------------------------------

    Attachment: HADOOP-9087.patch

Adding fixed patch (hopefully).
                
> Queue size metric for metric sinks isn't actually maintained
> ------------------------------------------------------------
>
>                 Key: HADOOP-9087
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9087
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Mostafa Elhemali
>            Priority: Minor
>         Attachments: HADOOP-9087.patch
>
>
> Came across this while looking at the code for the metrics system: the qsize gauge in the MetricsSinkAdapter is not updated/maintained so it will always be zero (there's a compiler warning about it actually).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-9087) Queue size metric for metric sinks isn't actually maintained

Posted by "Mostafa Elhemali (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-9087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mostafa Elhemali updated HADOOP-9087:
-------------------------------------

    Attachment: HADOOP-9087.patch

Fix with test (the test was much more difficult than the fix...).
                
> Queue size metric for metric sinks isn't actually maintained
> ------------------------------------------------------------
>
>                 Key: HADOOP-9087
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9087
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Mostafa Elhemali
>            Priority: Minor
>         Attachments: HADOOP-9087.patch
>
>
> Came across this while looking at the code for the metrics system: the qsize gauge in the MetricsSinkAdapter is not updated/maintained so it will always be zero (there's a compiler warning about it actually).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-9087) Queue size metric for metric sinks isn't actually maintained

Posted by "Mostafa Elhemali (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-9087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mostafa Elhemali updated HADOOP-9087:
-------------------------------------

    Attachment:     (was: HADOOP-9087.patch)
    
> Queue size metric for metric sinks isn't actually maintained
> ------------------------------------------------------------
>
>                 Key: HADOOP-9087
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9087
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Mostafa Elhemali
>            Priority: Minor
>         Attachments: HADOOP-9087.patch
>
>
> Came across this while looking at the code for the metrics system: the qsize gauge in the MetricsSinkAdapter is not updated/maintained so it will always be zero (there's a compiler warning about it actually).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-9087) Queue size metric for metric sinks isn't actually maintained

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-9087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13503407#comment-13503407 ] 

Hadoop QA commented on HADOOP-9087:
-----------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12554769/HADOOP-9087.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-common-project/hadoop-common.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1814//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1814//console

This message is automatically generated.
                
> Queue size metric for metric sinks isn't actually maintained
> ------------------------------------------------------------
>
>                 Key: HADOOP-9087
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9087
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Mostafa Elhemali
>            Priority: Minor
>         Attachments: HADOOP-9087.patch
>
>
> Came across this while looking at the code for the metrics system: the qsize gauge in the MetricsSinkAdapter is not updated/maintained so it will always be zero (there's a compiler warning about it actually).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-9087) Queue size metric for metric sinks isn't actually maintained

Posted by "Mostafa Elhemali (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-9087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mostafa Elhemali updated HADOOP-9087:
-------------------------------------

    Status: Patch Available  (was: Open)
    
> Queue size metric for metric sinks isn't actually maintained
> ------------------------------------------------------------
>
>                 Key: HADOOP-9087
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9087
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Mostafa Elhemali
>            Priority: Minor
>         Attachments: HADOOP-9087.patch
>
>
> Came across this while looking at the code for the metrics system: the qsize gauge in the MetricsSinkAdapter is not updated/maintained so it will always be zero (there's a compiler warning about it actually).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-9087) Queue size metric for metric sinks isn't actually maintained

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-9087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13503338#comment-13503338 ] 

Hadoop QA commented on HADOOP-9087:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12554761/HADOOP-9087.patch
  against trunk revision .

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1810//console

This message is automatically generated.
                
> Queue size metric for metric sinks isn't actually maintained
> ------------------------------------------------------------
>
>                 Key: HADOOP-9087
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9087
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Mostafa Elhemali
>            Priority: Minor
>         Attachments: HADOOP-9087.patch
>
>
> Came across this while looking at the code for the metrics system: the qsize gauge in the MetricsSinkAdapter is not updated/maintained so it will always be zero (there's a compiler warning about it actually).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira