You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@felix.apache.org by Dominique Pfister <dp...@adobe.com> on 2014/08/21 15:54:03 UTC

[HttpService - Whiteboard] Missing modifiedService() in AbstractTracker

Hi,

I noticed that in o.a.f.http.whiteboard.internal.tracker.AbstractTracker<T>, methods addingService() and removedService() call their super implementation and then invoke an abstract, subclass responsible override with generic type T. modifiedService(), however, calls the super implementation, only, although an abstract modifiedService() with argument type T is declared, but never used.

Is this an oversight or did I miss something?

Thanks
Dominique

RE: [HttpService - Whiteboard] Missing modifiedService() in AbstractTracker

Posted by Dominique Pfister <dp...@adobe.com>.

Hi Carsten,

Thank you for confirming this, I opened:

https://issues.apache.org/jira/browse/FELIX-4613

Regards
Dominique
________________________________________
From: Carsten Ziegeler <cz...@apache.org>
Sent: Friday, August 22, 2014 6:16 PM
To: dev@felix.apache.org
Subject: Re: [HttpService - Whiteboard] Missing modifiedService() in AbstractTracker

Hi Dominique,

good catch - I think this is a bug - if a whiteboard service changes its
registration properties, this is right now ignored. And yes, I guess the
fix is to call the abstract modifiedService method
Could you please open an issue for this?

Thanks
Carsten


2014-08-21 15:54 GMT+02:00 Dominique Pfister <dp...@adobe.com>:

> Hi,
>
> I noticed that in
> o.a.f.http.whiteboard.internal.tracker.AbstractTracker<T>, methods
> addingService() and removedService() call their super implementation and
> then invoke an abstract, subclass responsible override with generic type T.
> modifiedService(), however, calls the super implementation, only, although
> an abstract modifiedService() with argument type T is declared, but never
> used.
>
> Is this an oversight or did I miss something?
>
> Thanks
> Dominique
>
>


--
Carsten Ziegeler
Adobe Research Switzerland
cziegeler@apache.org

Re: [HttpService - Whiteboard] Missing modifiedService() in AbstractTracker

Posted by Carsten Ziegeler <cz...@apache.org>.

Hi Dominique,

good catch - I think this is a bug - if a whiteboard service changes its
registration properties, this is right now ignored. And yes, I guess the
fix is to call the abstract modifiedService method
Could you please open an issue for this?

Thanks
Carsten


2014-08-21 15:54 GMT+02:00 Dominique Pfister <dp...@adobe.com>:

> Hi,
>
> I noticed that in
> o.a.f.http.whiteboard.internal.tracker.AbstractTracker<T>, methods
> addingService() and removedService() call their super implementation and
> then invoke an abstract, subclass responsible override with generic type T.
> modifiedService(), however, calls the super implementation, only, although
> an abstract modifiedService() with argument type T is declared, but never
> used.
>
> Is this an oversight or did I miss something?
>
> Thanks
> Dominique
>
>


-- 
Carsten Ziegeler
Adobe Research Switzerland
cziegeler@apache.org