You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "RaigorJiang (via GitHub)" <gi...@apache.org> on 2024/02/05 08:51:54 UTC

[I] Refactor `show SPI implementations` DistSQL [shardingsphere]

RaigorJiang opened a new issue, #30004:
URL: https://github.com/apache/shardingsphere/issues/30004

   Now we have some syntax for querying SPI implementations (https://github.com/apache/shardingsphere/issues/28984)
   
   However, their implementation can be simplified. It is hoped that like `CountRuleStatement` and `RuleCountExecutor`, only a group of `statement` and `executor` can be used to implement functions, instead of adding many different `statements` and `executors`.
   
   In addition, the `type` in result coulmns is useful to users (will be defined in the rules), while `name` and `class_path` are things that users do not need to care about, and we can remove them.
   
   Maybe we can reuse `AlgorithmMetaDataQueryResultRows`, and refer to the output format of `SHOW MIGRATION CHECK ALGORITHMS`.
   
   <img width="971" alt="image" src="https://github.com/apache/shardingsphere/assets/5668787/6ded33a9-e06e-4fa9-a3e3-165ec3120a66">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Refactor `show SPI implementations` DistSQL [shardingsphere]

Posted by "yx9o (via GitHub)" <gi...@apache.org>.
yx9o commented on issue #30004:
URL: https://github.com/apache/shardingsphere/issues/30004#issuecomment-1926523901

   @RaigorJiang , I want to try.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Refactor `show SPI implementations` DistSQL [shardingsphere]

Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang closed issue #30004: Refactor `show SPI implementations` DistSQL
URL: https://github.com/apache/shardingsphere/issues/30004


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Refactor `show SPI implementations` DistSQL [shardingsphere]

Posted by "zhaojinchao95 (via GitHub)" <gi...@apache.org>.
zhaojinchao95 commented on issue #30004:
URL: https://github.com/apache/shardingsphere/issues/30004#issuecomment-1961054147

   @yx9o Hi, the `5.5.0` version will be released next week. Can it be completed during this period?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org