[jira] [Commented] (SLING-4999) Check synchronization in RequestProcessorMBeanImpl

["Carsten Ziegeler (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-4999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14947386#comment-14947386 ] 

Carsten Ziegeler commented on SLING-4999:
-----------------------------------------

I think the patch should do the trick. Would be interesting to see what the impact performance wise is.

> Check synchronization in RequestProcessorMBeanImpl
> --------------------------------------------------
>
>                 Key: SLING-4999
>                 URL: https://issues.apache.org/jira/browse/SLING-4999
>             Project: Sling
>          Issue Type: Improvement
>          Components: Engine
>    Affects Versions: Engine 2.4.2
>            Reporter: Carsten Ziegeler
>             Fix For: Engine 2.4.4
>
>         Attachments: 0001-SLING-4999-Check-synchronization-in-RequestProcessor.patch
>
>
> Each and every request goes through RequestProcessorMBeanImpl#addRequestData which is a synchronized block. I think this is a rather heavy bottleneck for request processing.
> In addition, some of the methods which do additional calculation are sync'ed (like getStandardDeviationDurationMsec) but others are not (like getStandardDeviationPeakRecursionDepth). This seems a little bit arbitrary to me



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)