You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "michael-s-molina (via GitHub)" <gi...@apache.org> on 2024/04/03 11:49:32 UTC
Re: [I] [SIP-123] Proposal replacement of data table components with ag-grid [superset]
michael-s-molina commented on issue #27645:
URL: https://github.com/apache/superset/issues/27645#issuecomment-2034368704
> I've sent an email to the AG Grid team just to confirm that there won't be any licensing/EULA issues to contend with in our project, which might be used for commercial or non-commercial purposes. This seems like the occasion to ask for permission rather than forgiveness ;)
Much appreciated @rusackas ❤️
> Also, the SIP makes no mention of converting the Table viz plugin to AG Grid, but assume that's a logical next step in the table roadmap if this phase goes according to plan?
@justinpark I think it's important to add this to the SIP so folks that are not participating in the discussion can understand what's the plan. This depends on the reply of the Ag Grid folks and I can see two scenarios:
- Orgs are not allowed to use the community version of the table when commercializing Superset. In this scenario, all tables still default to AgGrid but we need to add a configuration to disable it and show the old table instead.
- No license restriction. We replace all tables and remove the old table.
During the SIP Office Hours, @yousoph also asked if there is any feature present in the current table that would not be available in AG Grid.
All this content could go under the **Migration Plan and Compatibility** section. We also need to add an example of how our theme could be applicable to the table to ensure visual consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org