[GitHub] spark pull request #17836: [SPARK-20566][SQL] ColumnVector should support `a...

[viirya <gi...@git.apache.org>]

Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17836#discussion_r114488839
  
    --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVector.java ---
    @@ -801,6 +801,14 @@ public final int appendFloats(int count, float v) {
         return result;
       }
     
    +  public final int appendFloats(int length, float[] src, int offset) {
    --- End diff --
    
    Do we really use this API and also `appendDoubles`? I scan the codes but didn't find anywhere they are used.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org