You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@maven.apache.org by Andrew Pennebaker <ap...@42six.com> on 2013/09/18 16:06:16 UTC

Maven parsing pom.xml incorrectly

I'm using Thrift in my Maven project, compiling my .thrift code to .java as
part of the generate-sources step. To do this, I use the maven antrun
plugin in my pom.xml, which executes a command line call to the thrift
executable, and sends it the appropriate argument flags, such as "-out" and
"--gen".

However, when I comment out this plugin with the standard XML comment
syntax <!-- ... -->, Maven fails to parse the pom file. It doesn't like the
fact that the comment contains --gen, expecting the comment to end right
there.

Can we please improve Maven's comment syntax parsing for pom.xml?

Re: Maven parsing pom.xml incorrectly

Posted by Stuart McCulloch <mc...@gmail.com>.
On 18 Sep 2013, at 15:09, Paul Benedict wrote:

> I believe this behavior is correct. IIRC, XML does not allow double-dashes
> inside a comment.

Specifically http://www.w3.org/TR/REC-xml/#sec-comments

	"For compatibility, the string " -- " (double-hyphen) must not occur within comments."

> On Wed, Sep 18, 2013 at 9:06 AM, Andrew Pennebaker <ap...@42six.com>wrote:
> 
>> I'm using Thrift in my Maven project, compiling my .thrift code to .java as
>> part of the generate-sources step. To do this, I use the maven antrun
>> plugin in my pom.xml, which executes a command line call to the thrift
>> executable, and sends it the appropriate argument flags, such as "-out" and
>> "--gen".
>> 
>> However, when I comment out this plugin with the standard XML comment
>> syntax <!-- ... -->, Maven fails to parse the pom file. It doesn't like the
>> fact that the comment contains --gen, expecting the comment to end right
>> there.
>> 
>> Can we please improve Maven's comment syntax parsing for pom.xml?
>> 
> 
> 
> 
> -- 
> Cheers,
> Paul


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
For additional commands, e-mail: users-help@maven.apache.org


Re: Maven parsing pom.xml incorrectly

Posted by Paul Benedict <pb...@apache.org>.
I believe this behavior is correct. IIRC, XML does not allow double-dashes
inside a comment.


On Wed, Sep 18, 2013 at 9:06 AM, Andrew Pennebaker <ap...@42six.com>wrote:

> I'm using Thrift in my Maven project, compiling my .thrift code to .java as
> part of the generate-sources step. To do this, I use the maven antrun
> plugin in my pom.xml, which executes a command line call to the thrift
> executable, and sends it the appropriate argument flags, such as "-out" and
> "--gen".
>
> However, when I comment out this plugin with the standard XML comment
> syntax <!-- ... -->, Maven fails to parse the pom file. It doesn't like the
> fact that the comment contains --gen, expecting the comment to end right
> there.
>
> Can we please improve Maven's comment syntax parsing for pom.xml?
>



-- 
Cheers,
Paul