You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/12/02 13:24:16 UTC
[GitHub] [ignite] Mmuzaf opened a new pull request #9624: IGNITE-16045 Add documentation pages for the snapshot thread pool size property
Mmuzaf opened a new pull request #9624:
URL: https://github.com/apache/ignite/pull/9624
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Nikita-tech-writer commented on a change in pull request #9624: IGNITE-16045 Add documentation pages for the snapshot thread pool size property
Posted by GitBox <gi...@apache.org>.
Nikita-tech-writer commented on a change in pull request #9624:
URL: https://github.com/apache/ignite/pull/9624#discussion_r761797181
##########
File path: docs/_docs/snapshots/snapshots.adoc
##########
@@ -76,16 +76,25 @@ snapshot data spread across the cluster. Each node keeps a segment of the snapsh
The link:persistence/snapshots#restoring-from-snapshot[restore procedure] explains how to tether together all the segments during recovery.
====
-== Configuring Snapshot Directory
+== Configuration
+
+=== Snapshot Directory
By default, a segment of the snapshot is stored in the work directory of a respective Ignite node and uses the same storage
media where Ignite Persistence keeps data, index, WAL, and other files. Since the snapshot can consume as much space as
-already taken by the persistence files and can affect your applications' performance by sharing the disk I/O with the
+already taken by the persistence files and can affect your application's performance by sharing the disk I/O with the
Ignite Persistence routines, it's suggested to store the snapshot and persistence files on different media.
See the link:persistence/snapshot-directory#configuring-snapshot-directory[Configuring Snapshot Directory] page for
configuration examples.
+=== Snapshot Execution Pool
+
+By default, the snapshot thread pool size has value `4`. Decreasing the number of threads involving into snapshot creation will
+increase the total amount of time the snapshot being taking, however, this will keep the disk load within reasonable limits.
+
+See the link:perf-and-troubleshooting/thread-pools-tuning[Ignite Snapshot Execution Pool] page.
Review comment:
```suggestion
See the link:perf-and-troubleshooting/thread-pools-tuning[Ignite Snapshot Execution Pool,window=_blank] page for more details.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Nikita-tech-writer commented on a change in pull request #9624: IGNITE-16045 Add documentation pages for the snapshot thread pool size property
Posted by GitBox <gi...@apache.org>.
Nikita-tech-writer commented on a change in pull request #9624:
URL: https://github.com/apache/ignite/pull/9624#discussion_r761800112
##########
File path: docs/_docs/snapshots/snapshots.adoc
##########
@@ -76,16 +76,25 @@ snapshot data spread across the cluster. Each node keeps a segment of the snapsh
The link:persistence/snapshots#restoring-from-snapshot[restore procedure] explains how to tether together all the segments during recovery.
====
-== Configuring Snapshot Directory
+== Configuration
+
+=== Snapshot Directory
By default, a segment of the snapshot is stored in the work directory of a respective Ignite node and uses the same storage
media where Ignite Persistence keeps data, index, WAL, and other files. Since the snapshot can consume as much space as
-already taken by the persistence files and can affect your applications' performance by sharing the disk I/O with the
+already taken by the persistence files and can affect your application's performance by sharing the disk I/O with the
Ignite Persistence routines, it's suggested to store the snapshot and persistence files on different media.
See the link:persistence/snapshot-directory#configuring-snapshot-directory[Configuring Snapshot Directory] page for
configuration examples.
+=== Snapshot Execution Pool
+
+By default, the snapshot thread pool size has value `4`. Decreasing the number of threads involving into snapshot creation will
+increase the total amount of time the snapshot being taking, however, this will keep the disk load within reasonable limits.
Review comment:
```suggestion
By default, the snapshot thread pool size has a value of `4`. Decreasing the number of threads involved in the snapshot creation process
increases the total amount of time for taking a snapshot. However, this keeps the disk load within reasonable limits.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Mmuzaf merged pull request #9624: IGNITE-16045 Add documentation pages for the snapshot thread pool size property
Posted by GitBox <gi...@apache.org>.
Mmuzaf merged pull request #9624:
URL: https://github.com/apache/ignite/pull/9624
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Nikita-tech-writer commented on pull request #9624: IGNITE-16045 Add documentation pages for the snapshot thread pool size property
Posted by GitBox <gi...@apache.org>.
Nikita-tech-writer commented on pull request #9624:
URL: https://github.com/apache/ignite/pull/9624#issuecomment-985389070
@Mmuzaf I've left a couple of suggestions. The rest LGTM! Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Mmuzaf commented on pull request #9624: IGNITE-16045 Add documentation pages for the snapshot thread pool size property
Posted by GitBox <gi...@apache.org>.
Mmuzaf commented on pull request #9624:
URL: https://github.com/apache/ignite/pull/9624#issuecomment-984624897
@Nikita-tech-writer Can you review the patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org