[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #2768: fix(service/s3):fix DEFAULT_WRITE_MIN_SIZE in s3 service

["Xuanwo (via GitHub)" <gi...@apache.org>]

Xuanwo commented on code in PR #2768:
URL: https://github.com/apache/incubator-opendal/pull/2768#discussion_r1283351161


##########
core/src/services/s3/backend.rs:
##########
@@ -56,7 +56,7 @@ static ENDPOINT_TEMPLATES: Lazy<HashMap<&'static str, &'static str>> = Lazy::new
     m
 });
 
-const DEFAULT_WRITE_MIN_SIZE: usize = 8 * 1024 * 1024;
+const DEFAULT_WRITE_MIN_SIZE: usize = 5 * 1024 * 1024;

Review Comment:
   Hi, 8MiB is the part size recommanded by AWS.



##########
core/src/services/s3/backend.rs:
##########
@@ -56,7 +56,7 @@ static ENDPOINT_TEMPLATES: Lazy<HashMap<&'static str, &'static str>> = Lazy::new
     m
 });
 
-const DEFAULT_WRITE_MIN_SIZE: usize = 8 * 1024 * 1024;
+const DEFAULT_WRITE_MIN_SIZE: usize = 5 * 1024 * 1024;

Review Comment:
   Hi, 8MiB is the part size recommanded by AWS for writing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org