You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by GitBox <gi...@apache.org> on 2020/11/23 14:32:40 UTC
[GitHub] [carbondata] akashrn5 opened a new pull request #4018: [wip]test
akashrn5 opened a new pull request #4018:
URL: https://github.com/apache/carbondata/pull/4018
### Why is this PR needed?
### What changes were proposed in this PR?
### Does this PR introduce any user interface change?
- No
- Yes. (please explain the change and update document)
### Is any new testcase added?
- No
- Yes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and meta entry when there is no update/insert data
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4018:
URL: https://github.com/apache/carbondata/pull/4018#issuecomment-736708005
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3243/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and meta entry when there is no update/insert data
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4018:
URL: https://github.com/apache/carbondata/pull/4018#issuecomment-752935518
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5270/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4018: [wip]test
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4018:
URL: https://github.com/apache/carbondata/pull/4018#issuecomment-732267359
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3113/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] kunal642 commented on pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and meta entry when there is no update/insert data
Posted by GitBox <gi...@apache.org>.
kunal642 commented on pull request #4018:
URL: https://github.com/apache/carbondata/pull/4018#issuecomment-763386381
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and meta entry when there is no update/insert data
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4018:
URL: https://github.com/apache/carbondata/pull/4018#issuecomment-737766059
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3283/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] kunal642 commented on a change in pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and meta entry when there is no update/insert data
Posted by GitBox <gi...@apache.org>.
kunal642 commented on a change in pull request #4018:
URL: https://github.com/apache/carbondata/pull/4018#discussion_r534693837
##########
File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/mutation/merge/CarbonMergeDataSetCommand.scala
##########
@@ -212,17 +212,20 @@ case class CarbonMergeDataSetCommand(
}
val dataFrame = loadDF.select(tableCols.map(col): _*)
- CarbonInsertIntoCommand(databaseNameOp = Some(carbonTable.getDatabaseName),
- tableName = carbonTable.getTableName,
- options = Map("fileheader" -> header),
- isOverwriteTable = false,
- dataFrame.queryExecution.logical,
- carbonTable.getTableInfo,
- Map.empty,
- Map.empty,
- new OperationContext,
- updateTableModel
- ).run(sparkSession)
+ if (mergeMatches.matchList.flatMap(_.getActions).exists(p => p.isInstanceOf[InsertAction]) ||
Review comment:
Can we move this and the check in CarbonProjectForUpdateCommand.scala to a common place in InsertIntoCommand?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and meta entry when there is no update/insert data
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4018:
URL: https://github.com/apache/carbondata/pull/4018#issuecomment-736622862
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4996/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] asfgit closed pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and meta entry when there is no update/insert data
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4018:
URL: https://github.com/apache/carbondata/pull/4018
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] akashrn5 commented on pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and meta entry when there is no update/insert data
Posted by GitBox <gi...@apache.org>.
akashrn5 commented on pull request #4018:
URL: https://github.com/apache/carbondata/pull/4018#issuecomment-736634922
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and meta entry when there is no update/insert data
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4018:
URL: https://github.com/apache/carbondata/pull/4018#issuecomment-737124721
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3262/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and meta entry when there is no update/insert data
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4018:
URL: https://github.com/apache/carbondata/pull/4018#issuecomment-738006908
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5045/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and entry to table status when there is no update
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4018:
URL: https://github.com/apache/carbondata/pull/4018#issuecomment-732802293
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3125/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] kunal642 commented on pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and entry to table status when there is no update
Posted by GitBox <gi...@apache.org>.
kunal642 commented on pull request #4018:
URL: https://github.com/apache/carbondata/pull/4018#issuecomment-734143416
@akashrn5 Does insert from an empty table have the same behavior?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and meta entry when there is no update/insert data
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4018:
URL: https://github.com/apache/carbondata/pull/4018#issuecomment-737047075
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5013/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and meta entry when there is no update/insert data
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4018:
URL: https://github.com/apache/carbondata/pull/4018#issuecomment-736787550
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5004/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and meta entry when there is no update/insert data
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4018:
URL: https://github.com/apache/carbondata/pull/4018#issuecomment-736788185
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3249/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] akashrn5 commented on a change in pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and meta entry when there is no update/insert data
Posted by GitBox <gi...@apache.org>.
akashrn5 commented on a change in pull request #4018:
URL: https://github.com/apache/carbondata/pull/4018#discussion_r534771957
##########
File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/mutation/merge/CarbonMergeDataSetCommand.scala
##########
@@ -212,17 +212,20 @@ case class CarbonMergeDataSetCommand(
}
val dataFrame = loadDF.select(tableCols.map(col): _*)
- CarbonInsertIntoCommand(databaseNameOp = Some(carbonTable.getDatabaseName),
- tableName = carbonTable.getTableName,
- options = Map("fileheader" -> header),
- isOverwriteTable = false,
- dataFrame.queryExecution.logical,
- carbonTable.getTableInfo,
- Map.empty,
- Map.empty,
- new OperationContext,
- updateTableModel
- ).run(sparkSession)
+ if (mergeMatches.matchList.flatMap(_.getActions).exists(p => p.isInstanceOf[InsertAction]) ||
Review comment:
handled, please check
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and meta entry when there is no update/insert data
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4018:
URL: https://github.com/apache/carbondata/pull/4018#issuecomment-737759882
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5041/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and meta entry when there is no update/insert data
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4018:
URL: https://github.com/apache/carbondata/pull/4018#issuecomment-763434524
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3558/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and meta entry when there is no update/insert data
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4018:
URL: https://github.com/apache/carbondata/pull/4018#issuecomment-751644282
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3486/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and entry to table status when there is no update
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4018:
URL: https://github.com/apache/carbondata/pull/4018#issuecomment-732803344
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4878/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and meta entry when there is no update/insert data
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4018:
URL: https://github.com/apache/carbondata/pull/4018#issuecomment-738008523
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3287/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] akashrn5 commented on pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and meta entry when there is no update/insert data
Posted by GitBox <gi...@apache.org>.
akashrn5 commented on pull request #4018:
URL: https://github.com/apache/carbondata/pull/4018#issuecomment-736621452
@kunal642 handled for CTAS and added test cases, please review and merge
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and meta entry when there is no update/insert data
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4018:
URL: https://github.com/apache/carbondata/pull/4018#issuecomment-752935706
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3509/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and meta entry when there is no update/insert data
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4018:
URL: https://github.com/apache/carbondata/pull/4018#issuecomment-751642960
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5247/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4018: [wip]test
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4018:
URL: https://github.com/apache/carbondata/pull/4018#issuecomment-732263808
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4866/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] akashrn5 commented on pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and meta entry when there is no update/insert data
Posted by GitBox <gi...@apache.org>.
akashrn5 commented on pull request #4018:
URL: https://github.com/apache/carbondata/pull/4018#issuecomment-736731895
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] kunal642 commented on pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and meta entry when there is no update/insert data
Posted by GitBox <gi...@apache.org>.
kunal642 commented on pull request #4018:
URL: https://github.com/apache/carbondata/pull/4018#issuecomment-764338208
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and meta entry when there is no update/insert data
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4018:
URL: https://github.com/apache/carbondata/pull/4018#issuecomment-763434195
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5318/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and meta entry when there is no update/insert data
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4018:
URL: https://github.com/apache/carbondata/pull/4018#issuecomment-737120401
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5018/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and meta entry when there is no update/insert data
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4018:
URL: https://github.com/apache/carbondata/pull/4018#issuecomment-737051141
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3257/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] asfgit closed pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and meta entry when there is no update/insert data
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4018:
URL: https://github.com/apache/carbondata/pull/4018
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] akashrn5 commented on pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and entry to table status when there is no update
Posted by GitBox <gi...@apache.org>.
akashrn5 commented on pull request #4018:
URL: https://github.com/apache/carbondata/pull/4018#issuecomment-734778992
> @akashrn5 Does insert from an empty table have the same behavior?
You are right @kunal642 , thanks for pointing out, i will handle for that also and push
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and meta entry when there is no update/insert data
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4018:
URL: https://github.com/apache/carbondata/pull/4018#issuecomment-736705103
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4998/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] kunal642 commented on pull request #4018: [CARBONDATA-4055]Fix creation of empty segment directory and meta entry when there is no update/insert data
Posted by GitBox <gi...@apache.org>.
kunal642 commented on pull request #4018:
URL: https://github.com/apache/carbondata/pull/4018#issuecomment-764338208
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org