You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/16 07:53:32 UTC

[GitHub] [incubator-shardingsphere] kimmking opened a new pull request #4328: add profile releaseCN to use local node&cnpm

kimmking opened a new pull request #4328: add profile releaseCN to use local node&cnpm
URL: https://github.com/apache/incubator-shardingsphere/pull/4328
 
 
   
   Changes proposed in this pull request:
   - add profile releaseCN to use local node&cnpm
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4328: add profile releaseCN to use local node&cnpm

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4328: add profile releaseCN to use local node&cnpm
URL: https://github.com/apache/incubator-shardingsphere/pull/4328#issuecomment-586680569
 
 
   ## Pull Request Test Coverage Report for [Build 1753](https://coveralls.io/builds/28757302)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * **2** unchanged lines in **1** file lost coverage.
   * Overall coverage increased (+**0.01%**) to **59.119%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28757302/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L74) | 2 | 80.0% |
   <!-- | **Total:** | **2** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28757302/badge)](https://coveralls.io/builds/28757302) |
   | :-- | --: |
   | Change from base [Build 9574](https://coveralls.io/builds/28756767): |  0.01% |
   | Covered Lines: | 11086 |
   | Relevant Lines: | 18752 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4328: add profile releaseCN to use local node&cnpm

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4328: add profile releaseCN to use local node&cnpm
URL: https://github.com/apache/incubator-shardingsphere/pull/4328#issuecomment-586680569
 
 
   ## Pull Request Test Coverage Report for [Build 9583](https://coveralls.io/builds/28759246)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * **3** unchanged lines in **1** file lost coverage.
   * Overall coverage decreased (**-0.005%**) to **57.681%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28759246/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L65) | 3 | 76.0% |
   <!-- | **Total:** | **3** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28759246/badge)](https://coveralls.io/builds/28759246) |
   | :-- | --: |
   | Change from base [Build 866](https://coveralls.io/builds/28758055): |  -0.005% |
   | Covered Lines: | 11084 |
   | Relevant Lines: | 19216 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] cherrylzhao commented on a change in pull request #4328: add profile releaseCN to use local node&cnpm

Posted by GitBox <gi...@apache.org>.
cherrylzhao commented on a change in pull request #4328: add profile releaseCN to use local node&cnpm
URL: https://github.com/apache/incubator-shardingsphere/pull/4328#discussion_r379884742
 
 

 ##########
 File path: shardingsphere-ui/shardingsphere-ui-distribution/shardingsphere-ui-src-distribution/pom.xml
 ##########
 @@ -44,6 +44,9 @@
     <profiles>
         <profile>
             <id>release</id>
+            <activation>
 
 Review comment:
   if we make activation=true distribution will happed every time, I think we should delete it

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #4328: add profile releaseCN to use local node&cnpm

Posted by GitBox <gi...@apache.org>.
kimmking commented on a change in pull request #4328: add profile releaseCN to use local node&cnpm
URL: https://github.com/apache/incubator-shardingsphere/pull/4328#discussion_r379899187
 
 

 ##########
 File path: shardingsphere-ui/shardingsphere-ui-frontend/pom.xml
 ##########
 @@ -31,63 +31,120 @@
         <npm.version>5.6.0</npm.version>
     </properties>
 
-    <build>
+  <profiles>
+    <profile>
+      <id>release</id>
+      <activation>
+        <activeByDefault>true</activeByDefault>
+      </activation>
+      <build>
         <plugins>
-            <plugin>
-                <groupId>com.github.eirslett</groupId>
-                <artifactId>frontend-maven-plugin</artifactId>
-                <version>${frontend-maven-plugin.version}</version>
-                <executions>
-                    <execution>
-                        <id>install node and npm</id>
-                        <goals>
-                            <goal>install-node-and-npm</goal>
-                        </goals>
-                        <configuration>
-                            <nodeVersion>${node.version}</nodeVersion>
-                            <npmVersion>${npm.version}</npmVersion>
-                        </configuration>
-                    </execution>
-                    <execution>
-                        <id>npm run rimraf</id>
-                        <goals>
-                            <goal>npm</goal>
-                        </goals>
-                        <configuration>
-                            <arguments>run rimraf</arguments>
-                        </configuration>
-                    </execution>
-                    <execution>
-                        <id>npm install</id>
-                        <goals>
-                            <goal>npm</goal>
-                        </goals>
-                        <phase>generate-resources</phase>
-                        <configuration>
-                            <arguments>install</arguments>
-                        </configuration>
-                    </execution>
-                    <execution>
-                        <id>npm run unit</id>
-                        <phase>test</phase>
-                        <goals>
-                            <goal>npm</goal>
-                        </goals>
-                        <configuration>
-                            <arguments>run unit</arguments>
-                        </configuration>
-                    </execution>
-                    <execution>
-                        <id>npm run build</id>
-                        <goals>
-                            <goal>npm</goal>
-                        </goals>
-                        <configuration>
-                            <arguments>run build</arguments>
-                        </configuration>
-                    </execution>
-                </executions>
-            </plugin>
+          <plugin>
+            <groupId>com.github.eirslett</groupId>
+            <artifactId>frontend-maven-plugin</artifactId>
+            <version>${frontend-maven-plugin.version}</version>
+            <executions>
+              <execution>
+                <id>install node and npm</id>
+                <goals>
+                  <goal>install-node-and-npm</goal>
+                </goals>
+                <configuration>
+                  <nodeVersion>${node.version}</nodeVersion>
+                  <npmVersion>${npm.version}</npmVersion>
+                </configuration>
+              </execution>
+              <execution>
+                <id>npm run rimraf</id>
+                <goals>
+                  <goal>npm</goal>
 
 Review comment:
   done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4328: add profile releaseCN to use local node&cnpm

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4328: add profile releaseCN to use local node&cnpm
URL: https://github.com/apache/incubator-shardingsphere/pull/4328#issuecomment-586680569
 
 
   ## Pull Request Test Coverage Report for [Build 9576](https://coveralls.io/builds/28757295)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage remained the same at **59.108%**
   
   ---
   
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28757295/badge)](https://coveralls.io/builds/28757295) |
   | :-- | --: |
   | Change from base [Build 9574](https://coveralls.io/builds/28756767): |  0.0% |
   | Covered Lines: | 11084 |
   | Relevant Lines: | 18752 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4328: add profile releaseCN to use local node&cnpm

Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #4328: add profile releaseCN to use local node&cnpm
URL: https://github.com/apache/incubator-shardingsphere/pull/4328#discussion_r379892560
 
 

 ##########
 File path: shardingsphere-ui/shardingsphere-ui-frontend/pom.xml
 ##########
 @@ -31,63 +31,120 @@
         <npm.version>5.6.0</npm.version>
     </properties>
 
-    <build>
+  <profiles>
+    <profile>
+      <id>release</id>
+      <activation>
+        <activeByDefault>true</activeByDefault>
+      </activation>
+      <build>
         <plugins>
-            <plugin>
-                <groupId>com.github.eirslett</groupId>
-                <artifactId>frontend-maven-plugin</artifactId>
-                <version>${frontend-maven-plugin.version}</version>
-                <executions>
-                    <execution>
-                        <id>install node and npm</id>
-                        <goals>
-                            <goal>install-node-and-npm</goal>
-                        </goals>
-                        <configuration>
-                            <nodeVersion>${node.version}</nodeVersion>
-                            <npmVersion>${npm.version}</npmVersion>
-                        </configuration>
-                    </execution>
-                    <execution>
-                        <id>npm run rimraf</id>
-                        <goals>
-                            <goal>npm</goal>
-                        </goals>
-                        <configuration>
-                            <arguments>run rimraf</arguments>
-                        </configuration>
-                    </execution>
-                    <execution>
-                        <id>npm install</id>
-                        <goals>
-                            <goal>npm</goal>
-                        </goals>
-                        <phase>generate-resources</phase>
-                        <configuration>
-                            <arguments>install</arguments>
-                        </configuration>
-                    </execution>
-                    <execution>
-                        <id>npm run unit</id>
-                        <phase>test</phase>
-                        <goals>
-                            <goal>npm</goal>
-                        </goals>
-                        <configuration>
-                            <arguments>run unit</arguments>
-                        </configuration>
-                    </execution>
-                    <execution>
-                        <id>npm run build</id>
-                        <goals>
-                            <goal>npm</goal>
-                        </goals>
-                        <configuration>
-                            <arguments>run build</arguments>
-                        </configuration>
-                    </execution>
-                </executions>
-            </plugin>
+          <plugin>
+            <groupId>com.github.eirslett</groupId>
+            <artifactId>frontend-maven-plugin</artifactId>
+            <version>${frontend-maven-plugin.version}</version>
+            <executions>
+              <execution>
+                <id>install node and npm</id>
+                <goals>
+                  <goal>install-node-and-npm</goal>
+                </goals>
+                <configuration>
+                  <nodeVersion>${node.version}</nodeVersion>
+                  <npmVersion>${npm.version}</npmVersion>
+                </configuration>
+              </execution>
+              <execution>
+                <id>npm run rimraf</id>
+                <goals>
+                  <goal>npm</goal>
 
 Review comment:
   The indent of xml is incorrect.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4328: add profile releaseCN to use local node&cnpm

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4328: add profile releaseCN to use local node&cnpm
URL: https://github.com/apache/incubator-shardingsphere/pull/4328#issuecomment-586680573
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4328?src=pr&el=h1) Report
   > Merging [#4328](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4328?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/0438ce9d700c672fb7fa5382220490f71d9fe3fc?src=pr&el=desc) will **increase** coverage by `0.05%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4328/graphs/tree.svg?width=650&token=ZvlXpWa7so&height=150&src=pr)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4328?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4328      +/-   ##
   ============================================
   + Coverage      55.5%   55.56%   +0.05%     
     Complexity      352      352              
   ============================================
     Files          1032     1040       +8     
     Lines         18723    18752      +29     
     Branches       3420     3418       -2     
   ============================================
   + Hits          10393    10419      +26     
   - Misses         7675     7678       +3     
     Partials        655      655
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4328?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../orchestration/center/instance/ApolloInstance.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4328/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci1hcG9sbG8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL29yY2hlc3RyYXRpb24vY2VudGVyL2luc3RhbmNlL0Fwb2xsb0luc3RhbmNlLmphdmE=) | `54.05% <0%> (-1.51%)` | `0% <0%> (ø)` | |
   | [.../center/instance/wrapper/ApolloOpenApiWrapper.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4328/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci1hcG9sbG8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL29yY2hlc3RyYXRpb24vY2VudGVyL2luc3RhbmNlL3dyYXBwZXIvQXBvbGxvT3BlbkFwaVdyYXBwZXIuamF2YQ==) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
   | [...n/center/instance/wrapper/ApolloConfigWrapper.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4328/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci1hcG9sbG8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL29yY2hlc3RyYXRpb24vY2VudGVyL2luc3RhbmNlL3dyYXBwZXIvQXBvbGxvQ29uZmlnV3JhcHBlci5qYXZh) | `100% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
   | [...internal/registry/ShardingOrchestrationFacade.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4328/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL29yY2hlc3RyYXRpb24vaW50ZXJuYWwvcmVnaXN0cnkvU2hhcmRpbmdPcmNoZXN0cmF0aW9uRmFjYWRlLmphdmE=) | `85.1% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
   | [...rchestration/center/instance/ApolloProperties.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4328/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci1hcG9sbG8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL29yY2hlc3RyYXRpb24vY2VudGVyL2luc3RhbmNlL0Fwb2xsb1Byb3BlcnRpZXMuamF2YQ==) | `100% <0%> (ø)` | `0% <0%> (?)` | |
   | [...estration/center/instance/NacosPropertiesEnum.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4328/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci1uYWNvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvb3JjaGVzdHJhdGlvbi9jZW50ZXIvaW5zdGFuY2UvTmFjb3NQcm9wZXJ0aWVzRW51bS5qYXZh) | `100% <0%> (ø)` | `0% <0%> (?)` | |
   | [...ation/center/instance/ZookeeperPropertiesEnum.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4328/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci16b29rZWVwZXItY3VyYXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvb3JjaGVzdHJhdGlvbi9jZW50ZXIvaW5zdGFuY2UvWm9va2VlcGVyUHJvcGVydGllc0VudW0uamF2YQ==) | `100% <0%> (ø)` | `0% <0%> (?)` | |
   | [...orchestration/center/instance/NacosProperties.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4328/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci1uYWNvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvb3JjaGVzdHJhdGlvbi9jZW50ZXIvaW5zdGFuY2UvTmFjb3NQcm9wZXJ0aWVzLmphdmE=) | `100% <0%> (ø)` | `0% <0%> (?)` | |
   | [...nstant/properties/OrchestrationPropertiesEnum.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4328/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtdW5kZXJseWluZy9zaGFyZGluZ3NwaGVyZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3VuZGVybHlpbmcvY29tbW9uL2NvbnN0YW50L3Byb3BlcnRpZXMvT3JjaGVzdHJhdGlvblByb3BlcnRpZXNFbnVtLmphdmE=) | `0% <0%> (ø)` | `0% <0%> (?)` | |
   | [...stration/center/instance/ApolloPropertiesEnum.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4328/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci1hcG9sbG8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL29yY2hlc3RyYXRpb24vY2VudGVyL2luc3RhbmNlL0Fwb2xsb1Byb3BlcnRpZXNFbnVtLmphdmE=) | `100% <0%> (ø)` | `0% <0%> (?)` | |
   | ... and [4 more](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4328/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4328?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4328?src=pr&el=footer). Last update [0438ce9...bedcac2](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4328?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] cherrylzhao commented on a change in pull request #4328: add profile releaseCN to use local node&cnpm

Posted by GitBox <gi...@apache.org>.
cherrylzhao commented on a change in pull request #4328: add profile releaseCN to use local node&cnpm
URL: https://github.com/apache/incubator-shardingsphere/pull/4328#discussion_r379884734
 
 

 ##########
 File path: shardingsphere-ui/shardingsphere-ui-distribution/shardingsphere-ui-src-distribution/pom.xml
 ##########
 @@ -44,6 +44,9 @@
     <profiles>
         <profile>
             <id>release</id>
+            <activation>
 
 Review comment:
   if we make activation=true distribution will happed every time

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4328: add profile releaseCN to use local node&cnpm

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4328: add profile releaseCN to use local node&cnpm
URL: https://github.com/apache/incubator-shardingsphere/pull/4328#issuecomment-586680569
 
 
   ## Pull Request Test Coverage Report for [Build 9580](https://coveralls.io/builds/28758353)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * **3** unchanged lines in **1** file lost coverage.
   * Overall coverage decreased (**-0.005%**) to **57.681%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28758353/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L65) | 3 | 76.0% |
   <!-- | **Total:** | **3** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28758353/badge)](https://coveralls.io/builds/28758353) |
   | :-- | --: |
   | Change from base [Build 866](https://coveralls.io/builds/28758055): |  -0.005% |
   | Covered Lines: | 11084 |
   | Relevant Lines: | 19216 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] cherrylzhao commented on a change in pull request #4328: add profile releaseCN to use local node&cnpm

Posted by GitBox <gi...@apache.org>.
cherrylzhao commented on a change in pull request #4328: add profile releaseCN to use local node&cnpm
URL: https://github.com/apache/incubator-shardingsphere/pull/4328#discussion_r379884584
 
 

 ##########
 File path: shardingsphere-ui/shardingsphere-ui-distribution/shardingsphere-ui-bin-distribution/pom.xml
 ##########
 @@ -62,6 +62,34 @@
     <profiles>
         <profile>
             <id>release</id>
 
 Review comment:
   release and releaseCN is same, shall we keep only one?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] kimmking commented on issue #4328: add profile releaseCN to use local node&cnpm

Posted by GitBox <gi...@apache.org>.
kimmking commented on issue #4328: add profile releaseCN to use local node&cnpm
URL: https://github.com/apache/incubator-shardingsphere/pull/4328#issuecomment-586700342
 
 
   only add profile in shardingsphere-ui-frontend pom.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4328: add profile releaseCN to use local node&cnpm

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4328: add profile releaseCN to use local node&cnpm
URL: https://github.com/apache/incubator-shardingsphere/pull/4328#issuecomment-586680569
 
 
   ## Pull Request Test Coverage Report for [Build 1760](https://coveralls.io/builds/28759277)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage remained the same at **57.686%**
   
   ---
   
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28759277/badge)](https://coveralls.io/builds/28759277) |
   | :-- | --: |
   | Change from base [Build 866](https://coveralls.io/builds/28758055): |  0.0% |
   | Covered Lines: | 11085 |
   | Relevant Lines: | 19216 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4328: add profile releaseCN to use local node&cnpm

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4328: add profile releaseCN to use local node&cnpm
URL: https://github.com/apache/incubator-shardingsphere/pull/4328#issuecomment-586680569
 
 
   ## Pull Request Test Coverage Report for [Build 1761](https://coveralls.io/builds/28759337)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage remained the same at **57.686%**
   
   ---
   
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28759337/badge)](https://coveralls.io/builds/28759337) |
   | :-- | --: |
   | Change from base [Build 866](https://coveralls.io/builds/28758055): |  0.0% |
   | Covered Lines: | 11085 |
   | Relevant Lines: | 19216 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] cherrylzhao merged pull request #4328: add profile releaseCN to use local node&cnpm

Posted by GitBox <gi...@apache.org>.
cherrylzhao merged pull request #4328: add profile releaseCN to use local node&cnpm
URL: https://github.com/apache/incubator-shardingsphere/pull/4328
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services