You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by anenviousguest <gi...@git.apache.org> on 2014/08/18 00:37:32 UTC
[GitHub] tomcat-maven-plugin pull request: MTOMCAT-234 (Tomcat8 plugin is n...
GitHub user anenviousguest opened a pull request:
https://github.com/apache/tomcat-maven-plugin/pull/9
MTOMCAT-234 (Tomcat8 plugin is now working) + MTOMCAT-274
Hi,
Don't know how to split this request into two separate ones. Anyway, I finally got Tomcat 8 plugin passing integration tests.
One thing: it seems that integration tests start embedded Tomcat with http-nio protocol handler, rather than with http-bio, which means that assertion statements had to be changed accordingly.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/anenviousguest/tomcat-maven-plugin tc8.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tomcat-maven-plugin/pull/9.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #9
----
commit a2e146c785e7f1c964b5d875c78a0bea034dfc78
Author: Vladislav Ponomarev <po...@gmail.com>
Date: 2014-08-15T08:12:52Z
1. Fix: MTOMCAT-274 (updated maven-war-plugin version).
2. Fix: access_log.* files excluded from apache-rat-plugin configuration. These are generated during Tomcat run and should not be checked.
commit 952e3d3f9e0c7d1fcb86cc1594f74ebb3648092e
Author: Vladislav Ponomarev <po...@gmail.com>
Date: 2014-08-17T13:26:33Z
Fix: MTOMCAT-234
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] tomcat-maven-plugin pull request: MTOMCAT-234 (Tomcat8 plugin is n...
Posted by anenviousguest <gi...@git.apache.org>.
Github user anenviousguest closed the pull request at:
https://github.com/apache/tomcat-maven-plugin/pull/9
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org