[GitHub] [airflow] kunalyogenshah edited a comment on issue #5139: [AIRFLOW-4360][WIP] Add performance metrics for Webserver UI.

[GitBox <gi...@apache.org>]

kunalyogenshah edited a comment on issue #5139: [AIRFLOW-4360][WIP] Add performance metrics for Webserver UI.
URL: https://github.com/apache/airflow/pull/5139#issuecomment-485254447
 
 
   A little delayed response, but some thoughts below. Thanks for the feedback!
    - Yeah this PR mainly focuses on the server side metrics. More specifically, it adds metrics for server data fetching / processing for 2 of the most used client side views (more to follow later).
    - JS does play a major role in rendering, but unless there are AJAX server side calls in JS, most of them are usually rendering, which for now feels like the smaller of the bottlenecks, unless the code goes wrong somewhere? Ideally we should track both metrics eventually as mentioned above. One way I considered was using a statsd-client module available for java script as well using NPM. But that might merit a longer proposal.
    - I agree with the idea that the errors should be collected and monitored, and that will effectively be done the same way the scheduler Statsd metrics are monitored today right? The aim for the metrics here is to provide regression test and alerts for the UI before clients have to report it.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services