You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/04/22 10:27:53 UTC

[GitHub] [incubator-doris] xinghuayu007 opened a new pull request #5693: [Config]Add switch to demonstrate tablet meta content of byte type for debug

xinghuayu007 opened a new pull request #5693:
URL: https://github.com/apache/incubator-doris/pull/5693


   ## Proposed changes
   
   When get a table meta content by a http interface, Doris will transfer tablet meta into json string. If a field is byte type, it wiil be enconded into base64 code, like Pic1 Field `default`. It is unreadble for debug. Therefore we add a config `enable_byte_to_base64` to support not transfer byte into base64 code. 
   
   ## Types of changes
   
   What types of changes does your code introduce to Doris?
   _Put an `x` in the boxes that apply_
   
   - [ ] Bugfix (non-breaking change which fixes an issue)
   - [x] New feature (non-breaking change which adds functionality)
   - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
   - [ ] Documentation Update (if none of the other choices apply)
   - [ ] Code refactor (Modify the code structure, format the code, etc...)
   
   ## Checklist
   
   _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
   
   - [ ] I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
   - [ ] Compiling and unit tests pass locally with my changes
   - [ ] I have added tests that prove my fix is effective or that my feature works
   - [ ] If these changes need document changes, I have updated the document
   - [ ] Any dependent changes have been merged
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] acelyc111 commented on a change in pull request #5693: [Config]Add switch to demonstrate tablet meta content of byte type for debug

Posted by GitBox <gi...@apache.org>.
acelyc111 commented on a change in pull request #5693:
URL: https://github.com/apache/incubator-doris/pull/5693#discussion_r618487263



##########
File path: be/src/http/action/meta_action.cpp
##########
@@ -63,6 +63,8 @@ Status MetaAction::_handle_header(HttpRequest* req, std::string* json_meta) {
     tablet->generate_tablet_meta_copy(tablet_meta);
     json2pb::Pb2JsonOptions json_options;
     json_options.pretty_json = true;
+    // default value of bytes_to_base64 is true, compatible with previous config
+    json_options.bytes_to_base64 = config::enable_byte_to_base64;

Review comment:
       How about make it as an uri parameter, it would be more flexible?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] xinghuayu007 commented on pull request #5693: [Config]Add uri param to demonstrate tablet meta content of byte type for debug

Posted by GitBox <gi...@apache.org>.
xinghuayu007 commented on pull request #5693:
URL: https://github.com/apache/incubator-doris/pull/5693#issuecomment-826237917


   > Why not just print the readable value? The previous base64 display seems useless.
   
   It has been modified to be default false to disable base64.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] yangzhg merged pull request #5693: [Config]Add uri param to demonstrate tablet meta content of byte type for debug

Posted by GitBox <gi...@apache.org>.
yangzhg merged pull request #5693:
URL: https://github.com/apache/incubator-doris/pull/5693


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] xinghuayu007 commented on a change in pull request #5693: [Config]Add switch to demonstrate tablet meta content of byte type for debug

Posted by GitBox <gi...@apache.org>.
xinghuayu007 commented on a change in pull request #5693:
URL: https://github.com/apache/incubator-doris/pull/5693#discussion_r619014840



##########
File path: be/src/http/action/meta_action.cpp
##########
@@ -63,6 +63,8 @@ Status MetaAction::_handle_header(HttpRequest* req, std::string* json_meta) {
     tablet->generate_tablet_meta_copy(tablet_meta);
     json2pb::Pb2JsonOptions json_options;
     json_options.pretty_json = true;
+    // default value of bytes_to_base64 is true, compatible with previous config
+    json_options.bytes_to_base64 = config::enable_byte_to_base64;

Review comment:
       good idea!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] xinghuayu007 commented on pull request #5693: [Config]Add uri param to demonstrate tablet meta content of byte type for debug

Posted by GitBox <gi...@apache.org>.
xinghuayu007 commented on pull request #5693:
URL: https://github.com/apache/incubator-doris/pull/5693#issuecomment-826237917


   > Why not just print the readable value? The previous base64 display seems useless.
   
   It has been modified to be default false to disable base64.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] acelyc111 commented on a change in pull request #5693: [Config]Add switch to demonstrate tablet meta content of byte type for debug

Posted by GitBox <gi...@apache.org>.
acelyc111 commented on a change in pull request #5693:
URL: https://github.com/apache/incubator-doris/pull/5693#discussion_r618487263



##########
File path: be/src/http/action/meta_action.cpp
##########
@@ -63,6 +63,8 @@ Status MetaAction::_handle_header(HttpRequest* req, std::string* json_meta) {
     tablet->generate_tablet_meta_copy(tablet_meta);
     json2pb::Pb2JsonOptions json_options;
     json_options.pretty_json = true;
+    // default value of bytes_to_base64 is true, compatible with previous config
+    json_options.bytes_to_base64 = config::enable_byte_to_base64;

Review comment:
       How about make it as a uri parameter, it would be more flexible?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] morningman commented on pull request #5693: [Config]Add uri param to demonstrate tablet meta content of byte type for debug

Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #5693:
URL: https://github.com/apache/incubator-doris/pull/5693#issuecomment-825673097


   Why not just print the readable value? The previous base64 display seems useless.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org