You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by ah...@apache.org on 2005/09/04 00:09:27 UTC

svn commit: r267504 - in /maven/maven-1/plugins/trunk/faq: src/plugin-resources/faq.jsl xdocs/changes.xml

Author: aheritier
Date: Sat Sep  3 15:09:21 2005
New Revision: 267504

URL: http://svn.apache.org/viewcvs?rev=267504&view=rev
Log:
The question is like a link because the anchor shouldn't enclose the question.

Modified:
    maven/maven-1/plugins/trunk/faq/src/plugin-resources/faq.jsl
    maven/maven-1/plugins/trunk/faq/xdocs/changes.xml

Modified: maven/maven-1/plugins/trunk/faq/src/plugin-resources/faq.jsl
URL: http://svn.apache.org/viewcvs/maven/maven-1/plugins/trunk/faq/src/plugin-resources/faq.jsl?rev=267504&r1=267503&r2=267504&view=diff
==============================================================================
--- maven/maven-1/plugins/trunk/faq/src/plugin-resources/faq.jsl (original)
+++ maven/maven-1/plugins/trunk/faq/src/plugin-resources/faq.jsl Sat Sep  3 15:09:21 2005
@@ -75,9 +75,7 @@
     <dt class="question">
       <j:set var="_id"><x:expr select="../@id"/></j:set>
       <j:set var="_id"><doc:escapeNameToken value="${_id}"/></j:set>
-      <a name="${_id}">
-        <jsl:applyTemplates trim="true" />
-      </a>
+      <a name="${_id}"/><jsl:applyTemplates trim="true" />
     </dt>
   </jsl:template>
 

Modified: maven/maven-1/plugins/trunk/faq/xdocs/changes.xml
URL: http://svn.apache.org/viewcvs/maven/maven-1/plugins/trunk/faq/xdocs/changes.xml?rev=267504&r1=267503&r2=267504&view=diff
==============================================================================
--- maven/maven-1/plugins/trunk/faq/xdocs/changes.xml (original)
+++ maven/maven-1/plugins/trunk/faq/xdocs/changes.xml Sat Sep  3 15:09:21 2005
@@ -22,7 +22,8 @@
     <author email="dion@apache.org">dIon Gillard</author>
   </properties>
   <body>
-    <release version="1.4.1-SNAPSHOT" date="in CVS">
+    <release version="1.4.1-SNAPSHOT" date="in SVN">
+      <action dev="aheritier" type="fix">The question is like a link because the anchor shouldn't enclose the question.</action>
       <action dev="aheritier" type="fix" issue="MPFAQ-11" due-to="Lukas Theussl">Questions' font is same size or smaller than answers' one. Xdoc plugin &lt; 1.9.2 required.</action>
       <action dev="dion" type="update" issue="MPFAQ-14" due-to="florent ramiere">Document .fml extension requirement</action>
     </release>



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r267504 - in /maven/maven-1/plugins/trunk/faq: src/plugin-resources/faq.jsl xdocs/changes.xml

Posted by Arnaud HERITIER <ah...@gmail.com>.
Yes, I'm ok to add a custom style.
The problem with this bug was that a user tried to click to a question and 
had no result.

Arnaud

On 9/4/05, Lukas Theussl <th...@triumf.ca> wrote:
> 
> Arnaud HERITIER wrote:
> 
> >You think ?
> >I though it was a bug :-(
> >I don't like 'fake' links.
> >It could be a feature if the color scheme were different?
> >What the others think ?
> >
> >
> It probably was a bug but I liked it :-) .
> We could add the same effect (with customized color schemes) with some
> css settings but as it is we have it for free...
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
> 
>

Re: svn commit: r267504 - in /maven/maven-1/plugins/trunk/faq: src/plugin-resources/faq.jsl xdocs/changes.xml

Posted by Lukas Theussl <th...@triumf.ca>.
Arnaud HERITIER wrote:

>You think ?
>I though it was a bug :-(
>I don't like 'fake' links.
>It could be a feature if the color scheme were different?
>What the others think ?
>  
>
It probably was a bug but I liked it :-) .
We could add the same effect (with customized color schemes) with some 
css settings but as it is we have it for free...

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r267504 - in /maven/maven-1/plugins/trunk/faq: src/plugin-resources/faq.jsl xdocs/changes.xml

Posted by Arnaud HERITIER <ah...@gmail.com>.
You think ?
I though it was a bug :-(
I don't like 'fake' links.
It could be a feature if the color scheme were different?
What the others think ?

Arnaud

On 9/4/05, Lukas Theussl <th...@triumf.ca> wrote:
> 
> I thought that this was a feature? I liked the 'hover' effect, ie the
> questions turning blue when you moved the mouse over them.
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
> 
>

Re: svn commit: r267504 - in /maven/maven-1/plugins/trunk/faq: src/plugin-resources/faq.jsl xdocs/changes.xml

Posted by Lukas Theussl <th...@triumf.ca>.
I thought that this was a feature? I liked the 'hover' effect, ie the 
questions turning blue when you moved the mouse over them.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org