You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by lammmmmmm <gi...@git.apache.org> on 2017/04/30 05:20:42 UTC
[GitHub] incubator-weex pull request #303: Update iconfont.vue
GitHub user lammmmmmm opened a pull request:
https://github.com/apache/incubator-weex/pull/303
Update iconfont.vue
Make it work for android
change to Camel-Case can make it work in android
<!--
Notes: Weex will move into Apache Software Foundation (ASF) on Feb 24 2017.
Our new GitHub repo is https://github.com/apache/incubator-weex
After Feb 24 2017, we only accept pull requests from https://github.com/apache/incubator-weex
Thank you for your support.
----
\u6ce8\u610f\uff1aWeex \u5c06\u4e8e 2017-02-24 \u8fc1\u79fb\u81f3 Apache \u57fa\u91d1\u4f1a
\u5c4a\u65f6\u6211\u4eec\u4f1a\u4f7f\u7528\u65b0\u7684 GitHub \u4ed3\u5e93\uff1ahttps://github.com/apache/incubator-weex \u5e76\u5728\u90a3\u91cc\u7ee7\u7eed\u63a5\u53d7\u5927\u5bb6\u7684 pull request\u3002
\u66f4\u591a\u8be6\u60c5\u8bf7\u5173\u6ce8\uff1ahttps://github.com/weexteam/article/issues/130
\u611f\u8c22\u7406\u89e3\u548c\u652f\u6301
-->
<!--
It's ***RECOMMENDED*** to submit typo fix, new demo and tiny bugfix to `dev` branch. New feature and other modifications can be submitted to "domain" branch including `ios`, `android`, `jsfm`, `html5`.
See [Branch Strategy](https://github.com/alibaba/weex/blob/dev/CONTRIBUTING.md#branch-management) for more detail.
----
\uff08\u8bf7\u5728***\u63d0\u4ea4***\u524d\u5220\u9664\u8fd9\u6bb5\u63cf\u8ff0\uff09
\u9519\u522b\u5b57\u4fee\u6539\u3001\u65b0 demo\u3001\u8f83\u5c0f\u7684 bugfix \u90fd\u53ef\u4ee5\u76f4\u63a5\u63d0\u5230 `dev` \u5206\u652f\uff1b\u65b0\u9700\u6c42\u4ee5\u53ca\u4efb\u4f55\u4f60\u4e0d\u786e\u5b9a\u5f71\u54cd\u9762\u7684\u6539\u52a8\uff0c\u8bf7\u63d0\u4ea4\u5230\u5bf9\u5e94\u201c\u9886\u57df\u201d\u7684\u5206\u652f\uff08`ios`\u3001`android`\u3001`jsfm`\u3001`html5`\uff09\u3002
\u67e5\u770b\u5b8c\u6574\u7684[\u5206\u652f\u7b56\u7565 (\u82f1\u6587)](https://github.com/alibaba/weex/blob/dev/CONTRIBUTING.md#branch-management)\u3002
-->
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lammmmmmm/incubator-weex patch-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/303.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #303
----
commit 8b2f3e20cc6adf025a59518ce4f3ce295ebdf5fa
Author: lammmmmmm <la...@gmail.com>
Date: 2017-04-30T05:20:08Z
Update iconfont.vue
Make it work for android
change to Camel-Case can make it work in android
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #303: Update iconfont.vue
Posted by acton393 <gi...@git.apache.org>.
Github user acton393 commented on the issue:
https://github.com/apache/incubator-weex/pull/303
hi @lammmmmmm I open a pull request to add more case about iconfont #350 , I test it on android、iOS and h5 platform , and it works well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #303: Update iconfont.vue
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/303
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true" data-kind="Message">
1 Message
</th>
</tr>
</thead>
<tbody>
<tr>
<td>:book:</td>
<td data-sticky="false">Executed 53 tests, with 0 failures (0 unexpected) in 46.534 (46.593) seconds</td>
</tr>
</tbody>
</table>
<p align="right" data-meta="generated_by_danger">
Generated by :no_entry_sign: <a href="http://danger.systems/">danger</a>
</p>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #303: Update iconfont.vue
Posted by acton393 <gi...@git.apache.org>.
Github user acton393 commented on the issue:
https://github.com/apache/incubator-weex/pull/303
hi @lammmmmmm the target branch should be `dev` branch, please check it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #303: Update iconfont.vue
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/303
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true" data-kind="Message">
1 Message
</th>
</tr>
</thead>
<tbody>
<tr>
<td>:book:</td>
<td data-sticky="false">Executed 53 tests, with 0 failures (0 unexpected) in 45.292 (45.353) seconds</td>
</tr>
</tbody>
</table>
<p align="right" data-meta="generated_by_danger">
Generated by :no_entry_sign: <a href="http://danger.systems/">danger</a>
</p>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #303: Update iconfont.vue
Posted by gurisxie <gi...@git.apache.org>.
Github user gurisxie commented on the issue:
https://github.com/apache/incubator-weex/pull/303
hi, @lammmmmmm , thanks a lot for your pr.
We have fix this bug in master branch by native code.
You can have a try, and close this pr [here](https://github.com/apache/incubator-weex/pull/303). Thanks a lot.
---
[GitHub] incubator-weex pull request #303: Update iconfont.vue
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-weex/pull/303
---