You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@systemml.apache.org by de...@apache.org on 2016/12/06 21:13:02 UTC
incubator-systemml git commit: [SYSTEMML-1133] Remove unused
constants from project
Repository: incubator-systemml
Updated Branches:
refs/heads/master 11381c129 -> ca403ff11
[SYSTEMML-1133] Remove unused constants from project
Remove unused constants.
Add TODOs to investigate other unused constants.
Closes #299.
Project: http://git-wip-us.apache.org/repos/asf/incubator-systemml/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-systemml/commit/ca403ff1
Tree: http://git-wip-us.apache.org/repos/asf/incubator-systemml/tree/ca403ff1
Diff: http://git-wip-us.apache.org/repos/asf/incubator-systemml/diff/ca403ff1
Branch: refs/heads/master
Commit: ca403ff113fd26519f07079f2f673023eaf6adc7
Parents: 11381c1
Author: Deron Eriksson <de...@us.ibm.com>
Authored: Tue Dec 6 13:09:55 2016 -0800
Committer: Deron Eriksson <de...@us.ibm.com>
Committed: Tue Dec 6 13:09:55 2016 -0800
----------------------------------------------------------------------
src/main/java/org/apache/sysml/api/MLMatrix.java | 3 ---
src/main/java/org/apache/sysml/hops/Hop.java | 2 --
.../java/org/apache/sysml/hops/OptimizerUtils.java | 1 -
src/main/java/org/apache/sysml/lops/AppendCP.java | 4 ++--
src/main/java/org/apache/sysml/lops/Checkpoint.java | 1 -
.../org/apache/sysml/parser/LanguageException.java | 1 -
.../runtime/controlprogram/ParForProgramBlock.java | 1 -
.../controlprogram/parfor/ProgramConverter.java | 4 +---
.../controlprogram/parfor/opt/CostEstimator.java | 2 +-
.../controlprogram/parfor/opt/OptimizerRuleBased.java | 2 +-
.../controlprogram/parfor/opt/PerfTestTool.java | 5 -----
.../sysml/runtime/instructions/Instruction.java | 1 -
.../runtime/matrix/mapred/MRConfigurationNames.java | 3 +--
.../runtime/matrix/mapred/MRJobConfiguration.java | 14 +++-----------
.../sysml/runtime/matrix/mapred/MapperBase.java | 5 -----
.../apache/sysml/runtime/transform/GenTfMtdMR.java | 2 --
.../org/apache/sysml/runtime/util/UtilFunctions.java | 1 -
.../java/org/apache/sysml/udf/PackageFunction.java | 7 +------
18 files changed, 10 insertions(+), 49 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-systemml/blob/ca403ff1/src/main/java/org/apache/sysml/api/MLMatrix.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/sysml/api/MLMatrix.java b/src/main/java/org/apache/sysml/api/MLMatrix.java
index b91d09b..6019c5a 100644
--- a/src/main/java/org/apache/sysml/api/MLMatrix.java
+++ b/src/main/java/org/apache/sysml/api/MLMatrix.java
@@ -21,8 +21,6 @@ package org.apache.sysml.api;
import java.io.IOException;
import java.util.List;
-import org.apache.commons.logging.Log;
-import org.apache.commons.logging.LogFactory;
import org.apache.spark.api.java.JavaPairRDD;
import org.apache.spark.rdd.RDD;
import org.apache.spark.sql.DataFrame;
@@ -66,7 +64,6 @@ import scala.Tuple2;
*/
public class MLMatrix extends DataFrame {
private static final long serialVersionUID = -7005940673916671165L;
- protected static final Log LOG = LogFactory.getLog(DMLScript.class.getName());
protected MatrixCharacteristics mc = null;
protected MLContext ml = null;
http://git-wip-us.apache.org/repos/asf/incubator-systemml/blob/ca403ff1/src/main/java/org/apache/sysml/hops/Hop.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/sysml/hops/Hop.java b/src/main/java/org/apache/sysml/hops/Hop.java
index 6ad21e7..362ee35 100644
--- a/src/main/java/org/apache/sysml/hops/Hop.java
+++ b/src/main/java/org/apache/sysml/hops/Hop.java
@@ -54,8 +54,6 @@ public abstract class Hop
protected static final Log LOG = LogFactory.getLog(Hop.class.getName());
public static final long CPThreshold = 2000;
- protected static final boolean BREAKONSCALARS = false;
- protected static final boolean SPLITLARGEMATRIXMULT = true;
public enum VisitStatus {
DONE,
http://git-wip-us.apache.org/repos/asf/incubator-systemml/blob/ca403ff1/src/main/java/org/apache/sysml/hops/OptimizerUtils.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/sysml/hops/OptimizerUtils.java b/src/main/java/org/apache/sysml/hops/OptimizerUtils.java
index be10674..8aa426f 100644
--- a/src/main/java/org/apache/sysml/hops/OptimizerUtils.java
+++ b/src/main/java/org/apache/sysml/hops/OptimizerUtils.java
@@ -91,7 +91,6 @@ public class OptimizerUtils
public static final long INT_SIZE = 4;
public static final long CHAR_SIZE = 1;
public static final long BOOLEAN_SIZE = 1;
- public static final double BIT_SIZE = (double)1/8;
public static final double INVALID_SIZE = -1d; // memory estimate not computed
//constants for valid CP matrix dimension sizes / nnz (dense/sparse)
http://git-wip-us.apache.org/repos/asf/incubator-systemml/blob/ca403ff1/src/main/java/org/apache/sysml/lops/AppendCP.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/sysml/lops/AppendCP.java b/src/main/java/org/apache/sysml/lops/AppendCP.java
index dc62ef3..d527f45 100644
--- a/src/main/java/org/apache/sysml/lops/AppendCP.java
+++ b/src/main/java/org/apache/sysml/lops/AppendCP.java
@@ -27,8 +27,8 @@ import org.apache.sysml.parser.Expression.*;
public class AppendCP extends Lop
{
- public static final String OPCODE = "append";
-
+ public static final String OPCODE = "append"; // TODO investigate unused constant
+
private boolean _cbind = true;
public AppendCP(Lop input1, Lop input2, Lop input3, DataType dt, ValueType vt, boolean cbind)
http://git-wip-us.apache.org/repos/asf/incubator-systemml/blob/ca403ff1/src/main/java/org/apache/sysml/lops/Checkpoint.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/sysml/lops/Checkpoint.java b/src/main/java/org/apache/sysml/lops/Checkpoint.java
index aca91b1..84e1825 100644
--- a/src/main/java/org/apache/sysml/lops/Checkpoint.java
+++ b/src/main/java/org/apache/sysml/lops/Checkpoint.java
@@ -45,7 +45,6 @@ public class Checkpoint extends Lop
public static final StorageLevel DEFAULT_STORAGE_LEVEL = StorageLevel.MEMORY_AND_DISK();
public static final StorageLevel SER_STORAGE_LEVEL = StorageLevel.MEMORY_AND_DISK_SER();
public static final boolean CHECKPOINT_SPARSE_CSR = true;
- public static final String STORAGE_LEVEL = "storage.level";
private StorageLevel _storageLevel;
http://git-wip-us.apache.org/repos/asf/incubator-systemml/blob/ca403ff1/src/main/java/org/apache/sysml/parser/LanguageException.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/sysml/parser/LanguageException.java b/src/main/java/org/apache/sysml/parser/LanguageException.java
index 8ef06f1..9fad951 100644
--- a/src/main/java/org/apache/sysml/parser/LanguageException.java
+++ b/src/main/java/org/apache/sysml/parser/LanguageException.java
@@ -53,7 +53,6 @@ public class LanguageException extends DMLException
public static final String UNSUPPORTED_EXPRESSION = "Unsupported Expression";
public static final String INVALID_PARAMETERS = "Invalid Parameters";
public static final String UNSUPPORTED_PARAMETERS = "Unsupported Parameters";
- public static final String GENERIC_ERROR = "Language Syntax Error";
}
}
http://git-wip-us.apache.org/repos/asf/incubator-systemml/blob/ca403ff1/src/main/java/org/apache/sysml/runtime/controlprogram/ParForProgramBlock.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/sysml/runtime/controlprogram/ParForProgramBlock.java b/src/main/java/org/apache/sysml/runtime/controlprogram/ParForProgramBlock.java
index 91ee79e..4d7b059 100644
--- a/src/main/java/org/apache/sysml/runtime/controlprogram/ParForProgramBlock.java
+++ b/src/main/java/org/apache/sysml/runtime/controlprogram/ParForProgramBlock.java
@@ -221,7 +221,6 @@ public class ParForProgramBlock extends ForProgramBlock
public static final int MAX_RETRYS_ON_ERROR = 1;
public static final boolean FORCE_CP_ON_REMOTE_MR = true; // compile body to CP if exec type forced to MR
public static final boolean LIVEVAR_AWARE_EXPORT = true; //export only read variables according to live variable analysis
- public static final boolean LIVEVAR_AWARE_CLEANUP = true; //cleanup pinned variables according to live variable analysis
public static final boolean RESET_RECOMPILATION_FLAGs = true;
public static final String PARFOR_FNAME_PREFIX = "/parfor/";
http://git-wip-us.apache.org/repos/asf/incubator-systemml/blob/ca403ff1/src/main/java/org/apache/sysml/runtime/controlprogram/parfor/ProgramConverter.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/sysml/runtime/controlprogram/parfor/ProgramConverter.java b/src/main/java/org/apache/sysml/runtime/controlprogram/parfor/ProgramConverter.java
index c7f54c3..bc6370d 100644
--- a/src/main/java/org/apache/sysml/runtime/controlprogram/parfor/ProgramConverter.java
+++ b/src/main/java/org/apache/sysml/runtime/controlprogram/parfor/ProgramConverter.java
@@ -108,7 +108,6 @@ public class ProgramConverter
public static final String LEVELIN = "\u23a8"; //variant of left curly bracket; "\u007b"; //"{";
public static final String LEVELOUT = "\u23ac"; //variant of right curly bracket; "\u007d"; //"}";
public static final String EMPTY = "null";
- public static final String EXT_FUNCTION = "extfunct";
//public static final String CP_ROOT_THREAD_SEPARATOR = "/";//File.separator;
public static final String CP_ROOT_THREAD_ID = "_t0";
@@ -148,8 +147,7 @@ public class ProgramConverter
public static final String NOT_SUPPORTED_MR_PARFOR = "Not supported: Nested ParFOR REMOTE_MR due to possible deadlocks." +
"(LOCAL can be used for innner ParFOR)";
public static final String NOT_SUPPORTED_PB = "Not supported: type of program block";
- public static final String NOT_SUPPORTED_EXECUTION_CONTEXT = "Parsing of external system execution context not supported yet.";
-
+ public static final String NOT_SUPPORTED_EXECUTION_CONTEXT = "Parsing of external system execution context not supported yet."; // TODO investigate unused constant
////////////////////////////////
// CREATION of DEEP COPIES
http://git-wip-us.apache.org/repos/asf/incubator-systemml/blob/ca403ff1/src/main/java/org/apache/sysml/runtime/controlprogram/parfor/opt/CostEstimator.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/sysml/runtime/controlprogram/parfor/opt/CostEstimator.java b/src/main/java/org/apache/sysml/runtime/controlprogram/parfor/opt/CostEstimator.java
index bdf8884..476522a 100644
--- a/src/main/java/org/apache/sysml/runtime/controlprogram/parfor/opt/CostEstimator.java
+++ b/src/main/java/org/apache/sysml/runtime/controlprogram/parfor/opt/CostEstimator.java
@@ -46,7 +46,7 @@ public abstract class CostEstimator
public static final long FACTOR_NUM_ITERATIONS = 10; //default problem size
public static final double DEFAULT_TIME_ESTIMATE = 5; //default execution time: 5ms
public static final double DEFAULT_MEM_ESTIMATE_CP = 1024; //default memory consumption: 1KB
- public static final double DEFAULT_MEM_ESTIMATE_MR = 10*1024*1024; //default memory consumption: 20MB
+ public static final double DEFAULT_MEM_ESTIMATE_MR = 10*1024*1024; //default memory consumption: 20MB // TODO investigate unused constant
/**
http://git-wip-us.apache.org/repos/asf/incubator-systemml/blob/ca403ff1/src/main/java/org/apache/sysml/runtime/controlprogram/parfor/opt/OptimizerRuleBased.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/sysml/runtime/controlprogram/parfor/opt/OptimizerRuleBased.java b/src/main/java/org/apache/sysml/runtime/controlprogram/parfor/opt/OptimizerRuleBased.java
index ecccbec..3153c07 100644
--- a/src/main/java/org/apache/sysml/runtime/controlprogram/parfor/opt/OptimizerRuleBased.java
+++ b/src/main/java/org/apache/sysml/runtime/controlprogram/parfor/opt/OptimizerRuleBased.java
@@ -152,7 +152,7 @@ public class OptimizerRuleBased extends Optimizer
public static final double PROB_SIZE_THRESHOLD_REMOTE = 100; //wrt # top-level iterations (min)
public static final double PROB_SIZE_THRESHOLD_PARTITIONING = 2; //wrt # top-level iterations (min)
public static final double PROB_SIZE_THRESHOLD_MB = 256*1024*1024; //wrt overall memory consumption (min)
- public static final int MAX_REPLICATION_FACTOR_PARTITIONING = 5;
+ public static final int MAX_REPLICATION_FACTOR_PARTITIONING = 5; // TODO investigate unused constant
public static final int MAX_REPLICATION_FACTOR_EXPORT = 7;
public static final boolean ALLOW_REMOTE_NESTED_PARALLELISM = false;
public static final boolean APPLY_REWRITE_NESTED_PARALLELISM = false;
http://git-wip-us.apache.org/repos/asf/incubator-systemml/blob/ca403ff1/src/main/java/org/apache/sysml/runtime/controlprogram/parfor/opt/PerfTestTool.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/sysml/runtime/controlprogram/parfor/opt/PerfTestTool.java b/src/main/java/org/apache/sysml/runtime/controlprogram/parfor/opt/PerfTestTool.java
index 3049b94..8f3e7c8 100644
--- a/src/main/java/org/apache/sysml/runtime/controlprogram/parfor/opt/PerfTestTool.java
+++ b/src/main/java/org/apache/sysml/runtime/controlprogram/parfor/opt/PerfTestTool.java
@@ -105,14 +105,9 @@ public class PerfTestTool
public static final long MAX_DATASIZE = 1000000;
public static final long DEFAULT_DATASIZE = 500000;//(MAX_DATASIZE-MIN_DATASIZE)/2;
public static final long DATASIZE_MR_SCALE = 20;
- public static final double MIN_DIMSIZE = 1;
- public static final double MAX_DIMSIZE = 1000;
public static final double MIN_SPARSITY = 0.1;
public static final double MAX_SPARSITY = 1.0;
public static final double DEFAULT_SPARSITY = 0.5;//(MAX_SPARSITY-MIN_SPARSITY)/2;
- public static final double MIN_SORT_IO_MEM = 10;
- public static final double MAX_SORT_IO_MEM = 500;
- public static final double DEFAULT_SORT_IO_MEM = 256; //BI: default 256MB, hadoop: default 100MB
//internal parameters
private static final boolean READ_STATS_ON_STARTUP = false;
http://git-wip-us.apache.org/repos/asf/incubator-systemml/blob/ca403ff1/src/main/java/org/apache/sysml/runtime/instructions/Instruction.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/sysml/runtime/instructions/Instruction.java b/src/main/java/org/apache/sysml/runtime/instructions/Instruction.java
index 9c1aea7..9a36166 100644
--- a/src/main/java/org/apache/sysml/runtime/instructions/Instruction.java
+++ b/src/main/java/org/apache/sysml/runtime/instructions/Instruction.java
@@ -48,7 +48,6 @@ public abstract class Instruction
public static final String VALUETYPE_PREFIX = Lop.VALUETYPE_PREFIX;
public static final String LITERAL_PREFIX = Lop.LITERAL_PREFIX;
public static final String INSTRUCTION_DELIM = Lop.INSTRUCTION_DELIMITOR;
- public static final String NAME_VALUE_SEPARATOR = Lop.NAME_VALUE_SEPARATOR;
public static final String SP_INST_PREFIX = "sp_";
public static final String GPU_INST_PREFIX = "gpu_";
http://git-wip-us.apache.org/repos/asf/incubator-systemml/blob/ca403ff1/src/main/java/org/apache/sysml/runtime/matrix/mapred/MRConfigurationNames.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/sysml/runtime/matrix/mapred/MRConfigurationNames.java b/src/main/java/org/apache/sysml/runtime/matrix/mapred/MRConfigurationNames.java
index fb98e1c..167bf74 100644
--- a/src/main/java/org/apache/sysml/runtime/matrix/mapred/MRConfigurationNames.java
+++ b/src/main/java/org/apache/sysml/runtime/matrix/mapred/MRConfigurationNames.java
@@ -34,11 +34,10 @@ public abstract class MRConfigurationNames {
protected static final Log LOG = LogFactory.getLog(MRConfigurationNames.class.getName());
// non-deprecated properties
- public static final String DFS_DATANODE_DATA_DIR_PERM = "dfs.datanode.data.dir.perm"; // hdfs-default.xml
public static final String DFS_REPLICATION = "dfs.replication"; // hdfs-default.xml
public static final String IO_FILE_BUFFER_SIZE = "io.file.buffer.size"; // core-default.xml
public static final String IO_SERIALIZATIONS = "io.serializations"; // core-default.xml
- public static final String MR_APPLICATION_CLASSPATH = "mapreduce.application.classpath"; // mapred-default.xml
+ public static final String MR_APPLICATION_CLASSPATH = "mapreduce.application.classpath"; // mapred-default.xml // TODO investigate unused constant
public static final String MR_CHILD_JAVA_OPTS = "mapred.child.java.opts"; // mapred-default.xml
public static final String MR_FRAMEWORK_NAME = "mapreduce.framework.name"; // mapred-default.xml
public static final String MR_JOBTRACKER_STAGING_ROOT_DIR = "mapreduce.jobtracker.staging.root.dir"; // mapred-default.xml
http://git-wip-us.apache.org/repos/asf/incubator-systemml/blob/ca403ff1/src/main/java/org/apache/sysml/runtime/matrix/mapred/MRJobConfiguration.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/sysml/runtime/matrix/mapred/MRJobConfiguration.java b/src/main/java/org/apache/sysml/runtime/matrix/mapred/MRJobConfiguration.java
index 136bd06..0745afc 100644
--- a/src/main/java/org/apache/sysml/runtime/matrix/mapred/MRJobConfiguration.java
+++ b/src/main/java/org/apache/sysml/runtime/matrix/mapred/MRJobConfiguration.java
@@ -231,17 +231,9 @@ public class MRJobConfiguration
* group name for the counters on number of output nonZeros
*/
public static final String NUM_NONZERO_CELLS="nonzeros";
-
- /*
- * Counter group for determining the dimensions of result matrix. It is
- * useful in operations like ctable and groupedAgg, in which the dimensions
- * of result matrix are known only after computing the matrix.
- */
- public static final String MAX_ROW_DIMENSION = "maxrows";
- public static final String MAX_COL_DIMENSION = "maxcols";
-
- public static final String PARFOR_NUMTASKS="numtasks";
- public static final String PARFOR_NUMITERATOINS="numiterations";
+
+ public static final String PARFOR_NUMTASKS="numtasks"; // TODO investigate unused constant
+ public static final String PARFOR_NUMITERATOINS="numiterations"; // TODO investigate unused constant
public static final String TF_NUM_COLS = "transform.num.columns";
public static final String TF_HAS_HEADER = "transform.has.header";
http://git-wip-us.apache.org/repos/asf/incubator-systemml/blob/ca403ff1/src/main/java/org/apache/sysml/runtime/matrix/mapred/MapperBase.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/sysml/runtime/matrix/mapred/MapperBase.java b/src/main/java/org/apache/sysml/runtime/matrix/mapred/MapperBase.java
index 950cc3f..a70a190 100644
--- a/src/main/java/org/apache/sysml/runtime/matrix/mapred/MapperBase.java
+++ b/src/main/java/org/apache/sysml/runtime/matrix/mapred/MapperBase.java
@@ -24,13 +24,10 @@ import java.io.IOException;
import java.util.ArrayList;
import java.util.HashSet;
-import org.apache.commons.logging.Log;
-import org.apache.commons.logging.LogFactory;
import org.apache.hadoop.io.Writable;
import org.apache.hadoop.mapred.JobConf;
import org.apache.hadoop.mapred.OutputCollector;
import org.apache.hadoop.mapred.Reporter;
-
import org.apache.sysml.runtime.DMLRuntimeException;
import org.apache.sysml.runtime.instructions.mr.AggregateBinaryInstruction;
import org.apache.sysml.runtime.instructions.mr.CSVReblockInstruction;
@@ -49,8 +46,6 @@ import org.apache.sysml.runtime.matrix.data.TaggedMatrixValue;
public abstract class MapperBase extends MRBaseForCommonInstructions
{
- protected static final Log LOG = LogFactory.getLog(MapperBase.class);
-
//the indexes that this particular input matrix file represents
protected ArrayList<Byte> representativeMatrixes=null;
http://git-wip-us.apache.org/repos/asf/incubator-systemml/blob/ca403ff1/src/main/java/org/apache/sysml/runtime/transform/GenTfMtdMR.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/sysml/runtime/transform/GenTfMtdMR.java b/src/main/java/org/apache/sysml/runtime/transform/GenTfMtdMR.java
index b71a77b..da298ae 100644
--- a/src/main/java/org/apache/sysml/runtime/transform/GenTfMtdMR.java
+++ b/src/main/java/org/apache/sysml/runtime/transform/GenTfMtdMR.java
@@ -44,8 +44,6 @@ import org.apache.sysml.runtime.matrix.mapred.MRJobConfiguration;
public class GenTfMtdMR {
- public static final String DELIM = ",";
-
public static long runJob(String inputPath, String txMtdPath, String specWithIDs, String smallestFile, String partOffsetsFile, CSVFileFormatProperties inputDataProperties, long numCols, int replication, String headerLine) throws IOException, ClassNotFoundException, InterruptedException {
JobConf job = new JobConf(GenTfMtdMR.class);
job.setJobName("GenTfMTD");
http://git-wip-us.apache.org/repos/asf/incubator-systemml/blob/ca403ff1/src/main/java/org/apache/sysml/runtime/util/UtilFunctions.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/sysml/runtime/util/UtilFunctions.java b/src/main/java/org/apache/sysml/runtime/util/UtilFunctions.java
index 036c125..a02e20a 100644
--- a/src/main/java/org/apache/sysml/runtime/util/UtilFunctions.java
+++ b/src/main/java/org/apache/sysml/runtime/util/UtilFunctions.java
@@ -45,7 +45,6 @@ public class UtilFunctions
//prime numbers for old hash function (divide prime close to max int,
//because it determines the max hash domain size
public static final long ADD_PRIME1 = 99991;
- public static final long ADD_PRIME2 = 853;
public static final int DIVIDE_PRIME = 1405695061;
public static int longHashCode(long v) {
http://git-wip-us.apache.org/repos/asf/incubator-systemml/blob/ca403ff1/src/main/java/org/apache/sysml/udf/PackageFunction.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/sysml/udf/PackageFunction.java b/src/main/java/org/apache/sysml/udf/PackageFunction.java
index 44ff86b..9b5fbd5 100644
--- a/src/main/java/org/apache/sysml/udf/PackageFunction.java
+++ b/src/main/java/org/apache/sysml/udf/PackageFunction.java
@@ -22,9 +22,6 @@ package org.apache.sysml.udf;
import java.io.Serializable;
import java.util.ArrayList;
-import org.apache.commons.logging.Log;
-import org.apache.commons.logging.LogFactory;
-
import org.apache.sysml.runtime.controlprogram.parfor.util.IDSequence;
/**
@@ -33,9 +30,7 @@ import org.apache.sysml.runtime.controlprogram.parfor.util.IDSequence;
*
*/
public abstract class PackageFunction implements Serializable
-{
- protected static final Log LOG = LogFactory.getLog(PackageFunction.class.getName());
-
+{
private static final long serialVersionUID = 3274150928865462856L;
private ArrayList<FunctionParameter> _function_inputs; // function inputs