You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/09/02 09:57:04 UTC
[GitHub] [nifi] ravitejatvs commented on a change in pull request #2231: NIFI-4521 MS SQL CDC Processor
ravitejatvs commented on a change in pull request #2231:
URL: https://github.com/apache/nifi/pull/2231#discussion_r481949000
##########
File path: nifi-nar-bundles/nifi-cdc/nifi-cdc-mssql-bundle/nifi-cdc-mssql-processors/src/main/java/org/apache/nifi/cdc/mssql/MSSQLCDCUtils.java
##########
@@ -0,0 +1,286 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.cdc.mssql;
+
+import org.apache.nifi.cdc.CDCException;
+import org.apache.nifi.cdc.event.ColumnDefinition;
+import org.apache.nifi.cdc.mssql.event.MSSQLColumnDefinition;
+import org.apache.nifi.cdc.mssql.event.MSSQLTableInfo;
+
+import java.sql.Connection;
+import java.sql.Timestamp;
+import java.sql.Types;
+import java.sql.PreparedStatement;
+import java.sql.ResultSet;
+import java.sql.SQLException;
+import java.sql.Statement;
+import java.util.ArrayList;
+import java.util.List;
+
+public class MSSQLCDCUtils {
+ private static final String _columnSplit = "\n,";
+
+ final String LIST_CHANGE_TRACKING_TABLES_SQL = "SELECT object_id,\n" +
+ " DB_NAME() AS [databaseName], \n" +
+ " SCHEMA_NAME(OBJECTPROPERTY(object_id, 'SchemaId')) AS [schemaName], \n" +
+ " OBJECT_NAME(object_id) AS [tableName], \n" +
+ " SCHEMA_NAME(OBJECTPROPERTY(source_object_id, 'SchemaId')) AS [sourceSchemaName],\n" +
+ " OBJECT_NAME(source_object_id) AS [sourceTableName] \n" +
+ "FROM [cdc].[change_tables]";
+
+ final String LIST_TABLE_COLUMNS = "select cc.object_id\n" +
+ ",cc.column_name\n" +
+ ",cc.column_id\n" +
+ ",cc.column_type\n" +
+ ",cc.column_ordinal\n" +
+ ",CASE WHEN ic.object_id IS NULL THEN 0 ELSE 1 END \"key\"\n" +
+ "FROM cdc.captured_columns cc\n" +
+ "LEFT OUTER JOIN cdc.index_columns ic ON \n" +
+ "(ic.object_id = cc.object_id AND ic.column_name = cc.column_name)\n" +
+ "where cc.object_id=?\n" +
+ "ORDER BY cc.column_ordinal";
+
+ public String getLIST_CHANGE_TRACKING_TABLES_SQL(){
+ return LIST_CHANGE_TRACKING_TABLES_SQL;
+ }
+
+ public String getLIST_TABLE_COLUMNS(){
+ return LIST_TABLE_COLUMNS;
+ }
+
+ public String getCURRENT_TIMESTAMP(){
+ return "CURRENT_TIMESTAMP";
+ }
+
+ public List<MSSQLTableInfo> getCDCTableList(Connection con) throws SQLException, CDCException {
+ ArrayList<MSSQLTableInfo> cdcTables = new ArrayList<>();
+
+ try(final Statement st = con.createStatement()){
+ final ResultSet resultSet = st.executeQuery(getLIST_CHANGE_TRACKING_TABLES_SQL());
+
+ while (resultSet.next()) {
+ int objectId = resultSet.getInt("object_id");
+ String databaseName = resultSet.getString("databaseName");
+ String schemaName = resultSet.getString("schemaName");
+ String tableName = resultSet.getString("tableName");
+ String sourceSchemaName = resultSet.getString("sourceSchemaName");
+ String sourceTableName = resultSet.getString("sourceTableName");
+
+ MSSQLTableInfo ti = new MSSQLTableInfo(databaseName, schemaName, tableName, sourceSchemaName, sourceTableName, Integer.toUnsignedLong(objectId), null);
+ cdcTables.add(ti);
+ }
+
+ for (MSSQLTableInfo ti:cdcTables) {
+ List<ColumnDefinition> tableColums = getCaptureColumns(con, ti.getTableId());
+
+ ti.setColumns(tableColums);
+ }
+ }
+
+ return cdcTables;
+ }
+
+ public List<ColumnDefinition> getCaptureColumns(Connection con, long objectId) throws SQLException, CDCException {
+ ArrayList<ColumnDefinition> tableColumns = new ArrayList<>();
+ try(final PreparedStatement st = con.prepareStatement(getLIST_TABLE_COLUMNS())){
+ st.setLong(1, objectId);
+
+ final ResultSet resultSet = st.executeQuery();
+ while (resultSet.next()) {
+ String columnName = resultSet.getString("column_name");
+ int columnId = resultSet.getInt("column_id");
+ String columnType = resultSet.getString("column_type");
+ int columnOrdinal = resultSet.getInt("column_ordinal");
+ int isColumnKey = resultSet.getInt("key");
+
+ int jdbcType = TranslateMSSQLTypeToJDBCTypes(columnType);
+
+ //get column list
+ MSSQLColumnDefinition col = new MSSQLColumnDefinition(jdbcType, columnName, columnOrdinal, isColumnKey==1);
+ tableColumns.add(col);
+ }
+ }
+
+ return tableColumns;
+ }
+
+ public String getSnapshotSelectStatement(MSSQLTableInfo tableInfo){
+ final StringBuilder sbQuery = new StringBuilder();
+
+ sbQuery.append("SELECT " + getCURRENT_TIMESTAMP() + " tran_begin_time");
+
+ sbQuery.append(_columnSplit);
+ sbQuery.append(getCURRENT_TIMESTAMP() + " \"tran_end_time\"");
+
+ sbQuery.append(_columnSplit);
+ sbQuery.append("0 trans_id");
+
+ sbQuery.append(_columnSplit);
+ sbQuery.append("0 start_lsn");
+
+ sbQuery.append(_columnSplit);
+ sbQuery.append("0 seqval");
+
+ sbQuery.append(_columnSplit);
+ sbQuery.append("2 operation");
+
+ sbQuery.append(_columnSplit);
+ sbQuery.append("0 update_mask");
+
+ for(ColumnDefinition col : tableInfo.getColumns()){
+ MSSQLColumnDefinition mssqlColumnDefinition = (MSSQLColumnDefinition)col;
+
+ sbQuery.append(_columnSplit);
+ sbQuery.append("\"" + mssqlColumnDefinition.getName() + "\"");
+ }
+
+ sbQuery.append(_columnSplit);
+ sbQuery.append(getCURRENT_TIMESTAMP() + " EXTRACT_TIME");
+ sbQuery.append("\n");
+ sbQuery.append("FROM " + tableInfo.getSourceSchemaName() + ".\""+ tableInfo.getSourceTableName() + "\"");
+
+ return sbQuery.toString();
+ }
+
+ public String getCDCSelectStatement(MSSQLTableInfo tableInfo, boolean includePreupdateValues, Timestamp maxTime){
+ final StringBuilder sbQuery = new StringBuilder();
+
+ sbQuery.append("SELECT t.tran_begin_time\n" +
+ ",t.tran_end_time \"tran_end_time\"\n" +
+ ",CAST(t.tran_id AS bigint) trans_id\n" +
+ ",CAST(\"o\".\"__$start_lsn\" AS bigint) start_lsn\n" +
+ ",CAST(\"o\".\"__$seqval\" AS bigint) seqval\n" +
Review comment:
As per Microsoft, the value of seqval can be much larger than bigint. Can you please convert this to a higher value? The source data type is binary(10) which roughly translates to decimal(29,0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org