You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/06/19 00:29:01 UTC
[kudu-CR] [consensus] remove redundant instruction
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16097
Change subject: [consensus] remove redundant instruction
......................................................................
[consensus] remove redundant instruction
Removed assignment to leader_transfer_in_progress_ after calling
std::atomic_exchange with the same desired value.
Change-Id: I4bbd40d89bcb39581dba15699bbfc9ed4036b11e
---
M src/kudu/consensus/raft_consensus.cc
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/97/16097/1
--
To view, visit http://gerrit.cloudera.org:8080/16097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4bbd40d89bcb39581dba15699bbfc9ed4036b11e
Gerrit-Change-Number: 16097
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [consensus] remove redundant instruction
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16097 )
Change subject: [consensus] remove redundant instruction
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16097/1/src/kudu/consensus/raft_consensus.cc
File src/kudu/consensus/raft_consensus.cc:
http://gerrit.cloudera.org:8080/#/c/16097/1/src/kudu/consensus/raft_consensus.cc@627
PS1, Line 627: ServiceUnavailable
Not this change but this error code is unusual when it's already in same state.
--
To view, visit http://gerrit.cloudera.org:8080/16097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4bbd40d89bcb39581dba15699bbfc9ed4036b11e
Gerrit-Change-Number: 16097
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 19 Jun 2020 21:58:05 +0000
Gerrit-HasComments: Yes
[kudu-CR] [consensus] remove redundant instruction
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16097 )
Change subject: [consensus] remove redundant instruction
......................................................................
[consensus] remove redundant instruction
Removed assignment to leader_transfer_in_progress_ after calling
std::atomic_exchange with the same desired value.
Change-Id: I4bbd40d89bcb39581dba15699bbfc9ed4036b11e
Reviewed-on: http://gerrit.cloudera.org:8080/16097
Tested-by: Kudu Jenkins
Reviewed-by: Bankim Bhavsar <ba...@cloudera.com>
---
M src/kudu/consensus/raft_consensus.cc
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Kudu Jenkins: Verified
Bankim Bhavsar: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/16097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4bbd40d89bcb39581dba15699bbfc9ed4036b11e
Gerrit-Change-Number: 16097
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [consensus] remove redundant instruction
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16097 )
Change subject: [consensus] remove redundant instruction
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16097/1/src/kudu/consensus/raft_consensus.cc
File src/kudu/consensus/raft_consensus.cc:
http://gerrit.cloudera.org:8080/#/c/16097/1/src/kudu/consensus/raft_consensus.cc@627
PS1, Line 627: ServiceUnavailable
> Not this change but this error code is unusual when it's already in same st
Yeah, another option would be simply returning Status::OK(). I'm not sure it's safe to change it right away without a risk to break corresponding tests: probably, this deserves to be in a separate patch, if changing this.
--
To view, visit http://gerrit.cloudera.org:8080/16097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4bbd40d89bcb39581dba15699bbfc9ed4036b11e
Gerrit-Change-Number: 16097
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 19 Jun 2020 22:28:26 +0000
Gerrit-HasComments: Yes