You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/06/14 07:43:20 UTC

[GitHub] [shardingsphere] ThanoshanMV opened a new pull request #10759: Add selectList, fromClause definitions for Oracle Select

ThanoshanMV opened a new pull request #10759:
URL: https://github.com/apache/shardingsphere/pull/10759


   #10111 
   
   Changes proposed in this pull request:
   -  Added SQL definition for [SELECT](https://docs.oracle.com/en/database/oracle/oracle-database/19/sqlrf/SELECT.html#GUID-CFA006CA-6FF1-4972-821E-6996142A51C6) statement's `selectList` and `fromClause`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] wgy8283335 commented on pull request #10759: Add selectList, fromClause definitions for Oracle Select

Posted by GitBox <gi...@apache.org>.
wgy8283335 commented on pull request #10759:
URL: https://github.com/apache/shardingsphere/pull/10759#issuecomment-868260054


   @ThanoshanMV, hi. 
   Maybe you could try to use this tool to generate rule.
   ![image](https://user-images.githubusercontent.com/22066046/123380479-15243c00-d5c2-11eb-9cc9-6f9b839da033.png)
   https://github.com/wgy8283335/shardingsphere/tree/10104-oracle-antlr-transfer-tool


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] ThanoshanMV commented on pull request #10759: Add selectList, fromClause definitions for Oracle Select

Posted by GitBox <gi...@apache.org>.
ThanoshanMV commented on pull request #10759:
URL: https://github.com/apache/shardingsphere/pull/10759#issuecomment-869885883


   Hi @wgy8283335, I've resolved the above issue 😄
   
   Since the generated file size is too big, AppCode couldn't able to provide code assistance. We have to change the file size limit from the default value as specified in the [documentation](https://www.jetbrains.com/help/objc/configuring-file-size-limit.html#file-size-limit).
   
   I'll try to finish the remaining works in this PR and let you know.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] ThanoshanMV commented on pull request #10759: Add selectList, fromClause definitions for Oracle Select

Posted by GitBox <gi...@apache.org>.
ThanoshanMV commented on pull request #10759:
URL: https://github.com/apache/shardingsphere/pull/10759#issuecomment-862167741


   > Why do you remove `rowPatternClause`, `pivotClause` and `unpivotClause` ?
   
   Like you mentioned I tried to add rules one by one. I found out when trying to add `rowPatternClause`, `pivotClause` and `unpivotClause`, it gave me the error in `OracleDMLStatementSQLVisitor`:
   
   ![Error](https://user-images.githubusercontent.com/48581379/122182419-e6161800-cea7-11eb-98af-0edc74367ca9.png)
   
   Even if I try to add one rule among those three rules, the error stays the same. 
   
   If I remove those three rules then there are no more errors and I can able to use auto-generated contexts:
   
   ![NoError](https://user-images.githubusercontent.com/48581379/122184364-c4b62b80-cea9-11eb-9983-c854e30e0951.png)
   
   I hope the above-mentioned errors aren't specific to me. Can you please check whether you can able to reproduce the same error?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] wgy8283335 commented on pull request #10759: Add selectList, fromClause definitions for Oracle Select

Posted by GitBox <gi...@apache.org>.
wgy8283335 commented on pull request #10759:
URL: https://github.com/apache/shardingsphere/pull/10759#issuecomment-867353121


   > Hi @wgy8283335. I checked the rules, I couldn't able to find where the bug resides.
   > 
   > I added `rowPatternClause`, `pivotClause` and `unpivotClause`. I tried to reformat the rules in DMLStatement similar to DDLStatement and ensured that all rules in DMLStatement can't over 200 chars. Still, that issue persists. Can you please help me to find why this issue comes and to resolve it.
   
   OK, I'll have a look on it.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] wgy8283335 commented on pull request #10759: Add selectList, fromClause definitions for Oracle Select

Posted by GitBox <gi...@apache.org>.
wgy8283335 commented on pull request #10759:
URL: https://github.com/apache/shardingsphere/pull/10759#issuecomment-874393090


   > So... it is ready to be merged? @wgy8283335
   
   Not yet. This pr is big, and I am still working on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] ThanoshanMV commented on pull request #10759: Add selectList, fromClause definitions for Oracle Select

Posted by GitBox <gi...@apache.org>.
ThanoshanMV commented on pull request #10759:
URL: https://github.com/apache/shardingsphere/pull/10759#issuecomment-864795811


   Hi @wgy8283335. I checked the rules, I couldn't able to find where the bug resides. 
   
   I added `rowPatternClause`, `pivotClause` and `unpivotClause`. I tried to reformat the rules in DMLStatement similar to DDLStatement and ensured that all rules in DMLStatement can't over 200 chars. Still, that issue persists. Can you please help me to find why this issue comes and to resolve it
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] wgy8283335 commented on pull request #10759: Add selectList, fromClause definitions for Oracle Select

Posted by GitBox <gi...@apache.org>.
wgy8283335 commented on pull request #10759:
URL: https://github.com/apache/shardingsphere/pull/10759#issuecomment-861921464


   > I've removed `rowPatternClause`, `pivotClause` and `unpivotClause` from the definition. After removing them, I think now that error isn't coming. Please check on how it's like for you.
   
   Why do you remove `rowPatternClause`, `pivotClause` and `unpivotClause` ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] ThanoshanMV commented on pull request #10759: Add selectList, fromClause definitions for Oracle Select

Posted by GitBox <gi...@apache.org>.
ThanoshanMV commented on pull request #10759:
URL: https://github.com/apache/shardingsphere/pull/10759#issuecomment-868685291


   Hi @wgy8283335, Okay I'll check that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter commented on pull request #10759: Add selectList, fromClause definitions for Oracle Select

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10759:
URL: https://github.com/apache/shardingsphere/pull/10759#issuecomment-859341233


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10759?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#10759](https://codecov.io/gh/apache/shardingsphere/pull/10759?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a3c5550) into [master](https://codecov.io/gh/apache/shardingsphere/commit/5ad1c76b366549a057205d9eb5345a9f436a8431?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5ad1c76) will **increase** coverage by `0.25%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/10759/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/shardingsphere/pull/10759?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #10759      +/-   ##
   ============================================
   + Coverage     65.19%   65.44%   +0.25%     
     Complexity      689      689              
   ============================================
     Files          1779     1780       +1     
     Lines         30809    30823      +14     
     Branches       5541     5551      +10     
   ============================================
   + Hits          20086    20173      +87     
   + Misses         9127     9045      -82     
   - Partials       1596     1605       +9     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/10759?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...her/type/AlterTableStatementFederateRefresher.java](https://codecov.io/gh/apache/shardingsphere/pull/10759/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtb3B0aW1pemUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL29wdGltaXplL2NvcmUvbWV0YWRhdGEvcmVmcmVzaGVyL3R5cGUvQWx0ZXJUYWJsZVN0YXRlbWVudEZlZGVyYXRlUmVmcmVzaGVyLmphdmE=) | `81.48% <0.00%> (ø)` | |
   | [...t/metadata/refresher/MetadataRefresherFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/10759/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29udGV4dC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvY29udGV4dC9tZXRhZGF0YS9yZWZyZXNoZXIvTWV0YWRhdGFSZWZyZXNoZXJGYWN0b3J5LmphdmE=) | `92.00% <0.00%> (+0.33%)` | :arrow_up: |
   | [...ing/core/job/task/incremental/IncrementalTask.java](https://codecov.io/gh/apache/shardingsphere/pull/10759/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvdGFzay9pbmNyZW1lbnRhbC9JbmNyZW1lbnRhbFRhc2suamF2YQ==) | `75.00% <0.00%> (+2.08%)` | :arrow_up: |
   | [...ore/statement/ShardingSpherePreparedStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/10759/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9qZGJjL2NvcmUvc3RhdGVtZW50L1NoYXJkaW5nU3BoZXJlUHJlcGFyZWRTdGF0ZW1lbnQuamF2YQ==) | `78.60% <0.00%> (+4.62%)` | :arrow_up: |
   | [...r/jdbc/core/statement/ShardingSphereStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/10759/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9qZGJjL2NvcmUvc3RhdGVtZW50L1NoYXJkaW5nU3BoZXJlU3RhdGVtZW50LmphdmE=) | `64.06% <0.00%> (+5.65%)` | :arrow_up: |
   | [...scaling/core/job/task/inventory/InventoryTask.java](https://codecov.io/gh/apache/shardingsphere/pull/10759/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvdGFzay9pbnZlbnRvcnkvSW52ZW50b3J5VGFzay5qYXZh) | `75.55% <0.00%> (+6.66%)` | :arrow_up: |
   | [...re/scaling/core/executor/engine/ExecuteEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/10759/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9leGVjdXRvci9lbmdpbmUvRXhlY3V0ZUVuZ2luZS5qYXZh) | `100.00% <0.00%> (+11.11%)` | :arrow_up: |
   | [...ent/select/projection/engine/ProjectionEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/10759/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtYmluZGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9iaW5kZXIvc2VnbWVudC9zZWxlY3QvcHJvamVjdGlvbi9lbmdpbmUvUHJvamVjdGlvbkVuZ2luZS5qYXZh) | `89.55% <0.00%> (+11.94%)` | :arrow_up: |
   | [...sphere/scaling/core/job/schedule/JobScheduler.java](https://codecov.io/gh/apache/shardingsphere/pull/10759/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2Ivc2NoZWR1bGUvSm9iU2NoZWR1bGVyLmphdmE=) | `51.85% <0.00%> (+29.62%)` | :arrow_up: |
   | [...optimize/core/metadata/FederateSchemaMetadata.java](https://codecov.io/gh/apache/shardingsphere/pull/10759/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtb3B0aW1pemUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL29wdGltaXplL2NvcmUvbWV0YWRhdGEvRmVkZXJhdGVTY2hlbWFNZXRhZGF0YS5qYXZh) | `30.95% <0.00%> (+30.95%)` | :arrow_up: |
   | ... and [1 more](https://codecov.io/gh/apache/shardingsphere/pull/10759/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10759?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10759?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5ad1c76...a3c5550](https://codecov.io/gh/apache/shardingsphere/pull/10759?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] wgy8283335 commented on pull request #10759: Add selectList, fromClause definitions for Oracle Select

Posted by GitBox <gi...@apache.org>.
wgy8283335 commented on pull request #10759:
URL: https://github.com/apache/shardingsphere/pull/10759#issuecomment-873502543


   I'd like to take care of this merge request.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] ThanoshanMV commented on pull request #10759: Add selectList, fromClause definitions for Oracle Select

Posted by GitBox <gi...@apache.org>.
ThanoshanMV commented on pull request #10759:
URL: https://github.com/apache/shardingsphere/pull/10759#issuecomment-864211382


   I'll check them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero edited a comment on pull request #10759: Add selectList, fromClause definitions for Oracle Select

Posted by GitBox <gi...@apache.org>.
tristaZero edited a comment on pull request #10759:
URL: https://github.com/apache/shardingsphere/pull/10759#issuecomment-873565956


   So... it is ready to be merged? @wgy8283335 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #10759: Add selectList, fromClause definitions for Oracle Select

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10759:
URL: https://github.com/apache/shardingsphere/pull/10759#issuecomment-859341233


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10759?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#10759](https://codecov.io/gh/apache/shardingsphere/pull/10759?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e630fc1) into [master](https://codecov.io/gh/apache/shardingsphere/commit/7167a104b9612a4b065e77a9c8f9302242673a5b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7167a10) will **decrease** coverage by `0.03%`.
   > The diff coverage is `65.88%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/10759/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/shardingsphere/pull/10759?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #10759      +/-   ##
   ============================================
   - Coverage     63.92%   63.89%   -0.04%     
     Complexity     1023     1023              
   ============================================
     Files          2175     2175              
     Lines         33322    33346      +24     
     Branches       5835     5841       +6     
   ============================================
   + Hits          21300    21305       +5     
   - Misses        10324    10333       +9     
   - Partials       1698     1708      +10     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/10759?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...r/statement/impl/OracleDMLStatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/10759/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1vcmFjbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvb3JhY2xlL3Zpc2l0b3Ivc3RhdGVtZW50L2ltcGwvT3JhY2xlRE1MU3RhdGVtZW50U1FMVmlzaXRvci5qYXZh) | `73.62% <65.88%> (-5.43%)` | :arrow_down: |
   | [...onfig/YamlReadwriteSplittingRuleConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/10759/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVhZHdyaXRlLXNwbGl0dGluZy9zaGFyZGluZ3NwaGVyZS1yZWFkd3JpdGUtc3BsaXR0aW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3JlYWR3cml0ZXNwbGl0dGluZy95YW1sL2NvbmZpZy9ZYW1sUmVhZHdyaXRlU3BsaXR0aW5nUnVsZUNvbmZpZ3VyYXRpb24uamF2YQ==) | `75.00% <0.00%> (-25.00%)` | :arrow_down: |
   | [...or/statement/impl/SQL92DMLStatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/10759/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1zcWw5Mi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWw5Mi92aXNpdG9yL3N0YXRlbWVudC9pbXBsL1NRTDkyRE1MU3RhdGVtZW50U1FMVmlzaXRvci5qYXZh) | `76.64% <0.00%> (-6.60%)` | :arrow_down: |
   | [...eadwriteSplittingRuleConfigurationYamlSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/10759/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVhZHdyaXRlLXNwbGl0dGluZy9zaGFyZGluZ3NwaGVyZS1yZWFkd3JpdGUtc3BsaXR0aW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3JlYWR3cml0ZXNwbGl0dGluZy95YW1sL3N3YXBwZXIvUmVhZHdyaXRlU3BsaXR0aW5nUnVsZUNvbmZpZ3VyYXRpb25ZYW1sU3dhcHBlci5qYXZh) | `88.88% <0.00%> (-3.71%)` | :arrow_down: |
   | [...sitor/statement/impl/SQL92StatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/10759/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1zcWw5Mi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWw5Mi92aXNpdG9yL3N0YXRlbWVudC9pbXBsL1NRTDkyU3RhdGVtZW50U1FMVmlzaXRvci5qYXZh) | `71.98% <0.00%> (-1.94%)` | :arrow_down: |
   | [...e/AlterReadwriteSplittingRuleStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/10759/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVhZHdyaXRlLXNwbGl0dGluZy9zaGFyZGluZ3NwaGVyZS1yZWFkd3JpdGUtc3BsaXR0aW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3JlYWR3cml0ZXNwbGl0dGluZy9kaXN0c3FsL3VwZGF0ZS9BbHRlclJlYWR3cml0ZVNwbGl0dGluZ1J1bGVTdGF0ZW1lbnRVcGRhdGVyLmphdmE=) | | |
   | [...ion/ReadwriteSplittingRuleNotExistedException.java](https://codecov.io/gh/apache/shardingsphere/pull/10759/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVhZHdyaXRlLXNwbGl0dGluZy9zaGFyZGluZ3NwaGVyZS1yZWFkd3JpdGUtc3BsaXR0aW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3JlYWR3cml0ZXNwbGl0dGluZy9kaXN0c3FsL2V4Y2VwdGlvbi9SZWFkd3JpdGVTcGxpdHRpbmdSdWxlTm90RXhpc3RlZEV4Y2VwdGlvbi5qYXZh) | | |
   | [...rter/ReadwriteSplittingRuleStatementConverter.java](https://codecov.io/gh/apache/shardingsphere/pull/10759/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVhZHdyaXRlLXNwbGl0dGluZy9zaGFyZGluZ3NwaGVyZS1yZWFkd3JpdGUtc3BsaXR0aW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3JlYWR3cml0ZXNwbGl0dGluZy95YW1sL2NvbnZlcnRlci9SZWFkd3JpdGVTcGxpdHRpbmdSdWxlU3RhdGVtZW50Q29udmVydGVyLmphdmE=) | | |
   | [...te/DropReadwriteSplittingRuleStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/10759/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVhZHdyaXRlLXNwbGl0dGluZy9zaGFyZGluZ3NwaGVyZS1yZWFkd3JpdGUtc3BsaXR0aW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3JlYWR3cml0ZXNwbGl0dGluZy9kaXN0c3FsL3VwZGF0ZS9Ecm9wUmVhZHdyaXRlU3BsaXR0aW5nUnVsZVN0YXRlbWVudFVwZGF0ZXIuamF2YQ==) | | |
   | ... and [15 more](https://codecov.io/gh/apache/shardingsphere/pull/10759/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10759?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10759?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7167a10...e630fc1](https://codecov.io/gh/apache/shardingsphere/pull/10759?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] wgy8283335 commented on pull request #10759: Add selectList, fromClause definitions for Oracle Select

Posted by GitBox <gi...@apache.org>.
wgy8283335 commented on pull request #10759:
URL: https://github.com/apache/shardingsphere/pull/10759#issuecomment-863908783


   > > Why do you remove `rowPatternClause`, `pivotClause` and `unpivotClause` ?
   > 
   > Like you mentioned I tried to add rules one by one. I found out when trying to add `rowPatternClause`, `pivotClause` and `unpivotClause`, it gave me the error in `OracleDMLStatementSQLVisitor`:
   > 
   > ![Error](https://user-images.githubusercontent.com/48581379/122182419-e6161800-cea7-11eb-98af-0edc74367ca9.png)
   > 
   > Even if I try to add one rule among those three rules, the error stays the same.
   > 
   > If I remove those three rules then there are no more errors and I can able to use auto-generated contexts:
   > 
   > ![NoError](https://user-images.githubusercontent.com/48581379/122184364-c4b62b80-cea9-11eb-9983-c854e30e0951.png)
   > 
   > I hope the above-mentioned errors aren't specific to me. Can you please check whether you can able to reproduce the same error?
   There may be some bugs in your rule.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] ThanoshanMV commented on pull request #10759: Add selectList, fromClause definitions for Oracle Select

Posted by GitBox <gi...@apache.org>.
ThanoshanMV commented on pull request #10759:
URL: https://github.com/apache/shardingsphere/pull/10759#issuecomment-869885883


   Hi @wgy8283335, I've resolved the above issue 😄
   
   Since the generated file size is too big, AppCode couldn't able to provide code assistance. We have to change the file size limit from the default value as specified in the [documentation](https://www.jetbrains.com/help/objc/configuring-file-size-limit.html#file-size-limit).
   
   I'll try to finish the remaining works in this PR and let you know.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] wgy8283335 commented on a change in pull request #10759: Add selectList, fromClause definitions for Oracle Select

Posted by GitBox <gi...@apache.org>.
wgy8283335 commented on a change in pull request #10759:
URL: https://github.com/apache/shardingsphere/pull/10759#discussion_r652260311



##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/antlr4/imports/oracle/BaseRule.g4
##########
@@ -731,3 +735,39 @@ unitName
 procedureName
     : identifier
     ;
+
+validTimeColumn
+    : columnName
+    ;
+
+attrDim
+    : identifier
+    ;
+
+hierarchyName
+    : (owner DOT_)? name
+    ;
+
+analyticViewName
+    : (owner DOT_)? name
+    ;
+
+samplePercent
+    : numberLiterals
+    ;
+
+seedValue
+    : numberLiterals
+    ;
+
+condition
+    : expr
+    ;
+
+variableName
+    : identifier | STRING_
+    ;
+
+externalTableDataProps

Review comment:
       It's better to move the rule to DDLStatement. And rename the rule and copy the rule in DMLStatement.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] ThanoshanMV commented on pull request #10759: Add selectList, fromClause definitions for Oracle Select

Posted by GitBox <gi...@apache.org>.
ThanoshanMV commented on pull request #10759:
URL: https://github.com/apache/shardingsphere/pull/10759#issuecomment-859327449






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #10759: Add selectList, fromClause definitions for Oracle Select

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10759:
URL: https://github.com/apache/shardingsphere/pull/10759#issuecomment-859341233


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10759?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#10759](https://codecov.io/gh/apache/shardingsphere/pull/10759?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e7b3721) into [master](https://codecov.io/gh/apache/shardingsphere/commit/b08767cbe237956734f1acc1cf8a49241542d478?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b08767c) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/10759/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/shardingsphere/pull/10759?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master   #10759   +/-   ##
   =========================================
     Coverage     65.85%   65.85%           
     Complexity      707      707           
   =========================================
     Files          1802     1802           
     Lines         30798    30798           
     Branches       5550     5550           
   =========================================
     Hits          20283    20283           
     Misses         8911     8911           
     Partials       1604     1604           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10759?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10759?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b08767c...e7b3721](https://codecov.io/gh/apache/shardingsphere/pull/10759?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #10759: Add selectList, fromClause definitions for Oracle Select

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10759:
URL: https://github.com/apache/shardingsphere/pull/10759#issuecomment-859341233


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10759?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#10759](https://codecov.io/gh/apache/shardingsphere/pull/10759?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b95b716) into [master](https://codecov.io/gh/apache/shardingsphere/commit/28e247ec9517335a2ae4c34faaa124328449e6b0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (28e247e) will **decrease** coverage by `0.15%`.
   > The diff coverage is `65.88%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/10759/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/shardingsphere/pull/10759?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #10759      +/-   ##
   ============================================
   - Coverage     63.49%   63.34%   -0.16%     
     Complexity     1011     1011              
   ============================================
     Files          2185     2185              
     Lines         33389    33429      +40     
     Branches       5844     5850       +6     
   ============================================
   - Hits          21202    21176      -26     
   - Misses        10505    10563      +58     
   - Partials       1682     1690       +8     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/10759?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...r/statement/impl/OracleDMLStatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/10759/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1vcmFjbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvb3JhY2xlL3Zpc2l0b3Ivc3RhdGVtZW50L2ltcGwvT3JhY2xlRE1MU3RhdGVtZW50U1FMVmlzaXRvci5qYXZh) | `73.62% <65.88%> (-5.43%)` | :arrow_down: |
   | [...sphere/scaling/core/job/schedule/JobScheduler.java](https://codecov.io/gh/apache/shardingsphere/pull/10759/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2Ivc2NoZWR1bGUvSm9iU2NoZWR1bGVyLmphdmE=) | `22.22% <0.00%> (-29.63%)` | :arrow_down: |
   | [...re/scaling/core/executor/engine/ExecuteEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/10759/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9leGVjdXRvci9lbmdpbmUvRXhlY3V0ZUVuZ2luZS5qYXZh) | `88.88% <0.00%> (-11.12%)` | :arrow_down: |
   | [...scaling/core/job/task/inventory/InventoryTask.java](https://codecov.io/gh/apache/shardingsphere/pull/10759/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvdGFzay9pbnZlbnRvcnkvSW52ZW50b3J5VGFzay5qYXZh) | `68.88% <0.00%> (-6.67%)` | :arrow_down: |
   | [...or/statement/impl/SQL92DMLStatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/10759/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1zcWw5Mi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWw5Mi92aXNpdG9yL3N0YXRlbWVudC9pbXBsL1NRTDkyRE1MU3RhdGVtZW50U1FMVmlzaXRvci5qYXZh) | `76.64% <0.00%> (-6.60%)` | :arrow_down: |
   | [...ing/core/job/task/incremental/IncrementalTask.java](https://codecov.io/gh/apache/shardingsphere/pull/10759/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvdGFzay9pbmNyZW1lbnRhbC9JbmNyZW1lbnRhbFRhc2suamF2YQ==) | `72.91% <0.00%> (-2.09%)` | :arrow_down: |
   | [...sitor/statement/impl/SQL92StatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/10759/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1zcWw5Mi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWw5Mi92aXNpdG9yL3N0YXRlbWVudC9pbXBsL1NRTDkyU3RhdGVtZW50U1FMVmlzaXRvci5qYXZh) | `71.98% <0.00%> (-1.94%)` | :arrow_down: |
   | [...itor/statement/impl/OracleStatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/10759/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1vcmFjbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvb3JhY2xlL3Zpc2l0b3Ivc3RhdGVtZW50L2ltcGwvT3JhY2xlU3RhdGVtZW50U1FMVmlzaXRvci5qYXZh) | `73.61% <0.00%> (+1.85%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10759?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10759?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [28e247e...b95b716](https://codecov.io/gh/apache/shardingsphere/pull/10759?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] wgy8283335 edited a comment on pull request #10759: Add selectList, fromClause definitions for Oracle Select

Posted by GitBox <gi...@apache.org>.
wgy8283335 edited a comment on pull request #10759:
URL: https://github.com/apache/shardingsphere/pull/10759#issuecomment-863908783


   > > Why do you remove `rowPatternClause`, `pivotClause` and `unpivotClause` ?
   > 
   > Like you mentioned I tried to add rules one by one. I found out when trying to add `rowPatternClause`, `pivotClause` and `unpivotClause`, it gave me the error in `OracleDMLStatementSQLVisitor`:
   > 
   > ![Error](https://user-images.githubusercontent.com/48581379/122182419-e6161800-cea7-11eb-98af-0edc74367ca9.png)
   > 
   > Even if I try to add one rule among those three rules, the error stays the same.
   > 
   > If I remove those three rules then there are no more errors and I can able to use auto-generated contexts:
   > 
   > ![NoError](https://user-images.githubusercontent.com/48581379/122184364-c4b62b80-cea9-11eb-9983-c854e30e0951.png)
   > 
   > I hope the above-mentioned errors aren't specific to me. Can you please check whether you can able to reproduce the same error?
   
   There may be some bugs in your rule. @ThanoshanMV 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] wgy8283335 commented on pull request #10759: Add selectList, fromClause definitions for Oracle Select

Posted by GitBox <gi...@apache.org>.
wgy8283335 commented on pull request #10759:
URL: https://github.com/apache/shardingsphere/pull/10759#issuecomment-859988395






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] ThanoshanMV commented on pull request #10759: Add selectList, fromClause definitions for Oracle Select

Posted by GitBox <gi...@apache.org>.
ThanoshanMV commented on pull request #10759:
URL: https://github.com/apache/shardingsphere/pull/10759#issuecomment-861012998


   I've removed `rowPatternClause`, `pivotClause` and `unpivotClause` from the definition. After removing them, I think now that error isn't coming. Please check on how it's like for you. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] ThanoshanMV commented on pull request #10759: Add selectList, fromClause definitions for Oracle Select

Posted by GitBox <gi...@apache.org>.
ThanoshanMV commented on pull request #10759:
URL: https://github.com/apache/shardingsphere/pull/10759#issuecomment-864795811


   Hi @wgy8283335. I checked the rules, I couldn't able to find where the bug resides. 
   
   I added `rowPatternClause`, `pivotClause` and `unpivotClause`. I tried to reformat the rules in DMLStatement similar to DDLStatement and ensured that all rules in DMLStatement can't over 200 chars. Still, that issue persists. Can you please help me to find why this issue comes and to resolve it
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] wgy8283335 merged pull request #10759: Add selectList, fromClause definitions for Oracle Select

Posted by GitBox <gi...@apache.org>.
wgy8283335 merged pull request #10759:
URL: https://github.com/apache/shardingsphere/pull/10759


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #10759: Add selectList, fromClause definitions for Oracle Select

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10759:
URL: https://github.com/apache/shardingsphere/pull/10759#issuecomment-859341233


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10759?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#10759](https://codecov.io/gh/apache/shardingsphere/pull/10759?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e7b3721) into [master](https://codecov.io/gh/apache/shardingsphere/commit/b08767cbe237956734f1acc1cf8a49241542d478?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b08767c) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/10759/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/shardingsphere/pull/10759?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master   #10759   +/-   ##
   =========================================
     Coverage     65.85%   65.85%           
     Complexity      707      707           
   =========================================
     Files          1802     1802           
     Lines         30798    30798           
     Branches       5550     5550           
   =========================================
     Hits          20283    20283           
     Misses         8911     8911           
     Partials       1604     1604           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10759?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10759?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b08767c...e7b3721](https://codecov.io/gh/apache/shardingsphere/pull/10759?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] ThanoshanMV commented on pull request #10759: Add selectList, fromClause definitions for Oracle Select

Posted by GitBox <gi...@apache.org>.
ThanoshanMV commented on pull request #10759:
URL: https://github.com/apache/shardingsphere/pull/10759#issuecomment-861010223


   `inlineExternalTable` has `columnDefinition` and `inlineExternalTableProperties` has `externalTableDataProps` in the DMLStatement. Both `columnDefinition` and `externalTableDataProps` are in DDLStatement.
   
   Initially I was able to put `externalTableDataProps` in BaseRule but couldn't able to put `columnDefinition` as its `inlineConstraint` has `createIndex` rule:
   
   ![createIndexClause](https://user-images.githubusercontent.com/48581379/121957485-15316a00-cd80-11eb-9ef1-e75f56b4147a.png)
   
   I also agree on not to put DDLStatement in import. I've added  `externalTableDataProps` in BaseRule. How can we specify `columnDefinition` in DMLStatement?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] wgy8283335 commented on pull request #10759: Add selectList, fromClause definitions for Oracle Select

Posted by GitBox <gi...@apache.org>.
wgy8283335 commented on pull request #10759:
URL: https://github.com/apache/shardingsphere/pull/10759#issuecomment-874393090


   > So... it is ready to be merged? @wgy8283335
   
   Not yet. This pr is big, and I am still working on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on pull request #10759: Add selectList, fromClause definitions for Oracle Select

Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #10759:
URL: https://github.com/apache/shardingsphere/pull/10759#issuecomment-873565956


   So... it is ready to be merged?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org