[GitHub] [netbeans] eirikbakke commented on a change in pull request #1865: [NETBEANS-3428] FlatLaf: multi-tabs in FlatLaf style

[GitBox <gi...@apache.org>]

eirikbakke commented on a change in pull request #1865: [NETBEANS-3428] FlatLaf: multi-tabs in FlatLaf style
URL: https://github.com/apache/netbeans/pull/1865#discussion_r365630432
 
 

 ##########
 File path: platform/core.multitabs/src/org/netbeans/core/multitabs/impl/ProjectColorTabDecorator.java
 ##########
 @@ -63,15 +62,27 @@ public void stateChanged(ChangeEvent e) {
 
     static {
         backGroundColors = new ArrayList<Color>( 10 );
-        backGroundColors.add( new Color( 216, 255, 237 ) );
-        backGroundColors.add( new Color( 255, 221, 221 ) );
-        backGroundColors.add( new Color( 255, 247, 214 ) );
-        backGroundColors.add( new Color( 216, 239, 255 ) );
-        backGroundColors.add( new Color( 241, 255, 209 ) );
-        backGroundColors.add( new Color( 255, 225, 209 ) );
-        backGroundColors.add( new Color( 228, 255, 216 ) );
-        backGroundColors.add( new Color( 227, 255, 158 ) );
-        backGroundColors.add( new Color( 238, 209, 255 ) );
+
+        // load background colors from UI defaults if available
+        if (UIManager.getColor("nb.multitabs.project.1.background") != null) {
+            for (int i = 1; i <= 100; i++) {
+                Color color = UIManager.getColor("nb.multitabs.project." + i + ".background");
 
 Review comment:
   Is this a gradient of some sort? Better to specify start and end colors, and interpolate, than have up to 100 properties. That will look better on HiDPI displays too (since you can actually get a smooth gradient rather than N hard steps).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists