[GitHub] [fineract] adamsaghy commented on a diff in pull request #3370: FINERACT-1724: Wrong status (error) code retrieved when invalid reque…

["adamsaghy (via GitHub)" <gi...@apache.org>]

adamsaghy commented on code in PR #3370:
URL: https://github.com/apache/fineract/pull/3370#discussion_r1291317045


##########
fineract-core/src/main/java/org/apache/fineract/batch/service/BatchApiServiceImpl.java:
##########
@@ -156,11 +159,16 @@ private void callRequestRecursive(BatchRequest request, BatchRequestNode request
                 BatchRequest resolvedChildRequest;
                 try {
                     resolvedChildRequest = this.resolutionHelper.resoluteRequest(childNode.getRequest(), response);
+                } catch (JsonPathException jsonPathException) {

Review Comment:
   Please instead of this use error mapping instead. See `InvalidJsonExceptionMapper`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org