You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/08/19 06:00:05 UTC

[GitHub] [shardingsphere] tristaZero commented on a change in pull request #11800: refactored document of GOVERNANCE

tristaZero commented on a change in pull request #11800:
URL: https://github.com/apache/shardingsphere/pull/11800#discussion_r691808055



##########
File path: shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/config/properties/ConfigurationPropertyKey.java
##########
@@ -116,7 +116,7 @@
     /**
      * Whether enable show process list.
      */
-    SHOW_PROCESS_LIST_ENABLED("show-process-list-enabled", String.valueOf(false), boolean.class),
+    SHOW_PROCESS_LIST_ENABLED("show-process-list-enabled", String.valueOf(Boolean.FALSE), boolean.class),

Review comment:
       Hi why do we use `Boolean.FALSE`? I suppose the third parameter defines the type of this property and will do conversion somehow. In that way, do you think we need to do such changes?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org